[Buildroot] [git commit] eglibc: add comment explaining why we pass -O2

[Buildroot] [git commit] eglibc: add comment explaining why we pass -O2

[Thomas Petazzoni]

commit: http://git.buildroot.net/buildroot/commit/?id=f443c8317bfadfdfdfe38a1731dcfbdba3a6d0ae
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

While reviewing the eglibc package, Peter mentionned that it would be
good to add a comment that explains why we explicitly build eglibc
with -O2 instead of using the user selected optimization level. This
commit add such a comment.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/eglibc/eglibc.mk |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/package/eglibc/eglibc.mk b/package/eglibc/eglibc.mk
index 253dabd..8873a06 100644
--- a/package/eglibc/eglibc.mk
+++ b/package/eglibc/eglibc.mk
@@ -36,6 +36,9 @@ endif
 #
 #  2. We have to execute the configure script with bash and not sh.
 #
+# Note that as mentionned in
+# http://patches.openembedded.org/patch/38849/, eglibc must be built
+# with -O2, so we pass our own CFLAGS and CXXFLAGS below.
 define EGLIBC_CONFIGURE_CMDS
 	mkdir -p $(@D)/build
 	# Do the configuration

[Buildroot] [git commit] eglibc: add comment explaining why we pass -O2

[Thomas De Schampheleire]

Hi Thomas,

On Tue, Aug 6, 2013 at 12:46 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=f443c8317bfadfdfdfe38a1731dcfbdba3a6d0ae
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> While reviewing the eglibc package, Peter mentionned that it would be
> good to add a comment that explains why we explicitly build eglibc
> with -O2 instead of using the user selected optimization level. This
> commit add such a comment.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/eglibc/eglibc.mk |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/package/eglibc/eglibc.mk b/package/eglibc/eglibc.mk
> index 253dabd..8873a06 100644
> --- a/package/eglibc/eglibc.mk
> +++ b/package/eglibc/eglibc.mk
> @@ -36,6 +36,9 @@ endif
>  #
>  #  2. We have to execute the configure script with bash and not sh.
>  #
> +# Note that as mentionned in

s/mentionned/mentioned/

> +# http://patches.openembedded.org/patch/38849/, eglibc must be built
> +# with -O2, so we pass our own CFLAGS and CXXFLAGS below.
>  define EGLIBC_CONFIGURE_CMDS
>         mkdir -p $(@D)/build
>         # Do the configuration


Best regards,
Thomas

[Buildroot] [git commit] eglibc: add comment explaining why we pass -O2

[Thomas Petazzoni]

Dear Thomas De Schampheleire,

On Tue, 6 Aug 2013 13:44:26 +0200, Thomas De Schampheleire wrote:

> >  #  2. We have to execute the configure script with bash and not sh.
> >  #
> > +# Note that as mentionned in
> 
> s/mentionned/mentioned/

Gaah, of course, as soon as I commit myself a trivial patch, I manage
to do stupid things in the patch...

Thanks for noticing,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com