[Buildroot] Removing/solving gettext dependencies in libuio

[Buildroot] Removing/solving gettext dependencies in libuio

[Thomas De Schampheleire]

Hi,

I'm adding the library libuio to buildroot
(https://github.com/Linutronix/libuio/).
This library expects gettext to be present, but I want to avoid adding
this dependency to buildroot because it really isn't needed.

What is the best way to solve this?
The first alternative is to patch the package and remove the
problematic code. These changes are in configure.ac, Makefile.am, the
patch is fairly short. This change is not acceptable upstream (I
guess).

A second alternative is to change libuio to recognize --disable-nls.
However, I'm not sure how to do that.
The configure.ac file contains:

  AM_GNU_GETTEXT([external])
  AM_GNU_GETTEXT_VERSION([0.17])

This macro is provided by gettext itself, so without gettext this doesn't work.
I tried something like:

AC_ARG_ENABLE([nls], AC_HELP_STRING([--disable-nls], [Do not use
Native Language Support]),
              USE_NLS=$enableval, USE_NLS=yes)

AC_SUBST(USE_NLS)

AS_IF([test "x$enable_nls" == xyes],
  AM_GNU_GETTEXT([external])
  AM_GNU_GETTEXT_VERSION([0.17])
)

but I still get complaints about AM_GNU_GETTEXT not recognized.
I have tried finding good examples of implementing --disable-nls
without requiring gettext, but I can't find any.


Any input welcome,

Thomas

[Buildroot] Removing/solving gettext dependencies in libuio

[Arnout Vandecappelle]

On 30/07/13 14:28, Thomas De Schampheleire wrote:
> Hi,
>
> I'm adding the library libuio to buildroot
> (https://github.com/Linutronix/libuio/).
> This library expects gettext to be present, but I want to avoid adding
> this dependency to buildroot because it really isn't needed.
>
> What is the best way to solve this?

  Isn't docs/manual/adding-packages-gettext.txt sufficient?


  Regards,
  Arnout

> The first alternative is to patch the package and remove the
> problematic code. These changes are in configure.ac, Makefile.am, the
> patch is fairly short. This change is not acceptable upstream (I
> guess).
>
> A second alternative is to change libuio to recognize --disable-nls.
> However, I'm not sure how to do that.
> The configure.ac file contains:
>
>    AM_GNU_GETTEXT([external])
>    AM_GNU_GETTEXT_VERSION([0.17])
>
> This macro is provided by gettext itself, so without gettext this doesn't work.
> I tried something like:
>
> AC_ARG_ENABLE([nls], AC_HELP_STRING([--disable-nls], [Do not use
> Native Language Support]),
>                USE_NLS=$enableval, USE_NLS=yes)
>
> AC_SUBST(USE_NLS)
>
> AS_IF([test "x$enable_nls" == xyes],
>    AM_GNU_GETTEXT([external])
>    AM_GNU_GETTEXT_VERSION([0.17])
> )
>
> but I still get complaints about AM_GNU_GETTEXT not recognized.
> I have tried finding good examples of implementing --disable-nls
> without requiring gettext, but I can't find any.
>
>
> Any input welcome,
>
> Thomas
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] Removing/solving gettext dependencies in libuio

[Thomas De Schampheleire]

Hi Arnout,

On Mon, Aug 12, 2013 at 9:36 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
> On 30/07/13 14:28, Thomas De Schampheleire wrote:
>>
>> Hi,
>>
>> I'm adding the library libuio to buildroot
>> (https://github.com/Linutronix/libuio/).
>> This library expects gettext to be present, but I want to avoid adding
>> this dependency to buildroot because it really isn't needed.
>>
>> What is the best way to solve this?
>
>
>  Isn't docs/manual/adding-packages-gettext.txt sufficient?
>

I think not. That document (which I already read, but should've
mentioned) describes two scenarios:
1. the package needs gettext unconditionally
2. the package needs gettext when locale support is enabled

In the case of libuio, I'm strictly speaking in case 1 (unconditional
need for gettext). However, I'm contesting the unconditional need. In
reality, there is little use for that, since the only tool using it is
lsuio, a helper tool, for which no translations are currently
provided. The actual libuio library does not output strings through
gettext.

To remove the dependency on gettext completely, I can either remove
the referring lines in the package (see original mail [1]) or modify
the package's configure script to add a switch like --disable-nls or
similar.

Thanks,
Thomas

[1] http://comments.gmane.org/gmane.comp.lib.uclibc.buildroot/63538

[Buildroot] Removing/solving gettext dependencies in libuio

[Thomas Petazzoni]

Dear Thomas De Schampheleire,

On Tue, 30 Jul 2013 14:28:05 +0200, Thomas De Schampheleire wrote:

> A second alternative is to change libuio to recognize --disable-nls.
> However, I'm not sure how to do that.
> The configure.ac file contains:
> 
>   AM_GNU_GETTEXT([external])
>   AM_GNU_GETTEXT_VERSION([0.17])
> 
> This macro is provided by gettext itself, so without gettext this doesn't work.

This should only require host-gettext, which provides the .m4 file that
contains the m4 macro to autoreconf the package. Once you upstream the
patch, at the next release an updated 'configure' script will be part
of lsuio tarball, and we'll be able to remove the _AUTORECONF=YES and
therefore the dependency on host-gettext.

Am I missing something here?

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] Removing/solving gettext dependencies in libuio

[Thomas De Schampheleire]

Op 20-aug.-2013 00:26 schreef "Thomas Petazzoni" <
thomas.petazzoni@free-electrons.com> het volgende:
>
> Dear Thomas De Schampheleire,
>
> On Tue, 30 Jul 2013 14:28:05 +0200, Thomas De Schampheleire wrote:
>
> > A second alternative is to change libuio to recognize --disable-nls.
> > However, I'm not sure how to do that.
> > The configure.ac file contains:
> >
> >   AM_GNU_GETTEXT([external])
> >   AM_GNU_GETTEXT_VERSION([0.17])
> >
> > This macro is provided by gettext itself, so without gettext this
doesn't work.
>
> This should only require host-gettext, which provides the .m4 file that
> contains the m4 macro to autoreconf the package. Once you upstream the
> patch, at the next release an updated 'configure' script will be part
> of lsuio tarball, and we'll be able to remove the _AUTORECONF=YES and
> therefore the dependency on host-gettext.
>
> Am I missing something here?
>

Can you elaborate a bit?

With 'patch', do you mean the proposal of adding --disable-nls as I sent in
my first mail ? Come to think of it, does that even make sense? Isn't that
flag normally provided by gettext itself?

Regardless, how will upstreaming that patch remove the dependency on
gettext? Who will provide a definition for AM_GNU_GETTEXT?

(I think I now understand part of the confusion: libuio comes from git,
there are no packaged tarballs with a preboiled configure script. Hence,
autoreconf is always necessary.)

Thanks,
Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130820/1dfb9027/attachment.html>