[Buildroot] [PATCH 1/1] Phonon needs libglib2 or else it's functionality tests will fail.

[Buildroot] [PATCH 1/1] Phonon needs libglib2 or else it's functionality tests will fail.

[Sagaert Johan]

Signed-off-by: Sagaert Johan <sagaert.johan@skynet.be>
---
 package/qt/Config.in | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/package/qt/Config.in b/package/qt/Config.in
index 35e8208..2541875 100644
--- a/package/qt/Config.in
+++ b/package/qt/Config.in
@@ -264,7 +264,8 @@ source "package/qt/Config.keyboard.in"
 
 config BR2_PACKAGE_QT_PHONON
 	bool "Phonon Module"
-	depends on BR2_PACKAGE_GSTREAMER
+	depends on BR2_PACKAGE_GSTREAMER 
+	depends on BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_GST_PLUGINS_BASE
 	default y
 	help
@@ -272,8 +273,8 @@ config BR2_PACKAGE_QT_PHONON
 	  formats can be configured at the GStreamer package.
 	  If unsure, say n.
 
-comment "Phonon module needs gstreamer"
-	depends on !BR2_PACKAGE_GSTREAMER
+comment "Phonon module needs gstreamer and libglib2"
+	depends on !BR2_PACKAGE_GSTREAMER || !BR2_PACKAGE_LIBGLIB2
 
 config BR2_PACKAGE_QT_PHONON_BACKEND
 	bool "Phonon Module Backend"
-- 
1.8.3.2

[Buildroot] [PATCH 1/1] Phonon needs libglib2 or else it's functionality tests will fail.

[Thomas Petazzoni]

Dear Sagaert Johan,

On Sat, 24 Aug 2013 01:14:13 +0200, Sagaert Johan wrote:
> Signed-off-by: Sagaert Johan <sagaert.johan@skynet.be>
> ---
>  package/qt/Config.in | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/package/qt/Config.in b/package/qt/Config.in
> index 35e8208..2541875 100644
> --- a/package/qt/Config.in
> +++ b/package/qt/Config.in
> @@ -264,7 +264,8 @@ source "package/qt/Config.keyboard.in"
>  
>  config BR2_PACKAGE_QT_PHONON
>  	bool "Phonon Module"
> -	depends on BR2_PACKAGE_GSTREAMER
> +	depends on BR2_PACKAGE_GSTREAMER 
> +	depends on BR2_PACKAGE_LIBGLIB2

Hum, I'm not sure to understand. BR2_PACKAGE_QT_PHONON already depends
on BR2_PACKAGE_GSTREAMER. And BR2_PACKAGE_GSTREAMER selects
BR2_PACKAGE_LIBGLIB2. So, if BR2_PACKAGE_GSTREAMER is enabled, then
you're sure BR2_PACKAGE_LIBGLIB2 is enabled.

So unless I'm missing something, your patch does nothing, and I don't
quite see how it could fix any issue. Can you give the .config that
exhibits your build problem?

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 1/1] Phonon needs libglib2 or else it's functionality tests will fail.

[Sagaert Johan]

 
Hi Thomas

You are right,it's indeed imposssible to select phonon without having gstreamer and impliciet using libglib2.

In order to get rid my non working touchscreen when libglib2 was used by qt,
I added QT_CONFIGURE_OPTS += -no-glib to the qt makefile that yielded the Phonon functionality test failure.
So that was why I wrote the patch to avoid having phonon selected when libglib2 was absent.
And as you point out now due to the dependency chain is useless.

I don't know how the problem with the non working touch due to libglib usage in qt should be solved.
(for now I used QT_CONFIGURE_OPTS += -no-glib with phonon disabled.)

Is it a qt problem or is it a problem introduced by changed functionality in the libglib code ?...

There must be more users been affected by this, qt4.8 with tslib is a quit common I think.

Best regards, Johan


-----Oorspronkelijk bericht-----
Van: Thomas Petazzoni [mailto:thomas.petazzoni at free-electrons.com] 
Verzonden: zondag 25 augustus 2013 11:17
Aan: Sagaert Johan
CC: buildroot at busybox.net
Onderwerp: Re: [Buildroot] [PATCH 1/1] Phonon needs libglib2 or else it's functionality tests will fail.

Dear Sagaert Johan,

On Sat, 24 Aug 2013 01:14:13 +0200, Sagaert Johan wrote:
> Signed-off-by: Sagaert Johan <sagaert.johan@skynet.be>
> ---
>  package/qt/Config.in | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/package/qt/Config.in b/package/qt/Config.in index 
> 35e8208..2541875 100644
> --- a/package/qt/Config.in
> +++ b/package/qt/Config.in
> @@ -264,7 +264,8 @@ source "package/qt/Config.keyboard.in"
>  
>  config BR2_PACKAGE_QT_PHONON
>  	bool "Phonon Module"
> -	depends on BR2_PACKAGE_GSTREAMER
> +	depends on BR2_PACKAGE_GSTREAMER 
> +	depends on BR2_PACKAGE_LIBGLIB2

Hum, I'm not sure to understand. BR2_PACKAGE_QT_PHONON already depends on BR2_PACKAGE_GSTREAMER. And BR2_PACKAGE_GSTREAMER selects
BR2_PACKAGE_LIBGLIB2. So, if BR2_PACKAGE_GSTREAMER is enabled, then you're sure BR2_PACKAGE_LIBGLIB2 is enabled.

So unless I'm missing something, your patch does nothing, and I don't quite see how it could fix any issue. Can you give the .config
that exhibits your build problem?

Thanks!

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 1/1] Phonon needs libglib2 or else it's functionality tests will fail.

[Thomas Petazzoni]

Dear Sagaert Johan,

On Sun, 25 Aug 2013 17:01:55 +0200, Sagaert Johan wrote:

> You are right,it's indeed imposssible to select phonon without having gstreamer and impliciet using libglib2.
> 
> In order to get rid my non working touchscreen when libglib2 was used by qt,
> I added QT_CONFIGURE_OPTS += -no-glib to the qt makefile that yielded the Phonon functionality test failure.

Yes, obviously, this will not work nicely. If you want to do this
properly, we'd have to have a separate Kconfig option to enable glib
support in Qt, so that even if Glib is enabled in your configuration,
you can disable Glib support in Qt without hacking the qt.mk file.
Then, the Phonon option would also depend on that new Kconfig option.

> So that was why I wrote the patch to avoid having phonon selected when libglib2 was absent.
> And as you point out now due to the dependency chain is useless.
> 
> I don't know how the problem with the non working touch due to libglib usage in qt should be solved.
> (for now I used QT_CONFIGURE_OPTS += -no-glib with phonon disabled.)
> 
> Is it a qt problem or is it a problem introduced by changed functionality in the libglib code ?...
> 
> There must be more users been affected by this, qt4.8 with tslib is a quit common I think.

Well, at this point, I guess you'd have to debug this by adding some
debug messages in the input handling code of Qt to see where the
touchscreen events are being lost.

Or you can get in touch with the Qt community to see if they have an
idea. Or try with various Glib versions to see which one introduces the
breakage, maybe it will point to something interesting?

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com