From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] netplug: properly install init.d script.
Date: Tue, 3 Sep 2013 21:16:40 +0200 [thread overview]
Message-ID: <20130903211640.14902850@skate> (raw)
In-Reply-To: <1378228974-3369-1-git-send-email-psanford@nearbuysystems.com>
Dear Peter Sanford,
On Tue, 3 Sep 2013 10:22:54 -0700, Peter Sanford wrote:
> Looks like this was lost in 20d4792e.
>
> Signed-off-by: Peter Sanford <psanford@nearbuysystems.com>
> ---
> package/netplug/netplug.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/netplug/netplug.mk b/package/netplug/netplug.mk
> index fbc7a2d..36bd3f7 100644
> --- a/package/netplug/netplug.mk
> +++ b/package/netplug/netplug.mk
> @@ -16,6 +16,13 @@ define NETPLUG_INSTALL_TARGET_CMDS
> $(MAKE) DESTDIR=$(TARGET_DIR) -C $(@D) install
> endef
>
> +define NETPLUG_INSTALL_INITSCRIPT
> + $(INSTALL) -m 0755 -D package/netplug/S29netplug \
> + $(TARGET_DIR)/etc/init.d/S29netplug
> +endef
> +
> +NETPLUG_POST_INSTALL_TARGET_HOOKS += NETPLUG_INSTALL_INITSCRIPT
Looks good, but it should use NETPLUG_INSTALL_INIT_SYSV instead. See
the Buildroot manual for details,
http://buildroot.org/downloads/manual/manual.html.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-09-03 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 17:22 [Buildroot] [PATCH 1/1] netplug: properly install init.d script Peter Sanford
2013-09-03 19:16 ` Thomas Petazzoni [this message]
2013-09-03 22:16 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903211640.14902850@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox