* [Buildroot] [PATCH 1/1] netplug: properly install init.d script.
@ 2013-09-03 17:22 Peter Sanford
2013-09-03 19:16 ` Thomas Petazzoni
2013-09-03 22:16 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Peter Sanford @ 2013-09-03 17:22 UTC (permalink / raw)
To: buildroot
Looks like this was lost in 20d4792e.
Signed-off-by: Peter Sanford <psanford@nearbuysystems.com>
---
package/netplug/netplug.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/netplug/netplug.mk b/package/netplug/netplug.mk
index fbc7a2d..36bd3f7 100644
--- a/package/netplug/netplug.mk
+++ b/package/netplug/netplug.mk
@@ -16,6 +16,13 @@ define NETPLUG_INSTALL_TARGET_CMDS
$(MAKE) DESTDIR=$(TARGET_DIR) -C $(@D) install
endef
+define NETPLUG_INSTALL_INITSCRIPT
+ $(INSTALL) -m 0755 -D package/netplug/S29netplug \
+ $(TARGET_DIR)/etc/init.d/S29netplug
+endef
+
+NETPLUG_POST_INSTALL_TARGET_HOOKS += NETPLUG_INSTALL_INITSCRIPT
+
define NETPLUG_UNINSTALL_TARGET_CMDS
rm -f $(TARGET_DIR)/sbin/netplugd
rm -rf $(TARGET_DIR)/etc/netplug*
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] netplug: properly install init.d script.
2013-09-03 17:22 [Buildroot] [PATCH 1/1] netplug: properly install init.d script Peter Sanford
@ 2013-09-03 19:16 ` Thomas Petazzoni
2013-09-03 22:16 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2013-09-03 19:16 UTC (permalink / raw)
To: buildroot
Dear Peter Sanford,
On Tue, 3 Sep 2013 10:22:54 -0700, Peter Sanford wrote:
> Looks like this was lost in 20d4792e.
>
> Signed-off-by: Peter Sanford <psanford@nearbuysystems.com>
> ---
> package/netplug/netplug.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/netplug/netplug.mk b/package/netplug/netplug.mk
> index fbc7a2d..36bd3f7 100644
> --- a/package/netplug/netplug.mk
> +++ b/package/netplug/netplug.mk
> @@ -16,6 +16,13 @@ define NETPLUG_INSTALL_TARGET_CMDS
> $(MAKE) DESTDIR=$(TARGET_DIR) -C $(@D) install
> endef
>
> +define NETPLUG_INSTALL_INITSCRIPT
> + $(INSTALL) -m 0755 -D package/netplug/S29netplug \
> + $(TARGET_DIR)/etc/init.d/S29netplug
> +endef
> +
> +NETPLUG_POST_INSTALL_TARGET_HOOKS += NETPLUG_INSTALL_INITSCRIPT
Looks good, but it should use NETPLUG_INSTALL_INIT_SYSV instead. See
the Buildroot manual for details,
http://buildroot.org/downloads/manual/manual.html.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] netplug: properly install init.d script.
2013-09-03 17:22 [Buildroot] [PATCH 1/1] netplug: properly install init.d script Peter Sanford
2013-09-03 19:16 ` Thomas Petazzoni
@ 2013-09-03 22:16 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2013-09-03 22:16 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Sanford <psanford@nearbuysystems.com> writes:
Peter> Looks like this was lost in 20d4792e.
Peter> Signed-off-by: Peter Sanford <psanford@nearbuysystems.com>
Peter> ---
Peter> package/netplug/netplug.mk | 7 +++++++
Peter> 1 file changed, 7 insertions(+)
Peter> diff --git a/package/netplug/netplug.mk b/package/netplug/netplug.mk
Peter> index fbc7a2d..36bd3f7 100644
Peter> --- a/package/netplug/netplug.mk
Peter> +++ b/package/netplug/netplug.mk
Peter> @@ -16,6 +16,13 @@ define NETPLUG_INSTALL_TARGET_CMDS
Peter> $(MAKE) DESTDIR=$(TARGET_DIR) -C $(@D) install
Peter> endef
Peter> +define NETPLUG_INSTALL_INITSCRIPT
Peter> + $(INSTALL) -m 0755 -D package/netplug/S29netplug \
Peter> + $(TARGET_DIR)/etc/init.d/S29netplug
Peter> +endef
Committed with this changed to use NETPLUG_INSTALL_INIT_SYSV, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-03 22:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-03 17:22 [Buildroot] [PATCH 1/1] netplug: properly install init.d script Peter Sanford
2013-09-03 19:16 ` Thomas Petazzoni
2013-09-03 22:16 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox