* [Buildroot] [git commit] kmod: disable manpages for host-kmod
@ 2013-09-04 10:36 Peter Korsgaard
2013-09-04 15:50 ` Jérôme Pouiller
0 siblings, 1 reply; 5+ messages in thread
From: Peter Korsgaard @ 2013-09-04 10:36 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=24058f10a70812de695f6bf8be3f66f0abcc179c
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
The manpages are not installed to HOST_DIR anyway, and it errors out if
xsltproc isn't available on the host.
---
package/kmod/kmod.mk | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/package/kmod/kmod.mk b/package/kmod/kmod.mk
index 169fca3..a1ad7d6 100644
--- a/package/kmod/kmod.mk
+++ b/package/kmod/kmod.mk
@@ -23,6 +23,9 @@ KMOD_LICENSE_FILES = libkmod/COPYING
# https://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/commit/?id=b7016153ec8
KMOD_CONF_OPT = --disable-static --enable-shared
+# manpages not installed to host and needs xsltproc
+HOST_KMOD_CONF_OPT = --disable-manpages
+
ifneq ($(BR2_HAVE_DOCUMENTATION),y)
KMOD_CONF_OPT += --disable-manpages
endif
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] kmod: disable manpages for host-kmod
2013-09-04 10:36 [Buildroot] [git commit] kmod: disable manpages for host-kmod Peter Korsgaard
@ 2013-09-04 15:50 ` Jérôme Pouiller
2013-09-04 16:19 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Jérôme Pouiller @ 2013-09-04 15:50 UTC (permalink / raw)
To: buildroot
Hi Peter,
On 2013-09-04 12:36, Peter Korsgaard wrote:
[...]
> diff --git a/package/kmod/kmod.mk b/package/kmod/kmod.mk
> index 169fca3..a1ad7d6 100644
> --- a/package/kmod/kmod.mk
> +++ b/package/kmod/kmod.mk
> @@ -23,6 +23,9 @@ KMOD_LICENSE_FILES = libkmod/COPYING
> #
> https://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/commit/?id=b7016153ec8
> KMOD_CONF_OPT = --disable-static --enable-shared
>
> +# manpages not installed to host and needs xsltproc
> +HOST_KMOD_CONF_OPT = --disable-manpages
> +
> ifneq ($(BR2_HAVE_DOCUMENTATION),y)
> KMOD_CONF_OPT += --disable-manpages
> endif
What happens when BR2_HAVE_DOCUMENTATION is enabled? I think same
problem happens.
We should add a dependency to host-libxslt and I think we can pass
variable XSLTPROC= to ./configure to use a specific location of
xsltproc.
--
J?r?me Pouiller, Sysmic
Embedded Linux specialist
http://www.sysmic.fr
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] kmod: disable manpages for host-kmod
2013-09-04 15:50 ` Jérôme Pouiller
@ 2013-09-04 16:19 ` Thomas Petazzoni
2013-09-04 20:13 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2013-09-04 16:19 UTC (permalink / raw)
To: buildroot
Dear J?r?me Pouiller,
On Wed, 04 Sep 2013 17:50:47 +0200, J?r?me Pouiller wrote:
> > ifneq ($(BR2_HAVE_DOCUMENTATION),y)
> > KMOD_CONF_OPT += --disable-manpages
> > endif
> What happens when BR2_HAVE_DOCUMENTATION is enabled? I think same
> problem happens.
>
> We should add a dependency to host-libxslt and I think we can pass
> variable XSLTPROC= to ./configure to use a specific location of
> xsltproc.
Yes, we normally should. But nobody seems to be testing or using
BR2_HAVE_DOCUMENTATION. I would personally be in favor of just getting
rid of BR2_HAVE_DOCUMENTATION. Who needs the documentation to be
installed on the target?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] kmod: disable manpages for host-kmod
2013-09-04 16:19 ` Thomas Petazzoni
@ 2013-09-04 20:13 ` Peter Korsgaard
2013-09-04 20:27 ` Arnout Vandecappelle
0 siblings, 1 reply; 5+ messages in thread
From: Peter Korsgaard @ 2013-09-04 20:13 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Dear J?r?me Pouiller,
Thomas> On Wed, 04 Sep 2013 17:50:47 +0200, J?r?me Pouiller wrote:
>> > ifneq ($(BR2_HAVE_DOCUMENTATION),y)
>> > KMOD_CONF_OPT += --disable-manpages
>> > endif
>> What happens when BR2_HAVE_DOCUMENTATION is enabled? I think same
>> problem happens.
>>
>> We should add a dependency to host-libxslt and I think we can pass
>> variable XSLTPROC= to ./configure to use a specific location of
>> xsltproc.
Thomas> Yes, we normally should. But nobody seems to be testing or using
Thomas> BR2_HAVE_DOCUMENTATION. I would personally be in favor of just getting
Thomas> rid of BR2_HAVE_DOCUMENTATION. Who needs the documentation to be
Thomas> installed on the target?
I'm also starting to think so. With Buildroot focused on cross
compilation (and the development on target stuff gone), I don't see much
use for documentation on the target either.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] kmod: disable manpages for host-kmod
2013-09-04 20:13 ` Peter Korsgaard
@ 2013-09-04 20:27 ` Arnout Vandecappelle
0 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2013-09-04 20:27 UTC (permalink / raw)
To: buildroot
On 09/04/13 22:13, Peter Korsgaard wrote:
>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
>
> Thomas> Dear J?r?me Pouiller,
> Thomas> On Wed, 04 Sep 2013 17:50:47 +0200, J?r?me Pouiller wrote:
>
> >> > ifneq ($(BR2_HAVE_DOCUMENTATION),y)
> >> > KMOD_CONF_OPT += --disable-manpages
> >> > endif
> >> What happens when BR2_HAVE_DOCUMENTATION is enabled? I think same
> >> problem happens.
> >>
> >> We should add a dependency to host-libxslt and I think we can pass
> >> variable XSLTPROC= to ./configure to use a specific location of
> >> xsltproc.
>
> Thomas> Yes, we normally should. But nobody seems to be testing or using
> Thomas> BR2_HAVE_DOCUMENTATION. I would personally be in favor of just getting
> Thomas> rid of BR2_HAVE_DOCUMENTATION. Who needs the documentation to be
> Thomas> installed on the target?
>
> I'm also starting to think so. With Buildroot focused on cross
> compilation (and the development on target stuff gone), I don't see much
> use for documentation on the target either.
Well, if you have a less space-constrained system it's kind of
convenient to be able to pull up a man page for some tool that you're
less familiar with and that is not installed on your host (not that I can
think of an example :-). However, in its current incarnation, including
documentation adds a huge amount of bloat. Taking one random output I
find 105MB in the target dir and 40MB of various bits of documentation in
the staging dir.
Bottom line: yes, BR2_HAVE_DOCUMENTATION can be killed.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-04 20:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-04 10:36 [Buildroot] [git commit] kmod: disable manpages for host-kmod Peter Korsgaard
2013-09-04 15:50 ` Jérôme Pouiller
2013-09-04 16:19 ` Thomas Petazzoni
2013-09-04 20:13 ` Peter Korsgaard
2013-09-04 20:27 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox