[Buildroot] [PATCH 1/1] linux: update depmod path for install to target

Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed

* [Buildroot] [PATCH 1/1] linux: update depmod path for install to target
@ 2013-09-10 21:58 Ryan Coe
  2013-09-11  7:27 ` Thomas Petazzoni
  0 siblings, 1 reply; 6+ messages in thread
From: Ryan Coe @ 2013-09-10 21:58 UTC (permalink / raw)
  To: buildroot


Signed-off-by: Ryan Coe <bluemrp9@gmail.com>
---
 linux/linux.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux/linux.mk b/linux/linux.mk
index 649d06b..1650143 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -274,7 +274,7 @@ define LINUX_INSTALL_TARGET_CMDS
 	# directories, not relevant on the target
 	@if grep -q "CONFIG_MODULES=y" $(@D)/.config; then 	\
 		$(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) 		\
-			DEPMOD="$(HOST_DIR)/usr/sbin/depmod" modules_install ;		\
+			DEPMOD="$(HOST_DIR)/sbin/depmod" modules_install ;		\
 		rm -f $(TARGET_DIR)/lib/modules/$(LINUX_VERSION_PROBED)/build ;		\
 		rm -f $(TARGET_DIR)/lib/modules/$(LINUX_VERSION_PROBED)/source ;	\
 	fi
-- 
1.8.1.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] linux: update depmod path for install to target
  2013-09-10 21:58 [Buildroot] [PATCH 1/1] linux: update depmod path for install to target Ryan Coe
@ 2013-09-11  7:27 ` Thomas Petazzoni
  2013-09-11 11:23   ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2013-09-11  7:27 UTC (permalink / raw)
  To: buildroot

Dear Ryan Coe,

On Tue, 10 Sep 2013 14:58:35 -0700, Ryan Coe wrote:
>  		$(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) 		\
> -			DEPMOD="$(HOST_DIR)/usr/sbin/depmod" modules_install ;		\
> +			DEPMOD="$(HOST_DIR)/sbin/depmod" modules_install ;		\

Not sure why we have to pass DEPMOD here since it's already part of
LINUX_MAKE_FLAGS. Am I missing something?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] linux: update depmod path for install to target
  2013-09-11  7:27 ` Thomas Petazzoni
@ 2013-09-11 11:23   ` Peter Korsgaard
  2013-09-11 13:51     ` Ryan Coe
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2013-09-11 11:23 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Dear Ryan Coe,
 Thomas> On Tue, 10 Sep 2013 14:58:35 -0700, Ryan Coe wrote:
 >> $(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) 		\
 >> -			DEPMOD="$(HOST_DIR)/usr/sbin/depmod" modules_install ;		\
 >> +			DEPMOD="$(HOST_DIR)/sbin/depmod" modules_install ;		\

 Thomas> Not sure why we have to pass DEPMOD here since it's already part of
 Thomas> LINUX_MAKE_FLAGS. Am I missing something?

No, I think you're right. I've removed it in git.

Thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] linux: update depmod path for install to target
  2013-09-11 11:23   ` Peter Korsgaard
@ 2013-09-11 13:51     ` Ryan Coe
  2013-09-11 14:20       ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Ryan Coe @ 2013-09-11 13:51 UTC (permalink / raw)
  To: buildroot

On 09/11/2013 04:23 AM, Peter Korsgaard wrote:
>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> writes:
>
>   Thomas> Dear Ryan Coe,
>   Thomas> On Tue, 10 Sep 2013 14:58:35 -0700, Ryan Coe wrote:
>   >> $(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) 		\
>   >> -			DEPMOD="$(HOST_DIR)/usr/sbin/depmod" modules_install ;		\
>   >> +			DEPMOD="$(HOST_DIR)/sbin/depmod" modules_install ;		\
>
>   Thomas> Not sure why we have to pass DEPMOD here since it's already part of
>   Thomas> LINUX_MAKE_FLAGS. Am I missing something?
>
> No, I think you're right. I've removed it in git.
>
> Thanks.
>

Without the depmod in the target install, I do not get the necessary 
files installed to the target.  I am unable to load modules until I 
manually run depmod -a.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] linux: update depmod path for install to target
  2013-09-11 13:51     ` Ryan Coe
@ 2013-09-11 14:20       ` Peter Korsgaard
       [not found]         ` <CANbLAv=Z6t7RuxrRm+uodNS55WXSKt1Raui8XLcQyoMjqk6mkw@mail.gmail.com>
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2013-09-11 14:20 UTC (permalink / raw)
  To: buildroot

>>>>> "Ryan" == Ryan Coe <bluemrp9@gmail.com> writes:

Hi,

 Ryan> Without the depmod in the target install, I do not get the necessary
 Ryan> files installed to the target.  I am unable to load modules until I
 Ryan> manually run depmod -a.

Really? LINUX_MAKE_FLAGS expands to .. DEPMOD=$(HOST_DIR)/sbin/depmod,
so we ended up passing 2x DEPMOD= to modules_install.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

[parent not found: <CANbLAv=Z6t7RuxrRm+uodNS55WXSKt1Raui8XLcQyoMjqk6mkw@mail.gmail.com>]

* [Buildroot] [PATCH 1/1] linux: update depmod path for install to target
       [not found]         ` <CANbLAv=Z6t7RuxrRm+uodNS55WXSKt1Raui8XLcQyoMjqk6mkw@mail.gmail.com>
@ 2013-09-11 15:36           ` Ryan Coe
  0 siblings, 0 replies; 6+ messages in thread
From: Ryan Coe @ 2013-09-11 15:36 UTC (permalink / raw)
  To: buildroot

On 09/11/2013 07:23 AM, Ryan Coe wrote:
>
> I will try it without the second instance and report back.
>
> On Sep 11, 2013 7:20 AM, "Peter Korsgaard" <jacmet@uclibc.org 
> <mailto:jacmet@uclibc.org>> wrote:
>
>     >>>>> "Ryan" == Ryan Coe <bluemrp9@gmail.com
>     <mailto:bluemrp9@gmail.com>> writes:
>
>     Hi,
>
>      Ryan> Without the depmod in the target install, I do not get the
>     necessary
>      Ryan> files installed to the target.  I am unable to load modules
>     until I
>      Ryan> manually run depmod -a.
>
>     Really? LINUX_MAKE_FLAGS expands to .. DEPMOD=$(HOST_DIR)/sbin/depmod,
>     so we ended up passing 2x DEPMOD= to modules_install.
>
>     --
>     Bye, Peter Korsgaard
>
I can confirm that this does work.  The second time that depmod was 
passed was causing trouble.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130911/8c1d3b3b/attachment.html>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-09-11 15:36 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-10 21:58 [Buildroot] [PATCH 1/1] linux: update depmod path for install to target Ryan Coe
2013-09-11  7:27 ` Thomas Petazzoni
2013-09-11 11:23   ` Peter Korsgaard
2013-09-11 13:51     ` Ryan Coe
2013-09-11 14:20       ` Peter Korsgaard
     [not found]         ` <CANbLAv=Z6t7RuxrRm+uodNS55WXSKt1Raui8XLcQyoMjqk6mkw@mail.gmail.com>
2013-09-11 15:36           ` Ryan Coe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox