Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] igmpproxy: new package
@ 2013-09-11 18:28 Matt Weber
  2013-09-12 17:11 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Matt Weber @ 2013-09-11 18:28 UTC (permalink / raw)
  To: buildroot


Signed-off-by: Matt Weber <mlweber1@rockwellcollins.com>
---
 package/Config.in              |    1 +
 package/igmpproxy/Config.in    |    7 +++++++
 package/igmpproxy/igmpproxy.mk |   13 +++++++++++++
 3 files changed, 21 insertions(+), 0 deletions(-)
 create mode 100755 package/igmpproxy/Config.in
 create mode 100755 package/igmpproxy/igmpproxy.mk

diff --git a/package/Config.in b/package/Config.in
index 2351839..6413242 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -781,6 +781,7 @@ source "package/ifplugd/Config.in"
 endif
 source "package/iftop/Config.in"
 source "package/igh-ethercat/Config.in"
+source "package/igmpproxy/Config.in"
 source "package/inadyn/Config.in"
 source "package/iperf/Config.in"
 source "package/iproute2/Config.in"
diff --git a/package/igmpproxy/Config.in b/package/igmpproxy/Config.in
new file mode 100755
index 0000000..53a25b1
--- /dev/null
+++ b/package/igmpproxy/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_IGMPPROXY
+	bool "igmpproxy"
+	help
+	  A simple dynamic Multicast Routing Daemon 
+	  using only IGMP signalling. It's intended 
+	  for simple forwarding of Multicast traffic 
+	  between networks.
diff --git a/package/igmpproxy/igmpproxy.mk b/package/igmpproxy/igmpproxy.mk
new file mode 100755
index 0000000..468f356
--- /dev/null
+++ b/package/igmpproxy/igmpproxy.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# igmpproxy 
+#
+################################################################################
+
+IGMPPROXY_VERSION = 0.1
+IGMPPROXY_SITE = http://downloads.sourceforge.net/project/igmpproxy/igmpproxy/$(IGMPPROXY_VERSION)
+IGMPPROXY_SOURCE = igmpproxy-$(IGMPPROXY_VERSION).tar.gz
+IGMPPROXY_LICENSE = GPLv2+
+IGMPPROXY_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH 1/1] igmpproxy: new package
  2013-09-11 18:28 [Buildroot] [PATCH 1/1] igmpproxy: new package Matt Weber
@ 2013-09-12 17:11 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2013-09-12 17:11 UTC (permalink / raw)
  To: buildroot

Dear Matt Weber,

On Wed, 11 Sep 2013 13:28:45 -0500, Matt Weber wrote:

> diff --git a/package/igmpproxy/Config.in b/package/igmpproxy/Config.in
> new file mode 100755
> index 0000000..53a25b1
> --- /dev/null
> +++ b/package/igmpproxy/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_IGMPPROXY
> +	bool "igmpproxy"

For some odd reason, the configure check that verifies if the compiler
supports C99 builds a program that needs wchar support. So you should
add a:

	depends on BR2_USE_WCHAR

and also a:

comment "igmpproxy needs a toolchain with wchar support"
	depends on !BR2_USE_WCHAR

> +	help
> +	  A simple dynamic Multicast Routing Daemon 
> +	  using only IGMP signalling. It's intended 
> +	  for simple forwarding of Multicast traffic 
> +	  between networks.

Please add an empty line and the upstream URL of the project. I know
the contents at http://sourceforge.net/projects/igmpproxy/ are not very
fancy, but it's better than nothing.

> diff --git a/package/igmpproxy/igmpproxy.mk b/package/igmpproxy/igmpproxy.mk
> new file mode 100755
> index 0000000..468f356
> --- /dev/null
> +++ b/package/igmpproxy/igmpproxy.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# igmpproxy 
> +#
> +################################################################################
> +
> +IGMPPROXY_VERSION = 0.1
> +IGMPPROXY_SITE = http://downloads.sourceforge.net/project/igmpproxy/igmpproxy/$(IGMPPROXY_VERSION)
> +IGMPPROXY_SOURCE = igmpproxy-$(IGMPPROXY_VERSION).tar.gz

This last line is not needed since it's the default value.

> +IGMPPROXY_LICENSE = GPLv2+
> +IGMPPROXY_LICENSE_FILES = COPYING
> +
> +$(eval $(autotools-package))

Other than that, looks good. Can you send an updated version that takes
into account those comments?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-12 17:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11 18:28 [Buildroot] [PATCH 1/1] igmpproxy: new package Matt Weber
2013-09-12 17:11 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox