* [Buildroot] [PATCH] qt: install translations
@ 2013-09-12 19:12 Vivien Didelot
2013-09-12 19:44 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Vivien Didelot @ 2013-09-12 19:12 UTC (permalink / raw)
To: buildroot
The Qt translation files are currently created and moved under
$(STAGING_DIR)/usr/translations but not installed on the target.
This patch defines the translations directory to
/usr/share/qt/translations and defines a QT_INSTALL_TARGET_TRANSLATIONS
macro to deploy them from the staging directory to the target directory.
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
package/qt/qt.mk | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/package/qt/qt.mk b/package/qt/qt.mk
index daade3c..48d39fc 100644
--- a/package/qt/qt.mk
+++ b/package/qt/qt.mk
@@ -516,6 +516,7 @@ define QT_CONFIGURE_CMDS
-prefix /usr \
-plugindir /usr/lib/qt/plugins \
-importdir /usr/lib/qt/imports \
+ -translationdir /usr/share/qt/translations \
-hostprefix $(STAGING_DIR) \
-fast \
-no-rpath \
@@ -666,6 +667,13 @@ define QT_INSTALL_TARGET_POWERVR
endef
endif
+define QT_INSTALL_TARGET_TRANSLATIONS
+ if [ -d $(STAGING_DIR)/usr/share/qt/translations/ ] ; then \
+ mkdir -p $(TARGET_DIR)/usr/share/qt/translations ; \
+ cp -dpfr $(STAGING_DIR)/usr/share/qt/translations/* $(TARGET_DIR)/usr/share/qt/translations ; \
+ fi
+endef
+
define QT_INSTALL_TARGET_CMDS
$(QT_INSTALL_TARGET_LIBS)
$(QT_INSTALL_TARGET_PLUGINS)
@@ -673,6 +681,7 @@ define QT_INSTALL_TARGET_CMDS
$(QT_INSTALL_TARGET_FONTS)
$(QT_INSTALL_TARGET_FONTS_TTF)
$(QT_INSTALL_TARGET_POWERVR)
+ $(QT_INSTALL_TARGET_TRANSLATIONS)
endef
define QT_CLEAN_CMDS
--
1.8.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] qt: install translations
2013-09-12 19:12 [Buildroot] [PATCH] qt: install translations Vivien Didelot
@ 2013-09-12 19:44 ` Thomas Petazzoni
2013-09-17 20:29 ` Vivien Didelot
2013-09-18 4:18 ` Thomas Petazzoni
2013-09-19 19:43 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2013-09-12 19:44 UTC (permalink / raw)
To: buildroot
Dear Vivien Didelot,
On Thu, 12 Sep 2013 15:12:36 -0400, Vivien Didelot wrote:
> The Qt translation files are currently created and moved under
> $(STAGING_DIR)/usr/translations but not installed on the target.
>
> This patch defines the translations directory to
> /usr/share/qt/translations and defines a QT_INSTALL_TARGET_TRANSLATIONS
> macro to deploy them from the staging directory to the target directory.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
This looks good, but I'm wondering: the translations that are installed
in /usr/share/qt/translations are the translations of the Qt library
itself, or the translations of the applications using Qt as their
library?
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] qt: install translations
2013-09-12 19:44 ` Thomas Petazzoni
@ 2013-09-17 20:29 ` Vivien Didelot
0 siblings, 0 replies; 5+ messages in thread
From: Vivien Didelot @ 2013-09-17 20:29 UTC (permalink / raw)
To: buildroot
Hi Thomas,
> On Thu, 12 Sep 2013 15:12:36 -0400, Vivien Didelot wrote:
> > The Qt translation files are currently created and moved under
> > $(STAGING_DIR)/usr/translations but not installed on the target.
> >
> > This patch defines the translations directory to
> > /usr/share/qt/translations and defines a
> > QT_INSTALL_TARGET_TRANSLATIONS
> > macro to deploy them from the staging directory to the target
> > directory.
> >
> > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>
> This looks good, but I'm wondering: the translations that are
> installed
> in /usr/share/qt/translations are the translations of the Qt library
> itself, or the translations of the applications using Qt as their
> library?
These are the translations of Qt itself.
Thanks,
Vivien
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] qt: install translations
2013-09-12 19:12 [Buildroot] [PATCH] qt: install translations Vivien Didelot
2013-09-12 19:44 ` Thomas Petazzoni
@ 2013-09-18 4:18 ` Thomas Petazzoni
2013-09-19 19:43 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2013-09-18 4:18 UTC (permalink / raw)
To: buildroot
Dear Vivien Didelot,
On Thu, 12 Sep 2013 15:12:36 -0400, Vivien Didelot wrote:
> The Qt translation files are currently created and moved under
> $(STAGING_DIR)/usr/translations but not installed on the target.
>
> This patch defines the translations directory to
> /usr/share/qt/translations and defines a QT_INSTALL_TARGET_TRANSLATIONS
> macro to deploy them from the staging directory to the target directory.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] qt: install translations
2013-09-12 19:12 [Buildroot] [PATCH] qt: install translations Vivien Didelot
2013-09-12 19:44 ` Thomas Petazzoni
2013-09-18 4:18 ` Thomas Petazzoni
@ 2013-09-19 19:43 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2013-09-19 19:43 UTC (permalink / raw)
To: buildroot
>>>>> "Vivien" == Vivien Didelot <vivien.didelot@savoirfairelinux.com> writes:
Vivien> The Qt translation files are currently created and moved under
Vivien> $(STAGING_DIR)/usr/translations but not installed on the target.
Vivien> This patch defines the translations directory to
Vivien> /usr/share/qt/translations and defines a
Vivien> QT_INSTALL_TARGET_TRANSLATIONS macro to deploy them from the
Vivien> staging directory to the target directory.
Vivien> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-19 19:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-12 19:12 [Buildroot] [PATCH] qt: install translations Vivien Didelot
2013-09-12 19:44 ` Thomas Petazzoni
2013-09-17 20:29 ` Vivien Didelot
2013-09-18 4:18 ` Thomas Petazzoni
2013-09-19 19:43 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox