Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libcap-ng: doesn't build on AVR32, requires TLS support
Date: Mon, 7 Oct 2013 08:53:37 +0200	[thread overview]
Message-ID: <20131007085337.729422ca@skate> (raw)
In-Reply-To: <87fvsecbz5.fsf@dell.be.48ers.dk>

Dear Peter Korsgaard,

On Sun, 06 Oct 2013 23:42:54 +0200, Peter Korsgaard wrote:

>  Thomas> It wouldn't work with external toolchains, which is the reason why I
>  Thomas> excluded the AVR32 architecture rather than using a BR2_GCC_ENABLE_TLS
>  Thomas> condition.
> 
> Ok, but from your comment I believe it should also depend on
> BR2_GCC_ENABLE_TLS (E.G. it would break on other archs if you disable
> TLS support)?

If we make the package depend on BR2_GCC_ENABLE_TLS, then it would no
longer be visible for any external toolchain.

> If we start having other packages needing TLS, then we should perhaps
> provide the option for external toolchains as well, similar to how we do
> for the other toolchain settings.

I'm always a bit reluctant to add more and more toolchain options,
since they are a pain to maintain, and do not necessarily reflect real
use cases. Is it really an useful use-case to support non-TLS
toolchains on architectures where TLS support is available?

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2013-10-07  6:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-06 16:34 [Buildroot] [PATCH] libcap-ng: doesn't build on AVR32, requires TLS support Thomas Petazzoni
2013-10-06 18:44 ` Peter Korsgaard
2013-10-06 21:23   ` Thomas Petazzoni
2013-10-06 21:42     ` Peter Korsgaard
2013-10-07  6:53       ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131007085337.729422ca@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox