From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libcap-ng: doesn't build on AVR32, requires TLS support
Date: Sun, 06 Oct 2013 23:42:54 +0200 [thread overview]
Message-ID: <87fvsecbz5.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20131006232344.493a4ebc@skate> (Thomas Petazzoni's message of "Sun, 6 Oct 2013 23:23:44 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Dear Peter Korsgaard,
Thomas> On Sun, 06 Oct 2013 20:44:30 +0200, Peter Korsgaard wrote:
Thomas> diff --git a/package/libcap-ng/Config.in b/package/libcap-ng/Config.in
Thomas> index d1663cd..b799dc9 100644
Thomas> --- a/package/libcap-ng/Config.in
Thomas> +++ b/package/libcap-ng/Config.in
Thomas> @@ -1,5 +1,7 @@
Thomas> config BR2_PACKAGE_LIBCAP_NG
Thomas> bool "libcap-ng"
Thomas> + # tls support, needed by libcap-ng, not available on avr32
Thomas> + depends on !BR2_avr32
>>
>> Shouldn't it then depend on BR2_GCC_ENABLE_TLS (and the avr32 toolchain
>> not select it)?
Thomas> It wouldn't work with external toolchains, which is the reason why I
Thomas> excluded the AVR32 architecture rather than using a BR2_GCC_ENABLE_TLS
Thomas> condition.
Ok, but from your comment I believe it should also depend on
BR2_GCC_ENABLE_TLS (E.G. it would break on other archs if you disable
TLS support)?
If we start having other packages needing TLS, then we should perhaps
provide the option for external toolchains as well, similar to how we do
for the other toolchain settings.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-10-06 21:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 16:34 [Buildroot] [PATCH] libcap-ng: doesn't build on AVR32, requires TLS support Thomas Petazzoni
2013-10-06 18:44 ` Peter Korsgaard
2013-10-06 21:23 ` Thomas Petazzoni
2013-10-06 21:42 ` Peter Korsgaard [this message]
2013-10-07 6:53 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvsecbz5.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox