Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] Add new package espeak, a speech synthesizer software
Date: Tue, 8 Oct 2013 14:16:02 +0200	[thread overview]
Message-ID: <20131008141602.6a2dd858@skate> (raw)
In-Reply-To: <1381228089-3151-1-git-send-email-arnaud.aujon@gmail.com>

Dear arnaud.aujon at gmail.com,

On Tue,  8 Oct 2013 12:28:09 +0200, arnaud.aujon at gmail.com wrote:
> From: Arnaud Aujon <arnaud.aujon@gmail.com>
> 
> Signed-off-by: Arnaud Aujon <arnaud.aujon@gmail.com>

Thanks, it looks better since the patch is no longer wrapped, but other
than that, you haven't taken into account any of the comments I made in
the review of the first version.

Have you seen the comments I made at
http://lists.busybox.net/pipermail/buildroot/2013-October/079804.html ?
Look at the entire e-mail, my answer was spread in the different parts
of the e-mail, depending on what the comment was referring to.

Also, your previous commit title was better, it should be just:

	espeak: new package

Thanks

Thomas
-- 
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2013-10-08 12:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08 10:28 [Buildroot] [PATCH v2] Add new package espeak, a speech synthesizer software arnaud.aujon at gmail.com
2013-10-08 12:16 ` Thomas Petazzoni [this message]
2013-10-08 20:06   ` arnaud aujon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131008141602.6a2dd858@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox