Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] rpi-userland: needs threads
@ 2013-10-08  8:36 Phil Eichinger
  2013-10-08  8:47 ` Thomas Petazzoni
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Phil Eichinger @ 2013-10-08  8:36 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Phil Eichinger <phil@zankapfel.net>
---
 package/rpi-userland/Config.in |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/rpi-userland/Config.in b/package/rpi-userland/Config.in
index da5726f..d4e28a1 100644
--- a/package/rpi-userland/Config.in
+++ b/package/rpi-userland/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_RPI_USERLAND
 	depends on BR2_arm
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_LARGEFILE
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_HAS_OPENGL_EGL
 	select BR2_PACKAGE_HAS_OPENGL_ES
 	select BR2_PACKAGE_HAS_OPENVG
@@ -16,5 +17,5 @@ config BR2_PACKAGE_RPI_USERLAND
 
 	  https://github.com/raspberrypi/userland/
 
-comment "rpi-userland requires a toolchain with C++ and LARGEFILE support"
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE
+comment "rpi-userland requires a toolchain with C++, LARGEFILE and threads support"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] rpi-userland: needs threads
  2013-10-08  8:36 [Buildroot] [PATCH 1/1] rpi-userland: needs threads Phil Eichinger
@ 2013-10-08  8:47 ` Thomas Petazzoni
  2013-10-08  8:52   ` Phil Eichinger
  2013-10-08 16:28 ` Yann E. MORIN
  2013-10-08 20:17 ` Peter Korsgaard
  2 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2013-10-08  8:47 UTC (permalink / raw)
  To: buildroot

Dear Phil Eichinger,

On Tue,  8 Oct 2013 10:36:48 +0200, Phil Eichinger wrote:
> Signed-off-by: Phil Eichinger <phil@zankapfel.net>
> ---
>  package/rpi-userland/Config.in |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Thanks. Not sure how you found this, but note that it is also fixes an
autobuilder failure:

  http://autobuild.buildroot.net/results/c3b4c09edee2499e811808018be1858bdee70436/

Thomas
-- 
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] rpi-userland: needs threads
  2013-10-08  8:47 ` Thomas Petazzoni
@ 2013-10-08  8:52   ` Phil Eichinger
  0 siblings, 0 replies; 5+ messages in thread
From: Phil Eichinger @ 2013-10-08  8:52 UTC (permalink / raw)
  To: buildroot

On 8 October 2013 10:47, Thomas Petazzoni <
thomas.petazzoni@free-electrons.com> wrote:

> Dear Phil Eichinger,
>
> On Tue,  8 Oct 2013 10:36:48 +0200, Phil Eichinger wrote:
> > Signed-off-by: Phil Eichinger <phil@zankapfel.net>
> > ---
> >  package/rpi-userland/Config.in |    5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
>
> Thanks. Not sure how you found this, but note that it is also fixes an
> autobuilder failure:
>
>
> http://autobuild.buildroot.net/results/c3b4c09edee2499e811808018be1858bdee70436/
>

I thought I was referencing that in the commit message, but somehow it got
lost.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131008/4db3a1cc/attachment.html>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] rpi-userland: needs threads
  2013-10-08  8:36 [Buildroot] [PATCH 1/1] rpi-userland: needs threads Phil Eichinger
  2013-10-08  8:47 ` Thomas Petazzoni
@ 2013-10-08 16:28 ` Yann E. MORIN
  2013-10-08 20:17 ` Peter Korsgaard
  2 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2013-10-08 16:28 UTC (permalink / raw)
  To: buildroot

On 2013-10-08 10:36 +0200, Phil Eichinger spake thusly:
> Signed-off-by: Phil Eichinger <phil@zankapfel.net>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

> ---
>  package/rpi-userland/Config.in |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/rpi-userland/Config.in b/package/rpi-userland/Config.in
> index da5726f..d4e28a1 100644
> --- a/package/rpi-userland/Config.in
> +++ b/package/rpi-userland/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_RPI_USERLAND
>  	depends on BR2_arm
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_LARGEFILE
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	select BR2_PACKAGE_HAS_OPENGL_EGL
>  	select BR2_PACKAGE_HAS_OPENGL_ES
>  	select BR2_PACKAGE_HAS_OPENVG
> @@ -16,5 +17,5 @@ config BR2_PACKAGE_RPI_USERLAND
>  
>  	  https://github.com/raspberrypi/userland/
>  
> -comment "rpi-userland requires a toolchain with C++ and LARGEFILE support"
> -	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE
> +comment "rpi-userland requires a toolchain with C++, LARGEFILE and threads support"
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
> -- 
> 1.7.10.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] rpi-userland: needs threads
  2013-10-08  8:36 [Buildroot] [PATCH 1/1] rpi-userland: needs threads Phil Eichinger
  2013-10-08  8:47 ` Thomas Petazzoni
  2013-10-08 16:28 ` Yann E. MORIN
@ 2013-10-08 20:17 ` Peter Korsgaard
  2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2013-10-08 20:17 UTC (permalink / raw)
  To: buildroot

>>>>> "Phil" == Phil Eichinger <phil.eichinger@gmail.com> writes:

 Phil> Signed-off-by: Phil Eichinger <phil@zankapfel.net>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-10-08 20:17 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-08  8:36 [Buildroot] [PATCH 1/1] rpi-userland: needs threads Phil Eichinger
2013-10-08  8:47 ` Thomas Petazzoni
2013-10-08  8:52   ` Phil Eichinger
2013-10-08 16:28 ` Yann E. MORIN
2013-10-08 20:17 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox