* [Buildroot] [git commit] Makefile: export BUILD_DIR
@ 2013-10-24 6:47 Peter Korsgaard
2013-10-24 14:53 ` Sagaert Johan
2013-10-24 18:06 ` Ryan Barnett
0 siblings, 2 replies; 5+ messages in thread
From: Peter Korsgaard @ 2013-10-24 6:47 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=feb0877015cc0c644129e69276b3000c83742750
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
$(BUILD_DIR) is a nice place to put files generated during the build.
With the advent of user-supplied step-hooks, they may want to store
some information on the build.
Export BUILD_DIR to that effect; update manual accordingly.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
Makefile | 1 +
docs/manual/customize-rootfs.txt | 3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index f266e2d..9528703 100644
--- a/Makefile
+++ b/Makefile
@@ -291,6 +291,7 @@ export STAGING_DIR
export HOST_DIR
export BINARIES_DIR
export BASE_DIR
+export BUILD_DIR
################################################################################
#
diff --git a/docs/manual/customize-rootfs.txt b/docs/manual/customize-rootfs.txt
index 49a6b4b..158389c 100644
--- a/docs/manual/customize-rootfs.txt
+++ b/docs/manual/customize-rootfs.txt
@@ -41,6 +41,7 @@ there are a few ways to customize the resulting target filesystem.
- +BUILDROOT_CONFIG+: the path to the Buildroot .config file
- +HOST_DIR+, +STAGING_DIR+, +TARGET_DIR+: see
xref:generic-package-reference[]
+ - +BUILD_DIR+: the directory where packages are extracted and built
- +BINARIES_DIR+: the place where all binary files (aka images) are
stored
- +BASE_DIR+: the base output directory
@@ -79,7 +80,7 @@ in one of these _post-image scripts_ will require special handling
Just like for the _post-build scripts_ mentioned above, you also have
access to the following environment variables from your _post-image
scripts_: +BUILDROOT_CONFIG+, +HOST_DIR+, +STAGING_DIR+, +TARGET_DIR+,
-+BINARIES_DIR+ and +BASE_DIR+.
++BUILD_DIR+, +BINARIES_DIR+ and +BASE_DIR+.
Additionally, each of the +BR2_ROOTFS_POST_BUILD_SCRIPT+ and
+BR2_ROOTFS_POST_IMAGE_SCRIPT+ scripts will be passed the arguments
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] Makefile: export BUILD_DIR
2013-10-24 6:47 [Buildroot] [git commit] Makefile: export BUILD_DIR Peter Korsgaard
@ 2013-10-24 14:53 ` Sagaert Johan
2013-10-27 16:31 ` Thomas Petazzoni
2013-10-24 18:06 ` Ryan Barnett
1 sibling, 1 reply; 5+ messages in thread
From: Sagaert Johan @ 2013-10-24 14:53 UTC (permalink / raw)
To: buildroot
Hi All
What is the difference between TOPDIR and BASE_DIR variables?
Johan
-----Oorspronkelijk bericht-----
Van: buildroot-bounces at busybox.net [mailto:buildroot-bounces at busybox.net] Namens Peter Korsgaard
Verzonden: donderdag 24 oktober 2013 8:47
Aan: buildroot at busybox.net
Onderwerp: [Buildroot] [git commit] Makefile: export BUILD_DIR
commit: http://git.buildroot.net/buildroot/commit/?id=feb0877015cc0c644129e69276b3000c83742750
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
$(BUILD_DIR) is a nice place to put files generated during the build.
With the advent of user-supplied step-hooks, they may want to store some information on the build.
Export BUILD_DIR to that effect; update manual accordingly.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
Makefile | 1 +
docs/manual/customize-rootfs.txt | 3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index f266e2d..9528703 100644
--- a/Makefile
+++ b/Makefile
@@ -291,6 +291,7 @@ export STAGING_DIR
export HOST_DIR
export BINARIES_DIR
export BASE_DIR
+export BUILD_DIR
################################################################################
#
diff --git a/docs/manual/customize-rootfs.txt b/docs/manual/customize-rootfs.txt
index 49a6b4b..158389c 100644
--- a/docs/manual/customize-rootfs.txt
+++ b/docs/manual/customize-rootfs.txt
@@ -41,6 +41,7 @@ there are a few ways to customize the resulting target filesystem.
- +BUILDROOT_CONFIG+: the path to the Buildroot .config file
- +HOST_DIR+, +STAGING_DIR+, +TARGET_DIR+: see
xref:generic-package-reference[]
+ - +BUILD_DIR+: the directory where packages are extracted and built
- +BINARIES_DIR+: the place where all binary files (aka images) are
stored
- +BASE_DIR+: the base output directory @@ -79,7 +80,7 @@ in one of these _post-image scripts_ will require special handling
Just like for the _post-build scripts_ mentioned above, you also have access to the following environment variables from your
_post-image
scripts_: +BUILDROOT_CONFIG+, +HOST_DIR+, +STAGING_DIR+, +TARGET_DIR+,
-+BINARIES_DIR+ and +BASE_DIR+.
++BUILD_DIR+, +BINARIES_DIR+ and +BASE_DIR+.
Additionally, each of the +BR2_ROOTFS_POST_BUILD_SCRIPT+ and +BR2_ROOTFS_POST_IMAGE_SCRIPT+ scripts will be passed the arguments
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] Makefile: export BUILD_DIR
2013-10-24 6:47 [Buildroot] [git commit] Makefile: export BUILD_DIR Peter Korsgaard
2013-10-24 14:53 ` Sagaert Johan
@ 2013-10-24 18:06 ` Ryan Barnett
2013-10-25 6:08 ` Peter Korsgaard
1 sibling, 1 reply; 5+ messages in thread
From: Ryan Barnett @ 2013-10-24 18:06 UTC (permalink / raw)
To: buildroot
Peter,
Can we please revert this change? It is causing issues with building
u-boot
as seen by the autobuilder logs:
http://autobuild.buildroot.net/results/1f6/1f65289d5c284caa82a4e9137613f792797ee08a/build-end.log
http://autobuild.buildroot.net/results/6a5/6a5f77483e908dc96d08824cf9113402431bace7/build-end.log
Exporting BUILD_DIR is dangerous for u-boot as shown by the following
excerpt
from the uboot/Makefile:
#########################################################################
#
# U-boot build supports generating object files in a separate external
# directory. Two use cases are supported:
#
# 1) Add O= to the make command line
# 'make O=/tmp/build all'
#
# 2) Set environment variable BUILD_DIR to point to the desired location
# 'export BUILD_DIR=/tmp/build'
# 'make'
#
# The second approach can also be used with a MAKEALL script
# 'export BUILD_DIR=/tmp/build'
# './MAKEALL'
#
# Command line 'O=' setting overrides BUILD_DIR environment variable.
#
# When none of the above methods is used the local build is performed and
# the object files are placed in the source directory.
#
The credit should go to Gustavo Zacarias for figuring this issue out
and saving me a lot of headache.
Thanks,
-Ryan
Peter Korsgaard <peter@korsgaard.com> wrote on 10/24/2013 01:47:16 AM:
> commit:
http://git.buildroot.net/buildroot/commit/?id=feb0877015cc0c644129e69276b3000c83742750
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> $(BUILD_DIR) is a nice place to put files generated during the build.
> With the advent of user-supplied step-hooks, they may want to store
> some information on the build.
>
> Export BUILD_DIR to that effect; update manual accordingly.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> Makefile | 1 +
> docs/manual/customize-rootfs.txt | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index f266e2d..9528703 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -291,6 +291,7 @@ export STAGING_DIR
> export HOST_DIR
> export BINARIES_DIR
> export BASE_DIR
> +export BUILD_DIR
>
>
################################################################################
> #
> diff --git a/docs/manual/customize-rootfs.txt
b/docs/manual/customize-rootfs.txt
> index 49a6b4b..158389c 100644
> --- a/docs/manual/customize-rootfs.txt
> +++ b/docs/manual/customize-rootfs.txt
> @@ -41,6 +41,7 @@ there are a few ways to customize the resulting target
filesystem.
> - +BUILDROOT_CONFIG+: the path to the Buildroot .config file
> - +HOST_DIR+, +STAGING_DIR+, +TARGET_DIR+: see
> xref:generic-package-reference[]
> + - +BUILD_DIR+: the directory where packages are extracted and built
> - +BINARIES_DIR+: the place where all binary files (aka images) are
> stored
> - +BASE_DIR+: the base output directory
> @@ -79,7 +80,7 @@ in one of these _post-image scripts_ will require
special handling
> Just like for the _post-build scripts_ mentioned above, you also have
> access to the following environment variables from your _post-image
> scripts_: +BUILDROOT_CONFIG+, +HOST_DIR+, +STAGING_DIR+, +TARGET_DIR+,
> -+BINARIES_DIR+ and +BASE_DIR+.
> ++BUILD_DIR+, +BINARIES_DIR+ and +BASE_DIR+.
>
> Additionally, each of the +BR2_ROOTFS_POST_BUILD_SCRIPT+ and
> +BR2_ROOTFS_POST_IMAGE_SCRIPT+ scripts will be passed the arguments
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] Makefile: export BUILD_DIR
2013-10-24 18:06 ` Ryan Barnett
@ 2013-10-25 6:08 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2013-10-25 6:08 UTC (permalink / raw)
To: buildroot
>>>>> "Ryan" == Ryan Barnett <rjbarnet@rockwellcollins.com> writes:
> Peter,
> Can we please revert this change? It is causing issues with building
> u-boot
> as seen by the autobuilder logs:
> http://autobuild.buildroot.net/results/1f6/1f65289d5c284caa82a4e9137613f792797ee08a/build-end.log
> http://autobuild.buildroot.net/results/6a5/6a5f77483e908dc96d08824cf9113402431bace7/build-end.log
> Exporting BUILD_DIR is dangerous for u-boot as shown by the following
> excerpt
> from the uboot/Makefile:
Yes, I just noticed as well. Will revert.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] Makefile: export BUILD_DIR
2013-10-24 14:53 ` Sagaert Johan
@ 2013-10-27 16:31 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2013-10-27 16:31 UTC (permalink / raw)
To: buildroot
Dear Sagaert Johan,
On Thu, 24 Oct 2013 16:53:28 +0200, Sagaert Johan wrote:
> What is the difference between TOPDIR and BASE_DIR variables?
TOPDIR is the root of the Buildroot source tree.
BASE_DIR is the root of where we do the build (i.e output/ by default,
but can be overridden with O=).
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-27 16:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-24 6:47 [Buildroot] [git commit] Makefile: export BUILD_DIR Peter Korsgaard
2013-10-24 14:53 ` Sagaert Johan
2013-10-27 16:31 ` Thomas Petazzoni
2013-10-24 18:06 ` Ryan Barnett
2013-10-25 6:08 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox