[Buildroot] [PATCH 1/1] cryptsetup: Fix autobuild error http://autobuild.buildroot.net/results/cc1a65b9554bc2ece1b3ea8b51cd805b9bda7e86/

[Buildroot] [PATCH 1/1] cryptsetup: Fix autobuild error http://autobuild.buildroot.net/results/cc1a65b9554bc2ece1b3ea8b51cd805b9bda7e86/

[Clayton Shotwell]

Adding libintl to the libraries list for cryptsetup when using a
uclibc toolchain.

Signed-off-by: Clayton Shotwell <clshotwe@rockwellcollins.com>
---
 package/cryptsetup/cryptsetup.mk |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/cryptsetup/cryptsetup.mk b/package/cryptsetup/cryptsetup.mk
index 48d37f6..d6169ec 100644
--- a/package/cryptsetup/cryptsetup.mk
+++ b/package/cryptsetup/cryptsetup.mk
@@ -12,4 +12,8 @@ CRYPTSETUP_DEPENDENCIES = lvm2 popt e2fsprogs libgcrypt host-pkgconf
 CRYPTSETUP_LICENSE = GPLv2+ (programs), LGPLv2.1+ (library)
 CRYPTSETUP_LICENSE_FILES = COPYING COPYING.LGPL
 
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
+CRYPTSETUP_CONF_ENV += LDFLAGS="-lintl"
+endif
+
 $(eval $(autotools-package))
-- 
1.7.9.5

[Buildroot] [PATCH 1/1] cryptsetup: Fix autobuild error http://autobuild.buildroot.net/results/cc1a65b9554bc2ece1b3ea8b51cd805b9bda7e86/

[Thomas Petazzoni]

Dear Clayton Shotwell,

On Thu, 31 Oct 2013 12:30:52 -0700, Clayton Shotwell wrote:

> +ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
> +CRYPTSETUP_CONF_ENV += LDFLAGS="-lintl"
> +endif

I don't think BR2_TOOLCHAIN_USES_UCLIBC is the right thing to use here.
You should use either BR2_NEEDS_GETTEXT_IF_LOCALE or BR2_NEEDS_GETTEXT,
depending on whether intl is needed unconditionally, or only when
locale support is enabled (which is most likely the case).

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com