Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] qt: remove the BR2_PACKAGE_QT_JAVASCRIPTCORE option
Date: Sat, 2 Nov 2013 18:45:40 +0100	[thread overview]
Message-ID: <20131102174540.GD3542@free.fr> (raw)
In-Reply-To: <1383409024-17839-1-git-send-email-thomas.petazzoni@free-electrons.com>

Thomas, All,

On 2013-11-02 17:17 +0100, Thomas Petazzoni spake thusly:
> The BR2_PACKAGE_QT_JAVASCRIPTCORE option was incorrectly used in
> Buildroot: it's help text and name was pretending it's here to
> enable/disable the JavaScriptCore, but what it did in fact is force
> enable or force disable the usage of the JIT mechanism for the
> JavaScript support in Qt.
> 
> However, the JIT mechanism is architecture-specific, and therefore not
> available for all architectures, and Qt already knows on which
> architectures it is appropriate to enable JIT and on which
> architectures it is not.
> 
> Therefore, this commit simply removes the
> BR2_PACKAGE_QT_JAVASCRIPTCORE option. We don't add it to
> Config.in.legacy, because the feature is still available, it's just
> that Qt will know automatically decide whether JIT should be used or
> not.

In fact, I think we should include it in legacy options, just so the
user is informed that this option is no longer available.

Your little blurb above would make a good help entry for that new legacy
option, BTW.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      parent reply	other threads:[~2013-11-02 17:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-02 16:17 [Buildroot] [PATCH 1/2] qt: remove the BR2_PACKAGE_QT_JAVASCRIPTCORE option Thomas Petazzoni
2013-11-02 16:17 ` [Buildroot] [PATCH 2/2] qt: don't allow building WebKit on some architectures Thomas Petazzoni
2013-11-02 18:02   ` Yann E. MORIN
2013-11-04  6:50   ` Arnout Vandecappelle
2013-11-04 23:00   ` Peter Korsgaard
2013-11-02 17:45 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131102174540.GD3542@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox