From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] qt: don't allow building WebKit on some architectures
Date: Sat, 2 Nov 2013 19:02:29 +0100 [thread overview]
Message-ID: <20131102180229.GK3542@free.fr> (raw)
In-Reply-To: <1383409024-17839-2-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2013-11-02 17:17 +0100, Thomas Petazzoni spake thusly:
> WebKit has some architecture specific support, and therefore is not
> necessarily available for all architectures. Make sure the Qt WebKit
> option cannot be selected on those architectures that are not
> supported.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewd-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/qt/Config.in | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/package/qt/Config.in b/package/qt/Config.in
> index 74b9461..b1a2207 100644
> --- a/package/qt/Config.in
> +++ b/package/qt/Config.in
> @@ -344,17 +344,26 @@ config BR2_PACKAGE_QT_NETWORK
> Install the Network module.
> if unsure, say y
>
> +config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
> + bool
> + # see src/3rdparty/webkit/Source/JavaScriptCore/wtf/Platform.h
> + default y if BR2_arm || BR2_armeb || BR2_i386 || BR2_mips || \
> + BR2_mipsel || BR2_powerpc || BR2_sh4 || BR2_sh4eb || \
> + BR2_sh4a || BR2_sh4aeb || BR2_sparc || BR2_x86_64
> +
> config BR2_PACKAGE_QT_WEBKIT
> bool "WebKit Module"
> depends on BR2_PACKAGE_QT_SHARED
> depends on BR2_PACKAGE_QT_GUI_MODULE
> depends on BR2_PACKAGE_QT_NETWORK
> + depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
> help
> Build the WebKit module.
> If unsure, say n.
>
> comment "WebKit needs shared library/gui/network support"
> depends on !(BR2_PACKAGE_QT_SHARED && BR2_PACKAGE_QT_GUI_MODULE && BR2_PACKAGE_QT_NETWORK)
> + depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
>
> config BR2_PACKAGE_QT_STL
> bool "STL support"
> --
> 1.8.1.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2013-11-02 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-02 16:17 [Buildroot] [PATCH 1/2] qt: remove the BR2_PACKAGE_QT_JAVASCRIPTCORE option Thomas Petazzoni
2013-11-02 16:17 ` [Buildroot] [PATCH 2/2] qt: don't allow building WebKit on some architectures Thomas Petazzoni
2013-11-02 18:02 ` Yann E. MORIN [this message]
2013-11-04 6:50 ` Arnout Vandecappelle
2013-11-04 23:00 ` Peter Korsgaard
2013-11-02 17:45 ` [Buildroot] [PATCH 1/2] qt: remove the BR2_PACKAGE_QT_JAVASCRIPTCORE option Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131102180229.GK3542@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox