Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] libnl: simplify makefile by using --{enable, disable}-cli
Date: Sat, 2 Nov 2013 18:56:36 +0100	[thread overview]
Message-ID: <20131102175636.GF3542@free.fr> (raw)
In-Reply-To: <1383387986-9508-1-git-send-email-thomas.petazzoni@free-electrons.com>

Thomas, All,

On 2013-11-02 11:26 +0100, Thomas Petazzoni spake thusly:
> The libnl configure script has a --{enable,disable}-cli options that
> allows to enable or disable the compilation of the libnl tools. Use
> this option instead of compiling everything and then removing the
> installed programs.
> 
> Note that we also get rid of the uninstall command, which is planned
> to be globally removed in Buildroot.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

> ---
>  package/libnl/libnl.mk | 19 ++++---------------
>  1 file changed, 4 insertions(+), 15 deletions(-)
> 
> diff --git a/package/libnl/libnl.mk b/package/libnl/libnl.mk
> index 5c884d7..3b56bc8 100644
> --- a/package/libnl/libnl.mk
> +++ b/package/libnl/libnl.mk
> @@ -10,22 +10,11 @@ LIBNL_LICENSE = LGPLv2.1+
>  LIBNL_LICENSE_FILES = COPYING
>  LIBNL_INSTALL_STAGING = YES
>  LIBNL_DEPENDENCIES = host-bison host-flex
> -LIBNL_BINARIES = class-add class-delete class-list classid-lookup cls-add \
> -	cls-delete cls-list link-list pktloc-lookup qdisc-add qdisc-delete \
> -	qdisc-list
>  
> -define LIBNL_UNINSTALL_TARGET_CMDS
> -	rm -r $(TARGET_DIR)/usr/lib/libnl.* $(TARGET_DIR)/usr/lib/libnl-*.*
> -	rm -rf $(TARGET_DIR)/usr/lib/libnl
> -endef
> -
> -define LIBNL_REMOVE_TOOLS
> -	rm -rf $(addprefix $(TARGET_DIR)/usr/sbin/nl-, $(LIBNL_BINARIES))
> -	rm -rf $(TARGET_DIR)/usr/sbin/genl-ctrl-list
> -endef
> -
> -ifneq ($(BR2_PACKAGE_LIBNL_TOOLS),y)
> -LIBNL_POST_INSTALL_TARGET_HOOKS += LIBNL_REMOVE_TOOLS
> +ifeq ($(BR2_PACKAGE_LIBNL_TOOLS),y)
> +LIBNL_CONF_OPT += --enable-cli
> +else
> +LIBNL_CONF_OPT += --disable-cli
>  endif
>  
>  $(eval $(autotools-package))
> -- 
> 1.8.1.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2013-11-02 17:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-02 10:26 [Buildroot] [PATCH 1/2] libnl: simplify makefile by using --{enable, disable}-cli Thomas Petazzoni
2013-11-02 10:26 ` [Buildroot] [PATCH 2/2] libnl: do not allow to build tools on static lib configs Thomas Petazzoni
2013-11-02 17:57   ` Yann E. MORIN
2013-11-02 18:01   ` Samuel Martin
2013-11-04 21:06   ` Peter Korsgaard
2013-11-02 17:56 ` Yann E. MORIN [this message]
2013-11-02 18:00 ` [Buildroot] [PATCH 1/2] libnl: simplify makefile by using --{enable, disable}-cli Samuel Martin
2013-11-02 18:37 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131102175636.GF3542@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox