From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] libnl: do not allow to build tools on static lib configs
Date: Sat, 2 Nov 2013 18:57:26 +0100 [thread overview]
Message-ID: <20131102175726.GG3542@free.fr> (raw)
In-Reply-To: <1383387986-9508-2-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2013-11-02 11:26 +0100, Thomas Petazzoni spake thusly:
> Building the libnl tools requires the <dlfcn.h> header, which is not
> compatible with static only builds. Therefore, this commit makes the
> libnl tools option depend on !BR2_PREFER_STATIC_LIB.
>
> Fixes:
>
> http://autobuild.buildroot.org/results/573/57340b9bd2db3a523836e02e01cba6f7c17c8ca7/build-end.log
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/libnl/Config.in | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/package/libnl/Config.in b/package/libnl/Config.in
> index fec10d3..be41b07 100644
> --- a/package/libnl/Config.in
> +++ b/package/libnl/Config.in
> @@ -6,11 +6,18 @@ config BR2_PACKAGE_LIBNL
>
> http://people.suug.ch/~tgr/libnl/
>
> +comment "libnl needs a toolchain w/ threads"
> + depends on !BR2_TOOLCHAIN_HAS_THREADS
> +
> +if BR2_PACKAGE_LIBNL
> +
> config BR2_PACKAGE_LIBNL_TOOLS
> bool "install tools"
> - depends on BR2_PACKAGE_LIBNL
> + # uses <dlfcn.h>
> + depends on !BR2_PREFER_STATIC_LIB
> help
> Install binary tools.
>
> -comment "libnl needs a toolchain w/ threads"
> - depends on !BR2_TOOLCHAIN_HAS_THREADS
> +comment "libnl tools need a toolchain w/ dynamic library"
> +
> +endif
> --
> 1.8.1.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2013-11-02 17:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-02 10:26 [Buildroot] [PATCH 1/2] libnl: simplify makefile by using --{enable, disable}-cli Thomas Petazzoni
2013-11-02 10:26 ` [Buildroot] [PATCH 2/2] libnl: do not allow to build tools on static lib configs Thomas Petazzoni
2013-11-02 17:57 ` Yann E. MORIN [this message]
2013-11-02 18:01 ` Samuel Martin
2013-11-04 21:06 ` Peter Korsgaard
2013-11-02 17:56 ` [Buildroot] [PATCH 1/2] libnl: simplify makefile by using --{enable, disable}-cli Yann E. MORIN
2013-11-02 18:00 ` Samuel Martin
2013-11-02 18:37 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131102175726.GG3542@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox