* [Buildroot] [PATCH] libvpx: needs thread support
@ 2013-11-02 16:04 Thomas Petazzoni
2013-11-02 18:00 ` Yann E. MORIN
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2013-11-02 16:04 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.org/results/8de/8def7e54e4fecb7df350443824c00b53d1c61c01/build-end.log
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
package/gstreamer1/gst1-plugins-good/Config.in | 4 ++++
package/libvpx/Config.in | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/package/gstreamer1/gst1-plugins-good/Config.in b/package/gstreamer1/gst1-plugins-good/Config.in
index 3342208..a9308c7 100644
--- a/package/gstreamer1/gst1-plugins-good/Config.in
+++ b/package/gstreamer1/gst1-plugins-good/Config.in
@@ -335,9 +335,13 @@ comment "taglib needs a toolchain w/ C++"
config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX
bool "vpx (webm)"
select BR2_PACKAGE_LIBVPX
+ depends on BR2_TOOLCHAIN_HAS_THREADS # libvpx
help
VP8 plugin
+comment "libvpx needs a toolchain w/ threads"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS
+
config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_WAVPACK
bool "wavpack (*.wv audio)"
select BR2_PACKAGE_WAVPACK
diff --git a/package/libvpx/Config.in b/package/libvpx/Config.in
index 1332c56..0ed3e1a 100644
--- a/package/libvpx/Config.in
+++ b/package/libvpx/Config.in
@@ -1,7 +1,11 @@
config BR2_PACKAGE_LIBVPX
bool "libvpx"
+ depends on BR2_TOOLCHAIN_HAS_THREADS
help
A high-quality, open video format that's freely available to
everyone.
http://webmproject.org
+
+comment "libvpx needs a toolchain w/ threads"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] libvpx: needs thread support
2013-11-02 16:04 [Buildroot] [PATCH] libvpx: needs thread support Thomas Petazzoni
@ 2013-11-02 18:00 ` Yann E. MORIN
2013-11-02 18:00 ` Samuel Martin
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2013-11-02 18:00 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2013-11-02 17:04 +0100, Thomas Petazzoni spake thusly:
> Fixes:
>
> http://autobuild.buildroot.org/results/8de/8def7e54e4fecb7df350443824c00b53d1c61c01/build-end.log
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/gstreamer1/gst1-plugins-good/Config.in | 4 ++++
> package/libvpx/Config.in | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/package/gstreamer1/gst1-plugins-good/Config.in b/package/gstreamer1/gst1-plugins-good/Config.in
> index 3342208..a9308c7 100644
> --- a/package/gstreamer1/gst1-plugins-good/Config.in
> +++ b/package/gstreamer1/gst1-plugins-good/Config.in
> @@ -335,9 +335,13 @@ comment "taglib needs a toolchain w/ C++"
> config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX
> bool "vpx (webm)"
> select BR2_PACKAGE_LIBVPX
> + depends on BR2_TOOLCHAIN_HAS_THREADS # libvpx
> help
> VP8 plugin
>
> +comment "libvpx needs a toolchain w/ threads"
> + depends on !BR2_TOOLCHAIN_HAS_THREADS
> +
> config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_WAVPACK
> bool "wavpack (*.wv audio)"
> select BR2_PACKAGE_WAVPACK
> diff --git a/package/libvpx/Config.in b/package/libvpx/Config.in
> index 1332c56..0ed3e1a 100644
> --- a/package/libvpx/Config.in
> +++ b/package/libvpx/Config.in
> @@ -1,7 +1,11 @@
> config BR2_PACKAGE_LIBVPX
> bool "libvpx"
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> help
> A high-quality, open video format that's freely available to
> everyone.
>
> http://webmproject.org
> +
> +comment "libvpx needs a toolchain w/ threads"
> + depends on !BR2_TOOLCHAIN_HAS_THREADS
> --
> 1.8.1.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] libvpx: needs thread support
2013-11-02 16:04 [Buildroot] [PATCH] libvpx: needs thread support Thomas Petazzoni
2013-11-02 18:00 ` Yann E. MORIN
@ 2013-11-02 18:00 ` Samuel Martin
2013-11-02 18:37 ` Thomas Petazzoni
2013-11-04 21:05 ` Peter Korsgaard
3 siblings, 0 replies; 5+ messages in thread
From: Samuel Martin @ 2013-11-02 18:00 UTC (permalink / raw)
To: buildroot
2013/11/2 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Fixes:
>
>
> http://autobuild.buildroot.org/results/8de/8def7e54e4fecb7df350443824c00b53d1c61c01/build-end.log
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
Acked-by: Samuel Martin <s.martin49@gmail.com>
Regards,
--
Samuel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131102/6ff8e678/attachment-0001.html>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] libvpx: needs thread support
2013-11-02 16:04 [Buildroot] [PATCH] libvpx: needs thread support Thomas Petazzoni
2013-11-02 18:00 ` Yann E. MORIN
2013-11-02 18:00 ` Samuel Martin
@ 2013-11-02 18:37 ` Thomas Petazzoni
2013-11-04 21:05 ` Peter Korsgaard
3 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2013-11-02 18:37 UTC (permalink / raw)
To: buildroot
Dear Thomas Petazzoni,
On Sat, 2 Nov 2013 17:04:57 +0100, Thomas Petazzoni wrote:
> Fixes:
>
> http://autobuild.buildroot.org/results/8de/8def7e54e4fecb7df350443824c00b53d1c61c01/build-end.log
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> package/gstreamer1/gst1-plugins-good/Config.in | 4 ++++
> package/libvpx/Config.in | 4 ++++
> 2 files changed, 8 insertions(+)
Committed to for-peter-2013.11, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] libvpx: needs thread support
2013-11-02 16:04 [Buildroot] [PATCH] libvpx: needs thread support Thomas Petazzoni
` (2 preceding siblings ...)
2013-11-02 18:37 ` Thomas Petazzoni
@ 2013-11-04 21:05 ` Peter Korsgaard
3 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2013-11-04 21:05 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Fixes:
> http://autobuild.buildroot.org/results/8de/8def7e54e4fecb7df350443824c00b53d1c61c01/build-end.log
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> package/gstreamer1/gst1-plugins-good/Config.in | 4 ++++
> package/libvpx/Config.in | 4 ++++
> 2 files changed, 8 insertions(+)
> diff --git a/package/gstreamer1/gst1-plugins-good/Config.in b/package/gstreamer1/gst1-plugins-good/Config.in
> index 3342208..a9308c7 100644
> --- a/package/gstreamer1/gst1-plugins-good/Config.in
> +++ b/package/gstreamer1/gst1-plugins-good/Config.in
> @@ -335,9 +335,13 @@ comment "taglib needs a toolchain w/ C++"
> config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX
> bool "vpx (webm)"
> select BR2_PACKAGE_LIBVPX
> + depends on BR2_TOOLCHAIN_HAS_THREADS # libvpx
> help
> VP8 plugin
> +comment "libvpx needs a toolchain w/ threads"
> + depends on !BR2_TOOLCHAIN_HAS_THREADS
> +
Gstreamer1 itself is a heavy user of threads (and therefor depends on
BR2_TOOLCHAIN_HAS_THREADS), so this comment is never going to be
visible, but ok.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-11-04 21:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-02 16:04 [Buildroot] [PATCH] libvpx: needs thread support Thomas Petazzoni
2013-11-02 18:00 ` Yann E. MORIN
2013-11-02 18:00 ` Samuel Martin
2013-11-02 18:37 ` Thomas Petazzoni
2013-11-04 21:05 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox