Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] Makefile: fix out-of-tree builds with multiple targets with 'all'
Date: Mon, 4 Nov 2013 22:20:35 +0100	[thread overview]
Message-ID: <20131104212035.GD32603@free.fr> (raw)
In-Reply-To: <OF6D0F4B79.3FF51701-ON86257C19.004D284E-86257C19.004EA170@rockwellcollins.com>

Ryan, All,

On 2013-11-04 08:18 -0600, Ryan Barnett spake thusly:
> Yann,
> 
> "Yann E. MORIN" <yann.morin.1998@gmail.com> wrote on 11/03/2013 04:23:01 
> AM:
> 
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > 
> > For out-of-tree builds, this use-case fails to build:
> >     $ make clean all
> > 
> > This is because 'all' is filtered-out in the Makefile wrapper, since
> > the wrapper itself has a 'all' target.
> > 
> > The 'all' target is just the usual naming for the default target in a
> > Makefile. In fact, the first target is the default one, so we can name
> > it whatever we want.
> > 
> > Rename the Makefile wrapper 'all' target to avoid name-clashing.
> 
> Could you please add a comment about fixing the bug I reported? I'll even 
> make it easy for you with having the comment below so you can copy and 
> paste :)
> 
> Fixes bug #6644 

Doh, yes, I'll repost with commit message fixed.

> If you add the comment above, I will give you this:
> 
> Tested-by: Ryan Barnett <rjbarnet@rockwellcollins.com>

Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2013-11-04 21:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-03 10:23 [Buildroot] [PATCH v2] Makefile: fix out-of-tree builds with multiple targets with 'all' Yann E. MORIN
2013-11-04 14:18 ` Ryan Barnett
2013-11-04 21:20   ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131104212035.GD32603@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox