[Buildroot] [PATCH v2] Makefile: fix out-of-tree builds with multiple targets with 'all'

[Buildroot] [PATCH v2] Makefile: fix out-of-tree builds with multiple targets with 'all'

[Yann E. MORIN]

From: "Yann E. MORIN" <yann.morin.1998@free.fr>

For out-of-tree builds, this use-case fails to build:
    $ make clean all

This is because 'all' is filtered-out in the Makefile wrapper, since
the wrapper itself has a 'all' target.

The 'all' target is just the usual naming for the default target in a
Makefile. In fact, the first target is the default one, so we can name
it whatever we want.

Rename the Makefile wrapper 'all' target to avoid name-clashing.

Reported-by: Ryan Barnett <rjbarnet@rockwellcollins.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Ryan Barnett <rjbarnet@rockwellcollins.com>
---
Changes v1->v2:
  - fix one missed 'all' occurence

---
 support/scripts/mkmakefile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/support/scripts/mkmakefile b/support/scripts/mkmakefile
index cef2ec7..27b1507 100755
--- a/support/scripts/mkmakefile
+++ b/support/scripts/mkmakefile
@@ -32,16 +32,16 @@ MAKEFLAGS += --no-print-directory
 
 .PHONY: all \$(MAKECMDGOALS)
 
-all	:= \$(filter-out all Makefile,\$(MAKECMDGOALS))
+all	:= \$(filter-out Makefile,\$(MAKECMDGOALS))
 
-all:
+_all:
 	\$(MAKE) \$(MAKEARGS) \$(all)
 
 Makefile:;
 
-\$(all): all
+\$(all): _all
 	@:
 
-%/: all
+%/: _all
 	@:
 EOF
-- 
1.8.1.2

[Buildroot] [PATCH v2] Makefile: fix out-of-tree builds with multiple targets with 'all'

[Ryan Barnett]

Yann,

"Yann E. MORIN" <yann.morin.1998@gmail.com> wrote on 11/03/2013 04:23:01 
AM:

> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> For out-of-tree builds, this use-case fails to build:
>     $ make clean all
> 
> This is because 'all' is filtered-out in the Makefile wrapper, since
> the wrapper itself has a 'all' target.
> 
> The 'all' target is just the usual naming for the default target in a
> Makefile. In fact, the first target is the default one, so we can name
> it whatever we want.
> 
> Rename the Makefile wrapper 'all' target to avoid name-clashing.

Could you please add a comment about fixing the bug I reported? I'll even 
make it easy for you with having the comment below so you can copy and 
paste :)

Fixes bug #6644 

If you add the comment above, I will give you this:

Tested-by: Ryan Barnett <rjbarnet@rockwellcollins.com>

> Reported-by: Ryan Barnett <rjbarnet@rockwellcollins.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Ryan Barnett <rjbarnet@rockwellcollins.com>
> ---
> Changes v1->v2:
>   - fix one missed 'all' occurence
> 

[Buildroot] [PATCH v2] Makefile: fix out-of-tree builds with multiple targets with 'all'

[Yann E. MORIN]

Ryan, All,

On 2013-11-04 08:18 -0600, Ryan Barnett spake thusly:
> Yann,
> 
> "Yann E. MORIN" <yann.morin.1998@gmail.com> wrote on 11/03/2013 04:23:01 
> AM:
> 
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > 
> > For out-of-tree builds, this use-case fails to build:
> >     $ make clean all
> > 
> > This is because 'all' is filtered-out in the Makefile wrapper, since
> > the wrapper itself has a 'all' target.
> > 
> > The 'all' target is just the usual naming for the default target in a
> > Makefile. In fact, the first target is the default one, so we can name
> > it whatever we want.
> > 
> > Rename the Makefile wrapper 'all' target to avoid name-clashing.
> 
> Could you please add a comment about fixing the bug I reported? I'll even 
> make it easy for you with having the comment below so you can copy and 
> paste :)
> 
> Fixes bug #6644 

Doh, yes, I'll repost with commit message fixed.

> If you add the comment above, I will give you this:
> 
> Tested-by: Ryan Barnett <rjbarnet@rockwellcollins.com>

Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'