* [Buildroot] [PATCH v2 1/1] Avoid toolchain download when it is preinstalled
@ 2013-11-06 15:37 Laurent GONZALEZ
2013-11-06 15:50 ` Thomas De Schampheleire
2013-11-06 15:52 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Laurent GONZALEZ @ 2013-11-06 15:37 UTC (permalink / raw)
To: buildroot
For configurations using a toolchain that is preinstalled on
the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept
empty to avoid downloading any toolchain package.
Signed-off-by: GONZALEZ Laurent <br2@gezedo.com>
---
toolchain/toolchain-external/toolchain-external.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
index 2722600..5eb86c7 100644
--- a/toolchain/toolchain-external/toolchain-external.mk
+++ b/toolchain/toolchain-external/toolchain-external.mk
@@ -236,6 +236,7 @@ define TOOLCHAIN_EXTERNAL_LINARO_ARMHF_SYMLINK
ln -sf . $(TARGET_DIR)/usr/lib/arm-linux-gnueabihf
endef
+ifeq ($(BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD),y)
ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM201109),y)
TOOLCHAIN_EXTERNAL_SITE = http://sourcery.mentor.com/public/gnu_toolchain/arm-none-linux-gnueabi/
TOOLCHAIN_EXTERNAL_SOURCE = arm-2011.09-70-arm-none-linux-gnueabi-i686-pc-linux-gnu.tar.bz2
@@ -347,6 +348,10 @@ else
TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
TOOLCHAIN_EXTERNAL_SOURCE = $(notdir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
endif
+else
+TOOLCHAIN_EXTERNAL_SITE =
+TOOLCHAIN_EXTERNAL_SOURCE =
+endif
TOOLCHAIN_EXTERNAL_INSTALL_STAGING = YES
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2 1/1] Avoid toolchain download when it is preinstalled
2013-11-06 15:37 [Buildroot] [PATCH v2 1/1] Avoid toolchain download when it is preinstalled Laurent GONZALEZ
@ 2013-11-06 15:50 ` Thomas De Schampheleire
2013-11-06 15:52 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Thomas De Schampheleire @ 2013-11-06 15:50 UTC (permalink / raw)
To: buildroot
On Wed, Nov 6, 2013 at 4:37 PM, Laurent GONZALEZ <br2@gezedo.com> wrote:
> For configurations using a toolchain that is preinstalled on
> the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept
> empty to avoid downloading any toolchain package.
>
> Signed-off-by: GONZALEZ Laurent <br2@gezedo.com>
> ---
> toolchain/toolchain-external/toolchain-external.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
> index 2722600..5eb86c7 100644
> --- a/toolchain/toolchain-external/toolchain-external.mk
> +++ b/toolchain/toolchain-external/toolchain-external.mk
> @@ -236,6 +236,7 @@ define TOOLCHAIN_EXTERNAL_LINARO_ARMHF_SYMLINK
> ln -sf . $(TARGET_DIR)/usr/lib/arm-linux-gnueabihf
> endef
>
> +ifeq ($(BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD),y)
> ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM201109),y)
> TOOLCHAIN_EXTERNAL_SITE = http://sourcery.mentor.com/public/gnu_toolchain/arm-none-linux-gnueabi/
> TOOLCHAIN_EXTERNAL_SOURCE = arm-2011.09-70-arm-none-linux-gnueabi-i686-pc-linux-gnu.tar.bz2
> @@ -347,6 +348,10 @@ else
> TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
> TOOLCHAIN_EXTERNAL_SOURCE = $(notdir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
> endif
> +else
> +TOOLCHAIN_EXTERNAL_SITE =
> +TOOLCHAIN_EXTERNAL_SOURCE =
> +endif
>
> TOOLCHAIN_EXTERNAL_INSTALL_STAGING = YES
>
Tested-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2 1/1] Avoid toolchain download when it is preinstalled
2013-11-06 15:37 [Buildroot] [PATCH v2 1/1] Avoid toolchain download when it is preinstalled Laurent GONZALEZ
2013-11-06 15:50 ` Thomas De Schampheleire
@ 2013-11-06 15:52 ` Thomas Petazzoni
2013-11-06 17:27 ` Laurent GONZALEZ
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2013-11-06 15:52 UTC (permalink / raw)
To: buildroot
Dear Laurent GONZALEZ,
On Wed, 06 Nov 2013 16:37:32 +0100, Laurent GONZALEZ wrote:
> For configurations using a toolchain that is preinstalled on
> the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept
> empty to avoid downloading any toolchain package.
>
> Signed-off-by: GONZALEZ Laurent <br2@gezedo.com>
> ---
> toolchain/toolchain-external/toolchain-external.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
> index 2722600..5eb86c7 100644
> --- a/toolchain/toolchain-external/toolchain-external.mk
> +++ b/toolchain/toolchain-external/toolchain-external.mk
> @@ -236,6 +236,7 @@ define TOOLCHAIN_EXTERNAL_LINARO_ARMHF_SYMLINK
> ln -sf . $(TARGET_DIR)/usr/lib/arm-linux-gnueabihf
> endef
>
> +ifeq ($(BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD),y)
> ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM201109),y)
> TOOLCHAIN_EXTERNAL_SITE = http://sourcery.mentor.com/public/gnu_toolchain/arm-none-linux-gnueabi/
> TOOLCHAIN_EXTERNAL_SOURCE = arm-2011.09-70-arm-none-linux-gnueabi-i686-pc-linux-gnu.tar.bz2
> @@ -347,6 +348,10 @@ else
> TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
> TOOLCHAIN_EXTERNAL_SOURCE = $(notdir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
> endif
> +else
> +TOOLCHAIN_EXTERNAL_SITE =
> +TOOLCHAIN_EXTERNAL_SOURCE =
> +endif
>
> TOOLCHAIN_EXTERNAL_INSTALL_STAGING = YES
As I suggested, I don't think enclosing all of the toolchain profiles
in ifeq ($(BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD),y) is useful.
See my reply to your previous version.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2 1/1] Avoid toolchain download when it is preinstalled
2013-11-06 15:52 ` Thomas Petazzoni
@ 2013-11-06 17:27 ` Laurent GONZALEZ
0 siblings, 0 replies; 4+ messages in thread
From: Laurent GONZALEZ @ 2013-11-06 17:27 UTC (permalink / raw)
To: buildroot
On 06/11/2013 16:52, Thomas Petazzoni wrote:
> Dear Laurent GONZALEZ,
>
> On Wed, 06 Nov 2013 16:37:32 +0100, Laurent GONZALEZ wrote:
>> For configurations using a toolchain that is preinstalled on
>> the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept
>> empty to avoid downloading any toolchain package.
>>
>> Signed-off-by: GONZALEZ Laurent <br2@gezedo.com>
>> ---
>> toolchain/toolchain-external/toolchain-external.mk | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
>> index 2722600..5eb86c7 100644
>> --- a/toolchain/toolchain-external/toolchain-external.mk
>> +++ b/toolchain/toolchain-external/toolchain-external.mk
>> @@ -236,6 +236,7 @@ define TOOLCHAIN_EXTERNAL_LINARO_ARMHF_SYMLINK
>> ln -sf . $(TARGET_DIR)/usr/lib/arm-linux-gnueabihf
>> endef
>>
>> +ifeq ($(BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD),y)
>> ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM201109),y)
>> TOOLCHAIN_EXTERNAL_SITE = http://sourcery.mentor.com/public/gnu_toolchain/arm-none-linux-gnueabi/
>> TOOLCHAIN_EXTERNAL_SOURCE = arm-2011.09-70-arm-none-linux-gnueabi-i686-pc-linux-gnu.tar.bz2
>> @@ -347,6 +348,10 @@ else
>> TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
>> TOOLCHAIN_EXTERNAL_SOURCE = $(notdir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
>> endif
>> +else
>> +TOOLCHAIN_EXTERNAL_SITE =
>> +TOOLCHAIN_EXTERNAL_SOURCE =
>> +endif
>>
>> TOOLCHAIN_EXTERNAL_INSTALL_STAGING = YES
>
> As I suggested, I don't think enclosing all of the toolchain profiles
> in ifeq ($(BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD),y) is useful.
>
IHMO, it is useful.
Consider a configuration, where a have a CS toolchain already installed somewhere on my host, I want to use it, but I want to avoid an extra download.
BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM201305=y
# BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM201203 is not set
# BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM201109 is not set
# BR2_TOOLCHAIN_EXTERNAL_ARAGO_ARMV5TE_201109 is not set
# BR2_TOOLCHAIN_EXTERNAL_CUSTOM is not set
# BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD is not set
BR2_TOOLCHAIN_EXTERNAL_PREINSTALLED=y
BR2_TOOLCHAIN_EXTERNAL_PATH="/path/to/toolchain/usr"
BR2_TOOLCHAIN_EXTERNAL_PREFIX="arm-none-linux-gnueabi"
That's why the global enclosing is required. Generally it does not look to be a bad idea to prevent download when BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD is not set !
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-06 17:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-06 15:37 [Buildroot] [PATCH v2 1/1] Avoid toolchain download when it is preinstalled Laurent GONZALEZ
2013-11-06 15:50 ` Thomas De Schampheleire
2013-11-06 15:52 ` Thomas Petazzoni
2013-11-06 17:27 ` Laurent GONZALEZ
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox