Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] openpgm: disable on AVR32
Date: Fri, 8 Nov 2013 13:17:15 +0100	[thread overview]
Message-ID: <20131108131715.0c03641e@skate> (raw)
In-Reply-To: <20131107085841.8061F9BB05@busybox.osuosl.org>

Simon, Peter,

On Thu, 7 Nov 2013 09:56:24 +0100, Peter Korsgaard wrote:

>  config BR2_PACKAGE_OPENPGM
>  	bool "openpgm"
> +	depends on !BR2_GCC_VERSION_4_2_2_AVR32_2_1_5 # lacks required builtins

I apologize, but I'm going to contradict myself :-(

Your original patch had 'depends on !BR2_avr32' and I said it would be
more exact to have 'depends on !BR2_GCC_VERSION_4_2_2_AVR32_2_1_5',
since it's actually the compiler version that is causing the problem
(an hypothetical more recent gcc version for AVR32 might fix the
problem). And therefore, you sent an updated patch that uses a depends
on the compiler version, and it got committed.

But in fact, this has a significant drawback: it means that the
openpgm package can still be enabled when we're using an external AVR32
toolchain (which is what the autobuilders are doing).

Since for external toolchains we don't have any information about the
compiler version being used, I would in fact suggest to revert back to
'depends on !BR2_avr32' as you proposed originally.

I'm really sorry for this change of opinion, I just forgot the external
toolchain case when I made the comment previously.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2013-11-08 12:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07  8:56 [Buildroot] [git commit] openpgm: disable on AVR32 Peter Korsgaard
2013-11-08 12:17 ` Thomas Petazzoni [this message]
2013-11-08 12:52   ` Alexander Lukichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131108131715.0c03641e@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox