[Buildroot] [git commit] openpgm: disable on AVR32

[Buildroot] [git commit] openpgm: disable on AVR32

[Peter Korsgaard]

commit: http://git.buildroot.net/buildroot/commit/?id=00a9540367577d5fb653ecc01229f9016e08419e
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

openpgm doesn't build correctly on AVR32 using
gcc-4.2.2-avr32-2.1.5 toolchain: it is configured to call
intrinsic atomic functions not provided by the toolchain,
so they are propagated as unresolved external symbols in the
built openpgm libraries. This breaks programs that try to link
openpgm, because they do not know where to get those either. For
instance, it breaks building zeromq tests when PGM support is
selected.

This commit disables openpgm on AVR32 due to apparent absence of
interest in this package on that architecture and it breaking too
many test builds.

Fixes http://autobuild.buildroot.net/results/5a3261109ea63ba17375003eabd8b5d88757865f/
(at least)

Signed-off-by: Alexander Lukichev <alexander.lukichev@gmail.com>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/openpgm/Config.in |    2 ++
 package/zeromq/Config.in  |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/package/openpgm/Config.in b/package/openpgm/Config.in
index cae74f7..e34740c 100644
--- a/package/openpgm/Config.in
+++ b/package/openpgm/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_OPENPGM
 	bool "openpgm"
+	depends on !BR2_GCC_VERSION_4_2_2_AVR32_2_1_5 # lacks required builtins
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_INET_IPV6
 	depends on BR2_USE_WCHAR
@@ -14,3 +15,4 @@ config BR2_PACKAGE_OPENPGM
 
 comment "openpgm needs a toolchain w/ wchar, threads, IPv6"
 	depends on !(BR2_TOOLCHAIN_HAS_THREADS && BR2_INET_IPV6 && BR2_USE_WCHAR)
+	depends on !BR2_GCC_VERSION_4_2_2_AVR32_2_1_5
diff --git a/package/zeromq/Config.in b/package/zeromq/Config.in
index 42e13d2..dad1dd4 100644
--- a/package/zeromq/Config.in
+++ b/package/zeromq/Config.in
@@ -30,6 +30,7 @@ config BR2_PACKAGE_ZEROMQ
 config BR2_PACKAGE_ZEROMQ_PGM
 	bool "PGM/EPGM support"
 	depends on BR2_PACKAGE_ZEROMQ
+	depends on !BR2_GCC_VERSION_4_2_2_AVR32_2_1_5 # openpgm
 	select BR2_PACKAGE_OPENPGM
 	help
 	  Add support for Pragmatic General Multicast protocol (RFC 3208)

[Buildroot] [git commit] openpgm: disable on AVR32

[Thomas Petazzoni]

Simon, Peter,

On Thu, 7 Nov 2013 09:56:24 +0100, Peter Korsgaard wrote:

>  config BR2_PACKAGE_OPENPGM
>  	bool "openpgm"
> +	depends on !BR2_GCC_VERSION_4_2_2_AVR32_2_1_5 # lacks required builtins

I apologize, but I'm going to contradict myself :-(

Your original patch had 'depends on !BR2_avr32' and I said it would be
more exact to have 'depends on !BR2_GCC_VERSION_4_2_2_AVR32_2_1_5',
since it's actually the compiler version that is causing the problem
(an hypothetical more recent gcc version for AVR32 might fix the
problem). And therefore, you sent an updated patch that uses a depends
on the compiler version, and it got committed.

But in fact, this has a significant drawback: it means that the
openpgm package can still be enabled when we're using an external AVR32
toolchain (which is what the autobuilders are doing).

Since for external toolchains we don't have any information about the
compiler version being used, I would in fact suggest to revert back to
'depends on !BR2_avr32' as you proposed originally.

I'm really sorry for this change of opinion, I just forgot the external
toolchain case when I made the comment previously.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [git commit] openpgm: disable on AVR32

[Alexander Lukichev]

Hi Thomas, Peter, Simon,

2013/11/8 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Since for external toolchains we don't have any information about
> the compiler version being used, I would in fact suggest to revert
> back to 'depends on !BR2_avr32' as you proposed originally.

How stupid of me to miss it also. I'm sorry to be a monkey :) Will send
an updated patch. Or should I send a 'fix patch', Peter?

--
Best regards,
  Alexander Lukichev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131108/6c54ce20/attachment.html>