* [Buildroot] [PATCH] iozone: disable for uClibc 0.9.31
@ 2013-11-11 9:49 spdawson at gmail.com
2013-11-11 9:53 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: spdawson at gmail.com @ 2013-11-11 9:49 UTC (permalink / raw)
To: buildroot
From: Simon Dawson <spdawson@gmail.com>
uClibc 0.9.31.x does not include the pthread_setaffinity_np GNU extension.
Fixes build failures such as the following.
http://autobuild.buildroot.net/results/e21526c0c18733310d3fb322d79d5fff3a71af51/
Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
package/iozone/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/iozone/Config.in b/package/iozone/Config.in
index 26d4daa..33e12ca 100644
--- a/package/iozone/Config.in
+++ b/package/iozone/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_IOZONE
bool "iozone"
depends on BR2_USE_MMU # fork()
+ depends on !BR2_UCLIBC_VERSION_0_9_31 # no pthread_setaffinity_np
help
IOzone is a filesystem benchmark tool.
The benchmark generates and measures a variety of file operations
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] iozone: disable for uClibc 0.9.31
2013-11-11 9:49 [Buildroot] [PATCH] iozone: disable for uClibc 0.9.31 spdawson at gmail.com
@ 2013-11-11 9:53 ` Peter Korsgaard
2013-11-11 9:55 ` Simon Dawson
2013-11-11 10:01 ` Baruch Siach
0 siblings, 2 replies; 6+ messages in thread
From: Peter Korsgaard @ 2013-11-11 9:53 UTC (permalink / raw)
To: buildroot
>>>>> "spdawson" == spdawson <spdawson@gmail.com> writes:
> From: Simon Dawson <spdawson@gmail.com>
> uClibc 0.9.31.x does not include the pthread_setaffinity_np GNU extension.
> Fixes build failures such as the following.
> http://autobuild.buildroot.net/results/e21526c0c18733310d3fb322d79d5fff3a71af51/
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> ---
> package/iozone/Config.in | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/package/iozone/Config.in b/package/iozone/Config.in
> index 26d4daa..33e12ca 100644
> --- a/package/iozone/Config.in
> +++ b/package/iozone/Config.in
> @@ -1,6 +1,7 @@
> config BR2_PACKAGE_IOZONE
> bool "iozone"
> depends on BR2_USE_MMU # fork()
> + depends on !BR2_UCLIBC_VERSION_0_9_31 # no pthread_setaffinity_np
Committed, thanks. It sounds like it also needs to depend on
BR2_TOOLCHAIN_HAS_THREADS. Care to send a patch adding that dependency
and a comment line?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] iozone: disable for uClibc 0.9.31
2013-11-11 9:53 ` Peter Korsgaard
@ 2013-11-11 9:55 ` Simon Dawson
2013-11-11 10:01 ` Baruch Siach
1 sibling, 0 replies; 6+ messages in thread
From: Simon Dawson @ 2013-11-11 9:55 UTC (permalink / raw)
To: buildroot
Hi Peter,
On 11 November 2013 09:53, Peter Korsgaard <jacmet@uclibc.org> wrote:
> Committed, thanks. It sounds like it also needs to depend on
> BR2_TOOLCHAIN_HAS_THREADS. Care to send a patch adding that dependency
> and a comment line?
Yes, okay.
Simon.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] iozone: disable for uClibc 0.9.31
2013-11-11 9:53 ` Peter Korsgaard
2013-11-11 9:55 ` Simon Dawson
@ 2013-11-11 10:01 ` Baruch Siach
2013-11-11 10:06 ` Simon Dawson
2013-11-11 10:23 ` Thomas Petazzoni
1 sibling, 2 replies; 6+ messages in thread
From: Baruch Siach @ 2013-11-11 10:01 UTC (permalink / raw)
To: buildroot
Hi Peter, Simon,
On Mon, Nov 11, 2013 at 10:53:57AM +0100, Peter Korsgaard wrote:
> >>>>> "spdawson" == spdawson <spdawson@gmail.com> writes:
>
> > From: Simon Dawson <spdawson@gmail.com>
> > uClibc 0.9.31.x does not include the pthread_setaffinity_np GNU extension.
>
> > Fixes build failures such as the following.
>
> > http://autobuild.buildroot.net/results/e21526c0c18733310d3fb322d79d5fff3a71af51/
>
> > Signed-off-by: Simon Dawson <spdawson@gmail.com>
> > ---
> > package/iozone/Config.in | 1 +
> > 1 file changed, 1 insertion(+)
>
> > diff --git a/package/iozone/Config.in b/package/iozone/Config.in
> > index 26d4daa..33e12ca 100644
> > --- a/package/iozone/Config.in
> > +++ b/package/iozone/Config.in
> > @@ -1,6 +1,7 @@
> > config BR2_PACKAGE_IOZONE
> > bool "iozone"
> > depends on BR2_USE_MMU # fork()
> > + depends on !BR2_UCLIBC_VERSION_0_9_31 # no pthread_setaffinity_np
>
> Committed, thanks. It sounds like it also needs to depend on
> BR2_TOOLCHAIN_HAS_THREADS. Care to send a patch adding that dependency
> and a comment line?
It also depends on BR2_PTHREADS_NATIVE. linuxthreads doesn't have
pthread_setaffinity_np.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] iozone: disable for uClibc 0.9.31
2013-11-11 10:01 ` Baruch Siach
@ 2013-11-11 10:06 ` Simon Dawson
2013-11-11 10:23 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Simon Dawson @ 2013-11-11 10:06 UTC (permalink / raw)
To: buildroot
Hi Baruch,
On 11 November 2013 10:01, Baruch Siach <baruch@tkos.co.il> wrote:
> It also depends on BR2_PTHREADS_NATIVE. linuxthreads doesn't have
> pthread_setaffinity_np.
Okay, thanks.
Simon.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] iozone: disable for uClibc 0.9.31
2013-11-11 10:01 ` Baruch Siach
2013-11-11 10:06 ` Simon Dawson
@ 2013-11-11 10:23 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2013-11-11 10:23 UTC (permalink / raw)
To: buildroot
Dear Baruch Siach,
On Mon, 11 Nov 2013 12:01:50 +0200, Baruch Siach wrote:
> > Committed, thanks. It sounds like it also needs to depend on
> > BR2_TOOLCHAIN_HAS_THREADS. Care to send a patch adding that dependency
> > and a comment line?
>
> It also depends on BR2_PTHREADS_NATIVE. linuxthreads doesn't have
> pthread_setaffinity_np.
It is not allowed to add a BR2_PTHREADS_NATIVE dependency to a package,
because this symbol is meaningless in the context of the external
toolchain backend.
We probably need to add something like
http://patchwork.ozlabs.org/patch/258723/, but updated, and with a
check in the external toolchain code to verify that the selection
matches the reality.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-11 10:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-11 9:49 [Buildroot] [PATCH] iozone: disable for uClibc 0.9.31 spdawson at gmail.com
2013-11-11 9:53 ` Peter Korsgaard
2013-11-11 9:55 ` Simon Dawson
2013-11-11 10:01 ` Baruch Siach
2013-11-11 10:06 ` Simon Dawson
2013-11-11 10:23 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox