From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] alsa-lib: FLAT: Disable alsa lib when FLAT bianry is selected.
Date: Mon, 11 Nov 2013 11:21:28 +0100 [thread overview]
Message-ID: <20131111112128.60a4a348@skate> (raw)
In-Reply-To: <1384146177-6020-1-git-send-email-Sonic.adi@gmail.com>
Hello,
On Mon, 11 Nov 2013 13:02:57 +0800, sonic.adi at gmail.com wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> Alsa lib depends on the runtime library loader.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> ---
> package/alsa-lib/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/alsa-lib/Config.in b/package/alsa-lib/Config.in
> index df05240..1e148cc 100644
> --- a/package/alsa-lib/Config.in
> +++ b/package/alsa-lib/Config.in
> @@ -9,6 +9,7 @@ config BR2_PACKAGE_ALSA_LIB
> # the usage of alsa-lib on no-thread systems is pretty
> # unlikely, just require thread support globally for alsa-lib.
> depends on BR2_TOOLCHAIN_HAS_THREADS
> + depends on !BR2_BINFMT_FLAT
I am not sure this is the right dependency. Shouldn't this instead be a:
depends on !BR2_PREFER_STATIC_LIB
?
The problem is really that we need shared library support, no that
specifically the FLAT binary format is causing problems. If another
binary format doesn't support shared libraries, then we would have to
exclude it as well.
Also, the configure script of alsa-lib has a check to verify if dlfcn.h
is available or not, so I guess it is supposed to fallback gracefully
to another solution if shared library support is not available.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-11-11 10:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 5:02 [Buildroot] [PATCH] alsa-lib: FLAT: Disable alsa lib when FLAT bianry is selected sonic.adi at gmail.com
2013-11-11 7:48 ` Thomas De Schampheleire
2013-11-11 9:39 ` Peter Korsgaard
2013-11-11 10:21 ` Thomas Petazzoni [this message]
2013-11-11 7:31 ` Gustavo Zacarias
2013-11-11 10:43 ` Thomas Petazzoni
2013-11-11 10:54 ` Sonic Zhang
2013-11-11 12:39 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111112128.60a4a348@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox