[Buildroot] [PATCH 3/7] eigen: fix install rules

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Dear Samuel Martin,

On Mon, 11 Nov 2013 22:00:09 +0100, Samuel Martin wrote:

> diff --git a/package/eigen/eigen.mk b/package/eigen/eigen.mk
> index 5abd464..63e21e9 100644
> --- a/package/eigen/eigen.mk
> +++ b/package/eigen/eigen.mk
> @@ -16,8 +16,14 @@ EIGEN_INSTALL_TARGET = NO
>  # This package only consists of headers that need to be
>  # copied over to the sysroot for compile time use
>  define EIGEN_INSTALL_STAGING_CMDS
> -	$(RM) -r $(STAGING_DIR)/usr/include/Eigen
> -	cp -a $(@D)/Eigen $(STAGING_DIR)/usr/include/
> +	for d in Eigen unsupported ; do \
> +		$(RM) -r $(STAGING_DIR)/usr/include/$${d} ; \

Isn't it a bit "rude" to remove
$(STAGING_DIR)/usr/include/unsupported ? I mean, this directory name
doesn't seem very Eigen specific. Even though it's unlikely, there
might be other things installed in there.

> +		rsync -ar --exclude=CMakeLists.txt \
> +			--exclude=test \
> +			--exclude=bench \
> +			--exclude=doc \
> +			$(@D)/$${d} $(STAGING_DIR)/usr/include/ ; \
> +	done

I must say I'm not overly enthusiastic about this solution. No way to
have a proper make install, or cmake stuff working for this package?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com