Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/7] opencv: add eigen dependency
Date: Mon, 11 Nov 2013 23:36:41 +0100	[thread overview]
Message-ID: <20131111233641.2a5564c5@skate> (raw)
In-Reply-To: <1384203613-17871-5-git-send-email-s.martin49@gmail.com>

Dear Samuel Martin,

On Mon, 11 Nov 2013 22:00:10 +0100, Samuel Martin wrote:
>  menuconfig BR2_PACKAGE_OPENCV
>  	bool "opencv"
>  	select BR2_PACKAGE_ZLIB
> +	select BR2_PACKAGE_EIGEN

Any reason to make it mandatory?

I'm sorry but I'm going to be a bit angry again. I've asked you many,
many, many times to write more descriptive commit logs. And once again,
several of your patches have just a one line title, with no explanation
whatsoever about *why* you're doing the change.

It would be really nice if you could review all your patches before you
post them, and ask yourself the question: is the reason why I'm doing
this going to be obvious for the reviewer? If the answer is even on the
slightly unsure side, then it means you need to expand with a more
detailed commit log, or more comments in the code.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2013-11-11 22:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11 21:00 [Buildroot] [PATCH 0/7] OpenCV bump Samuel Martin
2013-11-11 21:00 ` [Buildroot] [PATCH 1/7] cmake: bump to version 2.8.12.1 Samuel Martin
2013-11-11 21:00 ` [Buildroot] [PATCH 2/7] eigen: add C++ toolchain dependency Samuel Martin
2013-11-12  7:15   ` Arnout Vandecappelle
2013-11-11 21:00 ` [Buildroot] [PATCH 3/7] eigen: fix install rules Samuel Martin
2013-11-11 22:33   ` Thomas Petazzoni
2013-11-12  7:24     ` Arnout Vandecappelle
2013-11-12  8:28       ` Samuel Martin
2013-11-15 20:28         ` Samuel Martin
2013-11-11 21:00 ` [Buildroot] [PATCH 4/7] opencv: add eigen dependency Samuel Martin
2013-11-11 22:36   ` Thomas Petazzoni [this message]
2013-11-15 20:22     ` Samuel Martin
2013-11-11 21:00 ` [Buildroot] [PATCH 5/7] opencv: bump to version 2.4.7 Samuel Martin
2013-11-11 21:00 ` [Buildroot] [PATCH 6/7] opencv: rework V4L/libv4l support Samuel Martin
2013-11-11 21:00 ` [Buildroot] [PATCH 7/7] opencv: add Qt5 support Samuel Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131111233641.2a5564c5@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox