* [Buildroot] [PATCH] pv: support ccache builds
@ 2013-11-15 20:28 Andrew Ruder
2013-11-15 20:58 ` Yann E. MORIN
2013-11-17 7:37 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Ruder @ 2013-11-15 20:28 UTC (permalink / raw)
To: buildroot
When using ccache TARGET_CC is something like
ccache gcc
This causes problems in the pv build which attempts to
override LD because the command ends up being
make [...] LD=/tools/ccache /tools/gcc LDFLAGS="[...]
As a result, during the build phase it attempts to build
/tools/gcc which succeeds by doing nothing:
make[1]: Nothing to be done for `/tools/gcc'.
and during the install phase you get the real build which
errors out on the LD error this snippet was attempting to
fix:
ld -r -o src/library.o src/library/getopt.o \
src/library/gettext.o
ld: src/library/gettext.o: Relocations in generic ELF \
(EM: 40)
src/library/gettext.o: error adding symbols: File in \
wrong format
Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>
---
package/pv/pv.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/pv/pv.mk b/package/pv/pv.mk
index 00502d3..5f1a54b 100644
--- a/package/pv/pv.mk
+++ b/package/pv/pv.mk
@@ -17,7 +17,7 @@ PV_LICENSE_FILES = doc/COPYING
# the correct one. By passing the below values for LD and LDFLAGS, we
# ensure that 'gcc' is used to do these partial linking steps.
PV_MAKE_OPT = \
- LD=$(TARGET_CC) \
+ LD="$(TARGET_CC)" \
LDFLAGS="-Wl,-r -nostdlib"
$(eval $(autotools-package))
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Buildroot] [PATCH] pv: support ccache builds
2013-11-15 20:28 [Buildroot] [PATCH] pv: support ccache builds Andrew Ruder
@ 2013-11-15 20:58 ` Yann E. MORIN
2013-11-17 7:37 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2013-11-15 20:58 UTC (permalink / raw)
To: buildroot
Andrew, All,
On 2013-11-15 14:28 -0600, Andrew Ruder spake thusly:
> When using ccache TARGET_CC is something like
> ccache gcc
>
> This causes problems in the pv build which attempts to
> override LD because the command ends up being
> make [...] LD=/tools/ccache /tools/gcc LDFLAGS="[...]
>
> As a result, during the build phase it attempts to build
> /tools/gcc which succeeds by doing nothing:
> make[1]: Nothing to be done for `/tools/gcc'.
>
> and during the install phase you get the real build which
> errors out on the LD error this snippet was attempting to
> fix:
> ld -r -o src/library.o src/library/getopt.o \
> src/library/gettext.o
> ld: src/library/gettext.o: Relocations in generic ELF \
> (EM: 40)
> src/library/gettext.o: error adding symbols: File in \
> wrong format
>
> Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/pv/pv.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pv/pv.mk b/package/pv/pv.mk
> index 00502d3..5f1a54b 100644
> --- a/package/pv/pv.mk
> +++ b/package/pv/pv.mk
> @@ -17,7 +17,7 @@ PV_LICENSE_FILES = doc/COPYING
> # the correct one. By passing the below values for LD and LDFLAGS, we
> # ensure that 'gcc' is used to do these partial linking steps.
> PV_MAKE_OPT = \
> - LD=$(TARGET_CC) \
> + LD="$(TARGET_CC)" \
> LDFLAGS="-Wl,-r -nostdlib"
>
> $(eval $(autotools-package))
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] pv: support ccache builds
2013-11-15 20:28 [Buildroot] [PATCH] pv: support ccache builds Andrew Ruder
2013-11-15 20:58 ` Yann E. MORIN
@ 2013-11-17 7:37 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2013-11-17 7:37 UTC (permalink / raw)
To: buildroot
>>>>> "Andrew" == Andrew Ruder <andrew.ruder@elecsyscorp.com> writes:
> When using ccache TARGET_CC is something like
> ccache gcc
> This causes problems in the pv build which attempts to
> override LD because the command ends up being
> make [...] LD=/tools/ccache /tools/gcc LDFLAGS="[...]
> As a result, during the build phase it attempts to build
> /tools/gcc which succeeds by doing nothing:
> make[1]: Nothing to be done for `/tools/gcc'.
> and during the install phase you get the real build which
> errors out on the LD error this snippet was attempting to
> fix:
> ld -r -o src/library.o src/library/getopt.o \
> src/library/gettext.o
> ld: src/library/gettext.o: Relocations in generic ELF \
> (EM: 40)
> src/library/gettext.o: error adding symbols: File in \
> wrong format
> Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-17 7:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-15 20:28 [Buildroot] [PATCH] pv: support ccache builds Andrew Ruder
2013-11-15 20:58 ` Yann E. MORIN
2013-11-17 7:37 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox