Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Apply upstream patch to set correct linkage on MIPS64
Date: Mon, 18 Nov 2013 12:17:16 +0100	[thread overview]
Message-ID: <20131118121716.2d42d217@skate> (raw)
In-Reply-To: <5289F60D.7000805@imgtec.com>

Dear Markos Chandras,

On Mon, 18 Nov 2013 11:12:13 +0000, Markos Chandras wrote:

> Thanks for the comments. It does not fix anything yet (affected packages 
> need to start using AUTORECONF), and the libiscsi is just one of the 
> problems so we thought it shouldn't be part of the commit message.

I do understand that the patch itself is not fixing the problems, but
if you don't explain *why* you're backporting something, then it isn't
going to be obvious for the maintainer why this libtool change is
needed.

Something like: "This libtool change ensures that ld uses the right
machine emulation file, which will allow to fix several MIPS64 n32 link
failures, such as the one currently visible on the libiscsi package.
Packages affected by this problem will have to use <pkg>_AUTORECONF =
YES to benefit from this libtool fix, until they are fixed upstream."

> I incorrectly thought that we do not use numbers for patches anymore.

We did not use numbers in the past, and the new (1 year old or so)
policy is to use numbers, to guarantee a correct ordering between
patches.

> v2 to follow soon!

Thanks! :-)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2013-11-18 11:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 10:56 [Buildroot] [PATCH] Apply upstream patch to set correct linkage on MIPS64 Vicente Olivert Riera
2013-11-18 11:06 ` Thomas Petazzoni
2013-11-18 11:12   ` Markos Chandras
2013-11-18 11:17     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131118121716.2d42d217@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox