Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Apply upstream patch to set correct linkage on MIPS64
Date: Mon, 18 Nov 2013 11:12:13 +0000	[thread overview]
Message-ID: <5289F60D.7000805@imgtec.com> (raw)
In-Reply-To: <20131118120635.52bba816@skate>

On 11/18/2013 11:06 AM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Mon, 18 Nov 2013 10:56:46 +0000, Vicente Olivert Riera wrote:
>> Acked-by: Markos Chandras <markos.chandras@imgtec.com>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
>>   package/libtool/libtool-mips64-n64-linking.patch |   47 ++++++++++++++++++++++
>>   1 files changed, 47 insertions(+), 0 deletions(-)
>>   create mode 100644 package/libtool/libtool-mips64-n64-linking.patch
>
> This looks good, but:
>
>   * The title of your patch should start with "libtool: "
>
>   * You want to name the patch file libtool-0001-<something>.patch, as
>     per http://buildroot.org/downloads/manual/manual.html#patch-policy.
>
> Also, I believe your commit log should mention more precisely which
> problem it is fixing (I guess the most visible one is a build failure
> of libiscsi on MIPS64 n32, I'm sure Markos remembers the details).
>
> Thanks!
>
> Thomas
>
Hi Thomas,

Thanks for the comments. It does not fix anything yet (affected packages 
need to start using AUTORECONF), and the libiscsi is just one of the 
problems so we thought it shouldn't be part of the commit message.

I incorrectly thought that we do not use numbers for patches anymore.

v2 to follow soon!

-- 
markos

  reply	other threads:[~2013-11-18 11:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 10:56 [Buildroot] [PATCH] Apply upstream patch to set correct linkage on MIPS64 Vicente Olivert Riera
2013-11-18 11:06 ` Thomas Petazzoni
2013-11-18 11:12   ` Markos Chandras [this message]
2013-11-18 11:17     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5289F60D.7000805@imgtec.com \
    --to=markos.chandras@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox