Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [autobuild.buildroot.net] Build results for 2013-11-22
Date: Sat, 23 Nov 2013 18:37:21 +0100	[thread overview]
Message-ID: <20131123183721.071bcfa1@skate> (raw)
In-Reply-To: <CAAXf6LWcrN+nGz+M=Gi4UMmvgeXB3c5BSooQNwZ=v7dcoT+4NA@mail.gmail.com>

Dear Thomas De Schampheleire,

On Sat, 23 Nov 2013 16:09:40 +0100, Thomas De Schampheleire wrote:

> The udisks problem is the following: the configuration requests lvm2
> support in udisks, which causes:
> select BR2_PACKAGE_LVM2_APP_LIBRARY
> The configuration also has BR2_PACKAGE_LVM2_DMSETUP_ONLY selected.
> The problem is that both are not supposed to be configured together:
> 
> config BR2_PACKAGE_LVM2_DMSETUP_ONLY
>         bool "install dmsetup only"
>         depends on BR2_PACKAGE_LVM2
>         help
>           Install dmsetup only and skip the LVM2 suite.
> 
> config BR2_PACKAGE_LVM2_APP_LIBRARY
>         bool "install application library"
>         depends on BR2_PACKAGE_LVM2
>         depends on !BR2_PACKAGE_LVM2_DMSETUP_ONLY
>         help
>           Install application library (liblvm2app)
> 
> In the configuration menu, it seems you can indeed create such an
> invalid configuration: start with LVM2_DMSETUP_ONLY selected, then
> enable udisks with lvm2 support. If you save, you get a .config that
> has:
> 
> $ grep LVM .config
> BR2_PACKAGE_LVM2=y
> BR2_PACKAGE_LVM2_DMSETUP_ONLY=y
> BR2_PACKAGE_LVM2_APP_LIBRARY=y
> BR2_PACKAGE_UDISKS_LVM2=y
> 
> Because DMSETUP_ONLY is setup, the install command does not install
> the lvm2app, which is needed for udisks.
> 
> This could be solved by adding 'depends on
> !BR2_PACKAGE_LVM2_DMSETUP_ONLY' to the option BR2_PACKAGE_UDISKS_LVM2,
> so that you cannot enable lvm2 support in udisks if DMSETUP_ONLY is
> selected.
> However, is there a better solution? I tried 'select
> !BR2_PACKAGE_LVM2_DMSETUP_ONLY' to explicitly turn off DMSETUP_ONLY
> when lvm2 support is requested, but this seems invalid.

Thanks for the investigation!

I unfortunately don't have a good knowledge of the various components
inside LVM2. However, what surprises me here is to have an option
called 'install this thing *only*'. Options should only install
something *more* but not exclude other options. So I believe the right
way of solving this problem is to remove the "only" aspect of this
option, and rethink completely the set of sub-options offered for the
lvm2 package. People wanting to install only dmsetup will just have to
enable only one specific sub-option, and that's it. But it shouldn't
prevent another package from requesting the library or other
applications to be installed.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2013-11-23 17:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-23  7:30 [Buildroot] [autobuild.buildroot.net] Build results for 2013-11-22 Thomas Petazzoni
2013-11-23 13:11 ` Thomas De Schampheleire
2013-11-23 15:09   ` Thomas De Schampheleire
2013-11-23 17:37     ` Thomas Petazzoni [this message]
2013-11-23 23:50       ` [Buildroot] [PATCH] lvm2: replace !BR2_PACKAGE_LVM2_DMSETUP_ONLY by BR2_PACKAGE_LVM2_FULL_SUITE Arnout Vandecappelle
2013-11-25  9:46         ` Thomas De Schampheleire
2013-11-25 11:02           ` Arnout Vandecappelle
2013-11-25 15:10             ` Thomas De Schampheleire
2013-11-25 15:35               ` Arnout Vandecappelle
2013-11-25 15:39                 ` Arnout Vandecappelle
2013-11-25 15:51                 ` Thomas De Schampheleire
2013-11-25 16:06                   ` Arnout Vandecappelle
2013-11-25 21:21             ` Thomas De Schampheleire
2013-11-28  7:13               ` Arnout Vandecappelle
2013-11-28 10:54                 ` Thomas De Schampheleire
2013-11-23 17:26   ` [Buildroot] [autobuild.buildroot.net] Build results for 2013-11-22 Thomas Petazzoni
2013-11-25  9:26     ` Thomas De Schampheleire
2013-11-25  9:35       ` Thomas Petazzoni
2013-11-23 20:17   ` Baruch Siach
2013-11-25  9:25     ` Thomas De Schampheleire
2013-11-23 20:38 ` Romain Naour
2013-11-23 21:22   ` Yann E. MORIN
2013-11-23 21:34     ` Yann E. MORIN
2013-11-23 23:15   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131123183721.071bcfa1@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox