[Buildroot] [PATCH] lvm2: replace !BR2_PACKAGE_LVM2_DMSETUP_ONLY by BR2_PACKAGE_LVM2_FULL_SUITE

[Arnout Vandecappelle <arnout@mind.be>]

On 25/11/13 16:51, Thomas De Schampheleire wrote:
> On Mon, Nov 25, 2013 at 4:35 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
>> On 25/11/13 16:10, Thomas De Schampheleire wrote:
> [..]
>>>
>>>
>>> How 'large' is this application library? In this particular
>>> configuration it is 810K (liblvm2app.so). Is it acceptable to include
>>> it always in the 'full suite' (and thus remove the option
>>> BR2_PACKAGE_LVM2_APP_LIBRARY)?
>>
>>
>>   To help answer that question, on my x86_64 glibc build:
>>
>> 3.0M    /tmp/lvm2-app-library
>> 2.1M    /tmp/lvm2-full-suite
>> 472K    /tmp/lvm2-minimal
>>
>>
>>   So the app library adds another 40% to the package size. I guess that's
>> significant enough not to remove the existing option. Especially because the
>> only reason is that we can't find a better name for it :-)
>>
>>   My original name was "install all binaries", but I found that less
>> descriptive than "full suite". Maybe "install all LVM2 programs"?
>
> It's more than just programs, right? The default SUBDIRS includes some
> libraries too:
> SUBDIRS = conf daemons include lib libdaemon libdm man scripts tools

  I looked at what is actually installed: the only library is 
libdevmapper. So I guess libdaemon is linked statically.

>
> Maybe we should add 'default' in the name somewhere, as what it
> installed is the set of programs/libraries/headers that are installed
> by default by 'make install'. The APPLIB option then additionally
> passes an extra request to configure. So for example:
> BR2_PACKAGE_LVM2_DEFAULT_INSTALL
> BR2_PACKAGE_LVM2_DEFAULT_SUITE
> BR2_PACKAGE_LVM2_NOT_ONLY_DEVICEMAPPER ;-)
> ...
>
>>
>>   I could also copy the full list (which is in the .mk file) to the help
>> text.
>
> That list is only used for the uninstall, so are we sure that it is up-to-date?

  I can put the up-to-date list there for the moment, but of course we 
will not be sure in the future.

  Regards,
  Arnout

>
>
> Best regards,
> Thomas
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F