* [Buildroot] [PATCH] poco: fix sh4a fenv build failure
@ 2013-11-25 16:47 Baruch Siach
2013-11-25 17:11 ` Thomas Petazzoni
2013-11-26 11:41 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Baruch Siach @ 2013-11-25 16:47 UTC (permalink / raw)
To: buildroot
Disable FP environment on sh4a. Fixes
http://autobuild.buildroot.net/results/8dc9bca5969d455cc30206fc1ae6e1d3ba6eb6ca/.
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/poco/poco.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/poco/poco.mk b/package/poco/poco.mk
index a18f209..3516c04 100644
--- a/package/poco/poco.mk
+++ b/package/poco/poco.mk
@@ -34,6 +34,11 @@ ifeq ($(LIBC),uclibc)
POCO_CONF_OPT += --no-fpenvironment --no-wstring
endif
+# sh4a is missing FE_DOWNWARD and FE_UPWARD in its fenv.h
+ifeq ($(BR2_sh4a),y)
+POCO_CONF_OPT += --no-fpenvironment
+endif
+
define POCO_CONFIGURE_CMDS
(cd $(@D); ./configure \
--config=Linux-CrossEnv \
--
1.8.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] poco: fix sh4a fenv build failure
2013-11-25 16:47 [Buildroot] [PATCH] poco: fix sh4a fenv build failure Baruch Siach
@ 2013-11-25 17:11 ` Thomas Petazzoni
2013-11-25 18:38 ` Baruch Siach
2013-11-26 11:41 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2013-11-25 17:11 UTC (permalink / raw)
To: buildroot
Dear Baruch Siach,
On Mon, 25 Nov 2013 18:47:28 +0200, Baruch Siach wrote:
> Disable FP environment on sh4a. Fixes
> http://autobuild.buildroot.net/results/8dc9bca5969d455cc30206fc1ae6e1d3ba6eb6ca/.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/poco/poco.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/poco/poco.mk b/package/poco/poco.mk
> index a18f209..3516c04 100644
> --- a/package/poco/poco.mk
> +++ b/package/poco/poco.mk
> @@ -34,6 +34,11 @@ ifeq ($(LIBC),uclibc)
> POCO_CONF_OPT += --no-fpenvironment --no-wstring
> endif
>
> +# sh4a is missing FE_DOWNWARD and FE_UPWARD in its fenv.h
> +ifeq ($(BR2_sh4a),y)
> +POCO_CONF_OPT += --no-fpenvironment
> +endif
Just curious, is this (the fact that SH4 fenv.h lacks some definitions)
something specific to uClibc, or something that is also true for
glibc/eglibc?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] poco: fix sh4a fenv build failure
2013-11-25 17:11 ` Thomas Petazzoni
@ 2013-11-25 18:38 ` Baruch Siach
0 siblings, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2013-11-25 18:38 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Mon, Nov 25, 2013 at 06:11:21PM +0100, Thomas Petazzoni wrote:
> Dear Baruch Siach,
>
> On Mon, 25 Nov 2013 18:47:28 +0200, Baruch Siach wrote:
> > Disable FP environment on sh4a. Fixes
> > http://autobuild.buildroot.net/results/8dc9bca5969d455cc30206fc1ae6e1d3ba6eb6ca/.
> >
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > package/poco/poco.mk | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/package/poco/poco.mk b/package/poco/poco.mk
> > index a18f209..3516c04 100644
> > --- a/package/poco/poco.mk
> > +++ b/package/poco/poco.mk
> > @@ -34,6 +34,11 @@ ifeq ($(LIBC),uclibc)
> > POCO_CONF_OPT += --no-fpenvironment --no-wstring
> > endif
> >
> > +# sh4a is missing FE_DOWNWARD and FE_UPWARD in its fenv.h
> > +ifeq ($(BR2_sh4a),y)
> > +POCO_CONF_OPT += --no-fpenvironment
> > +endif
>
> Just curious, is this (the fact that SH4 fenv.h lacks some definitions)
> something specific to uClibc, or something that is also true for
> glibc/eglibc?
This also affects (e)glibc. See
http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/70784.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] poco: fix sh4a fenv build failure
2013-11-25 16:47 [Buildroot] [PATCH] poco: fix sh4a fenv build failure Baruch Siach
2013-11-25 17:11 ` Thomas Petazzoni
@ 2013-11-26 11:41 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2013-11-26 11:41 UTC (permalink / raw)
To: buildroot
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> Disable FP environment on sh4a. Fixes
> http://autobuild.buildroot.net/results/8dc9bca5969d455cc30206fc1ae6e1d3ba6eb6ca/.
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-26 11:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-25 16:47 [Buildroot] [PATCH] poco: fix sh4a fenv build failure Baruch Siach
2013-11-25 17:11 ` Thomas Petazzoni
2013-11-25 18:38 ` Baruch Siach
2013-11-26 11:41 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox