* [Buildroot] [PATCH] grub: force -m32 so we build grub 32 bits on 64 bits architecture
@ 2013-12-04 19:33 Thomas Petazzoni
2013-12-04 19:39 ` Baruch Siach
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2013-12-04 19:33 UTC (permalink / raw)
To: buildroot
As reported by Matthew Weber, Grub doesn't build on 64 bits build
machines, because the host compiler produces 64 bits binaries by
default, while Grub should be built 32 bits. Therefore, this commit
passes -m32 to the Grub CFLAGS, so that 32 bits binaries are always
produced.
Reported-by: Matthew Weber <mlweber1@rockwellcollins.com>
Cc: Matthew Weber <mlweber1@rockwellcollins.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
boot/grub/grub.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/boot/grub/grub.mk b/boot/grub/grub.mk
index 6ba02cd..eb066af 100644
--- a/boot/grub/grub.mk
+++ b/boot/grub/grub.mk
@@ -70,7 +70,7 @@ GRUB_POST_PATCH_HOOKS += GRUB_DEBIAN_PATCHES
GRUB_CONF_ENV = \
$(HOST_CONFIGURE_OPTS) \
- CFLAGS="$(HOST_CFLAGS) $(GRUB_CFLAGS)"
+ CFLAGS="$(HOST_CFLAGS) $(GRUB_CFLAGS) -m32"
GRUB_CONF_OPT = \
--disable-auto-linux-mem-opt \
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] grub: force -m32 so we build grub 32 bits on 64 bits architecture
2013-12-04 19:33 [Buildroot] [PATCH] grub: force -m32 so we build grub 32 bits on 64 bits architecture Thomas Petazzoni
@ 2013-12-04 19:39 ` Baruch Siach
2013-12-04 19:43 ` Matthew Weber
2013-12-04 21:04 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2013-12-04 19:39 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Wed, Dec 04, 2013 at 08:33:50PM +0100, Thomas Petazzoni wrote:
> As reported by Matthew Weber, Grub doesn't build on 64 bits build
> machines, because the host compiler produces 64 bits binaries by
> default, while Grub should be built 32 bits. Therefore, this commit
> passes -m32 to the Grub CFLAGS, so that 32 bits binaries are always
> produced.
>
> Reported-by: Matthew Weber <mlweber1@rockwellcollins.com>
> Cc: Matthew Weber <mlweber1@rockwellcollins.com>
For some reason Matthew does not appear on the Cc list. Added now. Shouldn't
git send-email do this automatically?
baruch
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> boot/grub/grub.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/boot/grub/grub.mk b/boot/grub/grub.mk
> index 6ba02cd..eb066af 100644
> --- a/boot/grub/grub.mk
> +++ b/boot/grub/grub.mk
> @@ -70,7 +70,7 @@ GRUB_POST_PATCH_HOOKS += GRUB_DEBIAN_PATCHES
>
> GRUB_CONF_ENV = \
> $(HOST_CONFIGURE_OPTS) \
> - CFLAGS="$(HOST_CFLAGS) $(GRUB_CFLAGS)"
> + CFLAGS="$(HOST_CFLAGS) $(GRUB_CFLAGS) -m32"
>
> GRUB_CONF_OPT = \
> --disable-auto-linux-mem-opt \
> --
> 1.8.1.2
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] grub: force -m32 so we build grub 32 bits on 64 bits architecture
2013-12-04 19:33 [Buildroot] [PATCH] grub: force -m32 so we build grub 32 bits on 64 bits architecture Thomas Petazzoni
2013-12-04 19:39 ` Baruch Siach
@ 2013-12-04 19:43 ` Matthew Weber
2013-12-04 21:04 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Matthew Weber @ 2013-12-04 19:43 UTC (permalink / raw)
To: buildroot
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote on 12/04/2013
01:33:50 PM:
> From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> To: buildroot at uclibc.org
> Cc: Matthew Weber <mlweber1@rockwellcollins.com>
> Date: 12/04/2013 01:33 PM
> Subject: [PATCH] grub: force -m32 so we build grub 32 bits on 64
> bits architecture
>
> As reported by Matthew Weber, Grub doesn't build on 64 bits build
> machines, because the host compiler produces 64 bits binaries by
> default, while Grub should be built 32 bits. Therefore, this commit
> passes -m32 to the Grub CFLAGS, so that 32 bits binaries are always
> produced.
>
> Reported-by: Matthew Weber <mlweber1@rockwellcollins.com>
> Cc: Matthew Weber <mlweber1@rockwellcollins.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: Matthew Weber <mlweber1@rockwellcollins.com>
Thanks Thomas!
> ---
> boot/grub/grub.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/boot/grub/grub.mk b/boot/grub/grub.mk
> index 6ba02cd..eb066af 100644
> --- a/boot/grub/grub.mk
> +++ b/boot/grub/grub.mk
> @@ -70,7 +70,7 @@ GRUB_POST_PATCH_HOOKS += GRUB_DEBIAN_PATCHES
>
> GRUB_CONF_ENV = \
> $(HOST_CONFIGURE_OPTS) \
> - CFLAGS="$(HOST_CFLAGS) $(GRUB_CFLAGS)"
> + CFLAGS="$(HOST_CFLAGS) $(GRUB_CFLAGS) -m32"
>
> GRUB_CONF_OPT = \
> --disable-auto-linux-mem-opt \
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] grub: force -m32 so we build grub 32 bits on 64 bits architecture
2013-12-04 19:33 [Buildroot] [PATCH] grub: force -m32 so we build grub 32 bits on 64 bits architecture Thomas Petazzoni
2013-12-04 19:39 ` Baruch Siach
2013-12-04 19:43 ` Matthew Weber
@ 2013-12-04 21:04 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2013-12-04 21:04 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> As reported by Matthew Weber, Grub doesn't build on 64 bits build
> machines, because the host compiler produces 64 bits binaries by
> default, while Grub should be built 32 bits. Therefore, this commit
> passes -m32 to the Grub CFLAGS, so that 32 bits binaries are always
> produced.
> Reported-by: Matthew Weber <mlweber1@rockwellcollins.com>
> Cc: Matthew Weber <mlweber1@rockwellcollins.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-04 21:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-04 19:33 [Buildroot] [PATCH] grub: force -m32 so we build grub 32 bits on 64 bits architecture Thomas Petazzoni
2013-12-04 19:39 ` Baruch Siach
2013-12-04 19:43 ` Matthew Weber
2013-12-04 21:04 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox