[Buildroot] [PATCH 1/4] mention nconfig

[Buildroot] [PATCH 1/4] mention nconfig

[Shawn Landden]

Signed-off-by: Shawn Landden <shawn@churchofgit.com>
---
 docs/manual/common-usage.txt |  2 +-
 docs/manual/using.txt        | 10 ++++++++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/docs/manual/common-usage.txt b/docs/manual/common-usage.txt
index c7f511a..1290dfc 100644
--- a/docs/manual/common-usage.txt
+++ b/docs/manual/common-usage.txt
@@ -11,7 +11,7 @@ Offline builds
 
 If you intend to do an offline build and just want to download
 all sources that you previously selected in the configurator
-('menuconfig', 'xconfig' or 'gconfig'), then issue:
+('menuconfig', 'nconfig', 'xconfig' or 'gconfig'), then issue:
 
 --------------------
  $ make source
diff --git a/docs/manual/using.txt b/docs/manual/using.txt
index de29ad6..9b0a81f 100644
--- a/docs/manual/using.txt
+++ b/docs/manual/using.txt
@@ -15,7 +15,13 @@ assistant:
  $ make menuconfig
 --------------------
 
-to run the curses-based configurator, or
+or
+
+--------------------
+ $ make nconfig
+--------------------
+
+to run the old or new curses-based configurator, or
 
 --------------------
  $ make xconfig
@@ -105,7 +111,7 @@ This directory contains several subdirectories:
 * +toolchain/+ contains the build directories for the various
   components of the cross-compilation toolchain.
 
-These commands, +make menuconfig|gconfig|xconfig+ and +make+, are the
+These commands, +make menuconfig|nconfig|gconfig|xconfig+ and +make+, are the
 basic ones that allow to easily and quickly generate images fitting
 your needs, with all the supports and applications you enabled.
 
-- 
1.8.5.1

[Buildroot] [PATCH 2/4] util-linux: nsenter

[Shawn Landden]

Signed-off-by: Shawn Landden <shawn@churchofgit.com>
---
 package/util-linux/Config.in     | 5 +++++
 package/util-linux/util-linux.mk | 1 +
 2 files changed, 6 insertions(+)

diff --git a/package/util-linux/Config.in b/package/util-linux/Config.in
index 8c8fd7a..c8d31ac 100644
--- a/package/util-linux/Config.in
+++ b/package/util-linux/Config.in
@@ -106,6 +106,11 @@ config BR2_PACKAGE_UTIL_LINUX_MOUNT
 	help
 	  Mount/unmount filesystems
 
+config BR2_PACKAGE_UTIL_LINUX_NSENTER
+        bool "nsenter"
+        help
+          Enter namespaces (setns(2) frontend)
+
 config BR2_PACKAGE_UTIL_LINUX_PIVOT_ROOT
 	bool "pivot_root"
 	help
diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
index 20b3d35..af9d7c8 100644
--- a/package/util-linux/util-linux.mk
+++ b/package/util-linux/util-linux.mk
@@ -62,6 +62,7 @@ UTIL_LINUX_CONF_OPT += \
 	$(if $(BR2_PACKAGE_UTIL_LINUX_LOGIN_UTILS),--enable-last --enable-login --enable-su --enable-sulogin,--disable-last --disable-login --disable-su --disable-sulogin) \
 	$(if $(BR2_PACKAGE_UTIL_LINUX_MESG),--enable-mesg,--disable-mesg) \
 	$(if $(BR2_PACKAGE_UTIL_LINUX_MOUNT),--enable-mount,--disable-mount) \
+        $(if $(BR2_PACKAGE_UTIL_LINUX_NSENTER),--enable-nsenter,--disable-nsenter) \
 	$(if $(BR2_PACKAGE_UTIL_LINUX_PARTX),,--disable-partx) \
 	$(if $(BR2_PACKAGE_UTIL_LINUX_PIVOT_ROOT),--enable-pivot_root,--disable-pivot_root) \
 	$(if $(BR2_PACKAGE_UTIL_LINUX_RAW),--enable-raw,--disable-raw) \
-- 
1.8.5.1

[Buildroot] [PATCH 3/4] systemd does not require glib

[Shawn Landden]

Signed-off-by: Shawn Landden <shawn@churchofgit.com>
---
 docs/manual/configure.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/manual/configure.txt b/docs/manual/configure.txt
index 8912a81..89df3d9 100644
--- a/docs/manual/configure.txt
+++ b/docs/manual/configure.txt
@@ -371,7 +371,7 @@ can be chosen from +System configuration+, +Init system+:
    etc. +systemd+ will be useful on relatively complex embedded
    systems, for example the ones requiring D-Bus and services
    communicating between each other. It is worth noting that +systemd+
-   brings a fairly big number of large dependencies: +dbus+, +glib+
+   brings a fairly big number of large dependencies: +dbus+, +udev+
    and more. For more details about +systemd+, see
    http://www.freedesktop.org/wiki/Software/systemd.
 
-- 
1.8.5.1

[Buildroot] [PATCH 4/4] systemd: uclibc now has posix_fallocate()

[Shawn Landden]

uClibc commit 5643900913f64c00f1c29589145

Signed-off-by: Shawn Landden <shawn@churchofgit.com>
---
 package/systemd/systemd-uclibc-fix.patch | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/package/systemd/systemd-uclibc-fix.patch b/package/systemd/systemd-uclibc-fix.patch
index 9a20845..08a5d3d 100644
--- a/package/systemd/systemd-uclibc-fix.patch
+++ b/package/systemd/systemd-uclibc-fix.patch
@@ -39,21 +39,3 @@ Index: systemd-44/src/macro.h
  #define _printf_attr_(a,b) __attribute__ ((format (printf, a, b)))
  #define _sentinel_ __attribute__ ((sentinel))
  #define _noreturn_ __attribute__((noreturn))
-Index: systemd-44/src/journal/journal-file.c
-===================================================================
---- systemd-44.orig/src/journal/journal-file.c
-+++ systemd-44/src/journal/journal-file.c
-@@ -229,11 +229,13 @@
-                 }
-         }
- 
-+#ifndef __UCLIBC__
-         /* Note that the glibc fallocate() fallback is very
-            inefficient, hence we try to minimize the allocation area
-            as we can. */
-         if (posix_fallocate(f->fd, old_size, new_size - old_size) < 0)
-                 return -errno;
-+#endif
- 
-         if (fstat(f->fd, &f->last_stat) < 0)
-                 return -errno;
-- 
1.8.5.1

[Buildroot] [PATCH 1/4] mention nconfig

[Peter Korsgaard]

>>>>> "Shawn" == Shawn Landden <shawn@churchofgit.com> writes:

 > Signed-off-by: Shawn Landden <shawn@churchofgit.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 3/4] systemd does not require glib

[Thomas De Schampheleire]

On Mon, Dec 9, 2013 at 1:07 AM, Shawn Landden <shawn@churchofgit.com> wrote:
> Signed-off-by: Shawn Landden <shawn@churchofgit.com>
> ---
>  docs/manual/configure.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/manual/configure.txt b/docs/manual/configure.txt
> index 8912a81..89df3d9 100644
> --- a/docs/manual/configure.txt
> +++ b/docs/manual/configure.txt
> @@ -371,7 +371,7 @@ can be chosen from +System configuration+, +Init system+:
>     etc. +systemd+ will be useful on relatively complex embedded
>     systems, for example the ones requiring D-Bus and services
>     communicating between each other. It is worth noting that +systemd+
> -   brings a fairly big number of large dependencies: +dbus+, +glib+
> +   brings a fairly big number of large dependencies: +dbus+, +udev+
>     and more. For more details about +systemd+, see
>     http://www.freedesktop.org/wiki/Software/systemd.

Reviewed-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

[Buildroot] [PATCH 4/4] systemd: uclibc now has posix_fallocate()

[Thomas De Schampheleire]

Hi,

On Mon, Dec 9, 2013 at 1:07 AM, Shawn Landden <shawn@churchofgit.com> wrote:
> uClibc commit 5643900913f64c00f1c29589145
>
> Signed-off-by: Shawn Landden <shawn@churchofgit.com>
> ---
>  package/systemd/systemd-uclibc-fix.patch | 18 ------------------
>  1 file changed, 18 deletions(-)
>
> diff --git a/package/systemd/systemd-uclibc-fix.patch b/package/systemd/systemd-uclibc-fix.patch
> index 9a20845..08a5d3d 100644
> --- a/package/systemd/systemd-uclibc-fix.patch
> +++ b/package/systemd/systemd-uclibc-fix.patch
> @@ -39,21 +39,3 @@ Index: systemd-44/src/macro.h
>   #define _printf_attr_(a,b) __attribute__ ((format (printf, a, b)))
>   #define _sentinel_ __attribute__ ((sentinel))
>   #define _noreturn_ __attribute__((noreturn))
> -Index: systemd-44/src/journal/journal-file.c
> -===================================================================
> ---- systemd-44.orig/src/journal/journal-file.c
> -+++ systemd-44/src/journal/journal-file.c
> -@@ -229,11 +229,13 @@
> -                 }
> -         }
> -
> -+#ifndef __UCLIBC__
> -         /* Note that the glibc fallocate() fallback is very
> -            inefficient, hence we try to minimize the allocation area
> -            as we can. */
> -         if (posix_fallocate(f->fd, old_size, new_size - old_size) < 0)
> -                 return -errno;
> -+#endif
> -
> -         if (fstat(f->fd, &f->last_stat) < 0)
> -                 return -errno;
> --

This clearly requires a toolchain with a sufficiently recent uClibc.
I'm not familiar with our strategy here, so I'm adding ThomasP to this
thread...

Best regards,
Thomas

[Buildroot] [PATCH 2/4] util-linux: nsenter

[Peter Korsgaard]

>>>>> "Shawn" == Shawn Landden <shawn@churchofgit.com> writes:

The commit message could have been a bit longer, but OK.

 > Signed-off-by: Shawn Landden <shawn@churchofgit.com>

 > ---
 >  package/util-linux/Config.in     | 5 +++++
 >  package/util-linux/util-linux.mk | 1 +
 >  2 files changed, 6 insertions(+)

 > diff --git a/package/util-linux/Config.in b/package/util-linux/Config.in
 > index 8c8fd7a..c8d31ac 100644
 > --- a/package/util-linux/Config.in
 > +++ b/package/util-linux/Config.in
 > @@ -106,6 +106,11 @@ config BR2_PACKAGE_UTIL_LINUX_MOUNT
 >  	help
 >  	  Mount/unmount filesystems
 
 > +config BR2_PACKAGE_UTIL_LINUX_NSENTER
 > +        bool "nsenter"
 > +        help
 > +          Enter namespaces (setns(2) frontend)
 > +

Config.in indentation should be with <tab> (and the help lines
<tab><space><space>)

 >  config BR2_PACKAGE_UTIL_LINUX_PIVOT_ROOT
 >  	bool "pivot_root"
 >  	help
 > diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
 > index 20b3d35..af9d7c8 100644
 > --- a/package/util-linux/util-linux.mk
 > +++ b/package/util-linux/util-linux.mk
 > @@ -62,6 +62,7 @@ UTIL_LINUX_CONF_OPT += \
 >  	$(if $(BR2_PACKAGE_UTIL_LINUX_LOGIN_UTILS),--enable-last --enable-login --enable-su --enable-sulogin,--disable-last --disable-login --disable-su --disable-sulogin) \
 >  	$(if $(BR2_PACKAGE_UTIL_LINUX_MESG),--enable-mesg,--disable-mesg) \
 >  	$(if $(BR2_PACKAGE_UTIL_LINUX_MOUNT),--enable-mount,--disable-mount) \
 > +        $(if $(BR2_PACKAGE_UTIL_LINUX_NSENTER),--enable-nsenter,--disable-nsenter) \

Same here, the other lines around it use <tab>.

Committed with those fixes, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 3/4] systemd does not require glib

[Peter Korsgaard]

>>>>> "Shawn" == Shawn Landden <shawn@churchofgit.com> writes:

 > Signed-off-by: Shawn Landden <shawn@churchofgit.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 4/4] systemd: uclibc now has posix_fallocate()

[Thomas Petazzoni]

Thomas, Shawn,

On Mon, 9 Dec 2013 09:27:48 +0100, Thomas De Schampheleire wrote:

> This clearly requires a toolchain with a sufficiently recent uClibc.
> I'm not familiar with our strategy here, so I'm adding ThomasP to this
> thread...

My current strategy is to finish reviewing the eudev/systemd patches
from Eric, and get them merged. They upgrade systemd, and make it
depend on glibc, since it uses many glibc-isms.

If people are unhappy with systemd being only available on uclibc
systems, then they should either:

 1/ Improve uClibc so that it provides the necessary glibc-isms, and
 make sure that the uClibc project is sufficiently alive to provide
 releases at a decent frequency (which it has failed to do for the last
 few years). I personally consider the uClibc project as mostly dead,
 and the best thing I'm wishing for this project is that a fork is
 made, with a more active and reactive community.

 2/ Convince systemd upstream to not use the problematic glibc-isms,
 but I wish them good luck, knowing how upstream considers any system
 that isn't Linux/glibc.

 3/ Realize that when you use systemd, you are already using heavy and
 fat dependencies (think D-Bus and Glib), and that therefore you can
 just as well afford the size of glibc.

In the mean time, if people want to fix systemd 44, then uClibc
compatibility patches should not be *removed* but instead *improved*.
For example, this posix_fallocate() patch should be replaced by a test
in configure.ac, that tests whether the C library does or does not
provide posix_fallocate(), and acts accordingly. That's the good way of
fixing the problem, because it would support both uClibc toolchains
that use official uClibc releases (and therefore don't provide
posix_fallocate()) and uClibc toolchains generated by Buildroot (that
provide posix_fallocate()).

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 4/4] systemd: uclibc now has posix_fallocate()

[Thomas Petazzoni]

Dear Shawn Landden,

On Sun,  8 Dec 2013 16:07:43 -0800, Shawn Landden wrote:
> uClibc commit 5643900913f64c00f1c29589145
> 
> Signed-off-by: Shawn Landden <shawn@churchofgit.com>
> ---
>  package/systemd/systemd-uclibc-fix.patch | 18 ------------------
>  1 file changed, 18 deletions(-)

Thanks, but we have now bumped systemd to version 207, and this new
version caused too much problems with uClibc, so we've made it depend
on (e)glibc. As a consequence, your patch is no longer necessary.

Do not hesitate to let us know if the new systemd version works for you.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com