* [Buildroot] [PATCH] lvm2: disable statical building because it fails @ 2013-12-17 7:02 Fabio Porcedda 2013-12-17 9:11 ` Thomas Petazzoni 0 siblings, 1 reply; 5+ messages in thread From: Fabio Porcedda @ 2013-12-17 7:02 UTC (permalink / raw) To: buildroot Fixes: http://autobuild.buildroot.net/results/b0b/b0b386969459dda9c294f1ccb4927ca225fa6bdd/ Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> --- package/lvm2/Config.in | 1 + 1 file changed, 1 insertion(+) diff --git a/package/lvm2/Config.in b/package/lvm2/Config.in index 5d6209fc1..29b80ee 100644 --- a/package/lvm2/Config.in +++ b/package/lvm2/Config.in @@ -2,6 +2,7 @@ config BR2_PACKAGE_LVM2 bool "lvm2 & device mapper" depends on BR2_LARGEFILE depends on BR2_USE_MMU # needs fork() + depends on !BR2_PREFER_STATIC_LIB # It fails to build statically help This is LVM2, the rewrite of The Linux Logical Volume Manager. LVM supports enterprise level volume management of disk and disk -- 1.8.5 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] lvm2: disable statical building because it fails 2013-12-17 7:02 [Buildroot] [PATCH] lvm2: disable statical building because it fails Fabio Porcedda @ 2013-12-17 9:11 ` Thomas Petazzoni 2013-12-19 10:36 ` Fabio Porcedda 0 siblings, 1 reply; 5+ messages in thread From: Thomas Petazzoni @ 2013-12-17 9:11 UTC (permalink / raw) To: buildroot Dear Fabio Porcedda, On Tue, 17 Dec 2013 08:02:19 +0100, Fabio Porcedda wrote: > Fixes: > http://autobuild.buildroot.net/results/b0b/b0b386969459dda9c294f1ccb4927ca225fa6bdd/ > > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> > --- > package/lvm2/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/lvm2/Config.in b/package/lvm2/Config.in > index 5d6209fc1..29b80ee 100644 > --- a/package/lvm2/Config.in > +++ b/package/lvm2/Config.in > @@ -2,6 +2,7 @@ config BR2_PACKAGE_LVM2 > bool "lvm2 & device mapper" > depends on BR2_LARGEFILE > depends on BR2_USE_MMU # needs fork() > + depends on !BR2_PREFER_STATIC_LIB # It fails to build statically > help > This is LVM2, the rewrite of The Linux Logical Volume Manager. > LVM supports enterprise level volume management of disk and disk Thanks, but you forgot to propagate this new dependency to the reverse dependencies of lvm2, and you forgot to add the corresponding comment. See http://buildroot.org/downloads/manual/manual.html#dependencies-target-toolchain-options. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] lvm2: disable statical building because it fails 2013-12-17 9:11 ` Thomas Petazzoni @ 2013-12-19 10:36 ` Fabio Porcedda 2013-12-19 10:43 ` Thomas Petazzoni 0 siblings, 1 reply; 5+ messages in thread From: Fabio Porcedda @ 2013-12-19 10:36 UTC (permalink / raw) To: buildroot On Tue, Dec 17, 2013 at 10:11 AM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Fabio Porcedda, > > On Tue, 17 Dec 2013 08:02:19 +0100, Fabio Porcedda wrote: >> Fixes: >> http://autobuild.buildroot.net/results/b0b/b0b386969459dda9c294f1ccb4927ca225fa6bdd/ >> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> >> --- >> package/lvm2/Config.in | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/package/lvm2/Config.in b/package/lvm2/Config.in >> index 5d6209fc1..29b80ee 100644 >> --- a/package/lvm2/Config.in >> +++ b/package/lvm2/Config.in >> @@ -2,6 +2,7 @@ config BR2_PACKAGE_LVM2 >> bool "lvm2 & device mapper" >> depends on BR2_LARGEFILE >> depends on BR2_USE_MMU # needs fork() >> + depends on !BR2_PREFER_STATIC_LIB # It fails to build statically >> help >> This is LVM2, the rewrite of The Linux Logical Volume Manager. >> LVM supports enterprise level volume management of disk and disk > > Thanks, but you forgot to propagate this new dependency to the reverse > dependencies of lvm2, and you forgot to add the corresponding comment. > See > http://buildroot.org/downloads/manual/manual.html#dependencies-target-toolchain-options. Ok, thanks, i will send an updated patch. Best regards -- Fabio Porcedda ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] lvm2: disable statical building because it fails 2013-12-19 10:36 ` Fabio Porcedda @ 2013-12-19 10:43 ` Thomas Petazzoni 2013-12-19 13:23 ` Fabio Porcedda 0 siblings, 1 reply; 5+ messages in thread From: Thomas Petazzoni @ 2013-12-19 10:43 UTC (permalink / raw) To: buildroot Dear Fabio Porcedda, On Thu, 19 Dec 2013 11:36:51 +0100, Fabio Porcedda wrote: > > Thanks, but you forgot to propagate this new dependency to the reverse > > dependencies of lvm2, and you forgot to add the corresponding comment. > > See > > http://buildroot.org/downloads/manual/manual.html#dependencies-target-toolchain-options. > > Ok, thanks, i will send an updated patch. Looking more at the problem, isn't it possible to fix the static build of LVM2, rather than preventing LVM2 from being selected in this case? Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] lvm2: disable statical building because it fails 2013-12-19 10:43 ` Thomas Petazzoni @ 2013-12-19 13:23 ` Fabio Porcedda 0 siblings, 0 replies; 5+ messages in thread From: Fabio Porcedda @ 2013-12-19 13:23 UTC (permalink / raw) To: buildroot On Thu, Dec 19, 2013 at 11:43 AM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Fabio Porcedda, > > On Thu, 19 Dec 2013 11:36:51 +0100, Fabio Porcedda wrote: > >> > Thanks, but you forgot to propagate this new dependency to the reverse >> > dependencies of lvm2, and you forgot to add the corresponding comment. >> > See >> > http://buildroot.org/downloads/manual/manual.html#dependencies-target-toolchain-options. >> >> Ok, thanks, i will send an updated patch. > > Looking more at the problem, isn't it possible to fix the static build > of LVM2, rather than preventing LVM2 from being selected in this case? Yes, i've found a way to fix that. First is a fix to buildroot adding: +LVM2_CONF_OPT += --enable-static_link The second one is a bug within lvm2 when using static building. diff --git a/home/fabiopo/tmp/Makefile.in b/output/build/lvm2-2.02.103/libdm/Makefile.in index 7b40bde..bddb0a0 100644 --- a/home/fabiopo/tmp/Makefile.in +++ b/output/build/lvm2-2.02.103/libdm/Makefile.in @@ -40,7 +40,6 @@ endif ifeq ("@STATIC_LINK@", "yes") LIB_STATIC = $(interface)/libdevmapper.a -TARGETS += libdevmapper.a endif LIB_SHARED = $(interface)/libdevmapper.$(LIB_SUFFIX) @@ -65,9 +64,6 @@ device-mapper: all libdevmapper.$(LIB_SUFFIX) libdevmapper.$(LIB_SUFFIX).$(LIB_VERSION): $(LIB_SHARED) $(LN_S) -f $< $@ -libdevmapper.a: $(LIB_STATIC) - $(LN_S) -f $< $@ - I will prepare a patch to fix lvm2 static building. Best regards -- Fabio Porcedda ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-12-19 13:23 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-12-17 7:02 [Buildroot] [PATCH] lvm2: disable statical building because it fails Fabio Porcedda 2013-12-17 9:11 ` Thomas Petazzoni 2013-12-19 10:36 ` Fabio Porcedda 2013-12-19 10:43 ` Thomas Petazzoni 2013-12-19 13:23 ` Fabio Porcedda
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox