From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] evemu: New package. Also adds libevdev.
Date: Thu, 19 Dec 2013 14:46:28 +0100 [thread overview]
Message-ID: <20131219144628.496c6374@skate> (raw)
In-Reply-To: <20131218174050.GA3321@free.fr>
Yann, Andreas,
Yann's comments are good, I'm just going to add one more below.
On Wed, 18 Dec 2013 18:40:50 +0100, Yann E. MORIN wrote:
> Except for those minor nitpicks, it all Looks Good To Me (TM).
Both packages lack the <pkg>_LICENSE and <pkg>_LICENSE_FILES
informations. See the Buildroot manual for details about these
variables.
Also, the libevdev configure.ac script uses PKG_CHECK_MODULES, so the
package should depend on host-pkgconf. Same thing for evemu.
Finally, your packages don't have any toolchain dependency. This might
be correct, but it would be good if you could test the build of both of
those packages with the following initial configurations:
http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-basic.config
http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-full-nothread.config
If it builds fine with both of those toolchain configuration, then
you're good to go. If not, then it means that there are some missing
toolchain dependencies.
Best regards,
Thomas Petazzoni
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2013-12-19 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 14:01 [Buildroot] [PATCH] evemu: New package. Also adds libevdev Andreas Naumann
2013-12-18 17:40 ` Yann E. MORIN
2013-12-19 13:46 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219144628.496c6374@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox