* [Buildroot] [PATCH] evemu: New package. Also adds libevdev.
@ 2013-12-18 14:01 Andreas Naumann
2013-12-18 17:40 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Naumann @ 2013-12-18 14:01 UTC (permalink / raw)
To: buildroot
---
evemu is also available in version v1.2.0, but crosscompile for arm didnt work.
Using v1.0.10 which does compile and work (and is the current Ubuntu version).
package/Config.in | 2 ++
package/evemu/Config.in | 7 +++++++
package/evemu/evemu.mk | 15 +++++++++++++++
package/libevdev/Config.in | 6 ++++++
package/libevdev/libevdev.mk | 15 +++++++++++++++
5 files changed, 45 insertions(+)
create mode 100644 package/evemu/Config.in
create mode 100644 package/evemu/evemu.mk
create mode 100644 package/libevdev/Config.in
create mode 100644 package/libevdev/libevdev.mk
diff --git a/package/Config.in b/package/Config.in
index 3429c0e..87fda51 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -240,6 +240,7 @@ source "package/dvb-apps/Config.in"
source "package/dvbsnoop/Config.in"
source "package/eeprog/Config.in"
source "package/evtest/Config.in"
+source "package/evemu/Config.in"
source "package/fan-ctrl/Config.in"
source "package/flashrom/Config.in"
source "package/fconfig/Config.in"
@@ -602,6 +603,7 @@ source "package/libdaemon/Config.in"
source "package/libelf/Config.in"
source "package/libevent/Config.in"
source "package/libev/Config.in"
+source "package/libevdev/Config.in"
source "package/libffi/Config.in"
source "package/libglib2/Config.in"
source "package/libical/Config.in"
diff --git a/package/evemu/Config.in b/package/evemu/Config.in
new file mode 100644
index 0000000..07b7174
--- /dev/null
+++ b/package/evemu/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_EVEMU
+ bool "evemu"
+ select BR2_PACKAGE_LIBEVDEV
+ help
+ evemu records and replays device descriptions and events
+
+ http://www.freedesktop.org/wiki/Evemu/
diff --git a/package/evemu/evemu.mk b/package/evemu/evemu.mk
new file mode 100644
index 0000000..923d205
--- /dev/null
+++ b/package/evemu/evemu.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# evemu
+#
+################################################################################
+
+EVEMU_VERSION = 1.0.10
+EVEMU_SOURCE = evemu-$(EVEMU_VERSION).tar.gz
+EVEMU_SITE = http://cgit.freedesktop.org/evemu/snapshot
+
+EVEMU_AUTORECONF = YES
+EVEMU_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
+
diff --git a/package/libevdev/Config.in b/package/libevdev/Config.in
new file mode 100644
index 0000000..91dd9db
--- /dev/null
+++ b/package/libevdev/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBEVDEV
+ bool "libevdev"
+ help
+ libevdev is a wrapper library for evdev devices
+
+ http://freedesktop.org/wiki/Software/libevdev/
diff --git a/package/libevdev/libevdev.mk b/package/libevdev/libevdev.mk
new file mode 100644
index 0000000..12b6b11
--- /dev/null
+++ b/package/libevdev/libevdev.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# libevdev
+#
+################################################################################
+
+LIBEVDEV_VERSION = 0.5
+LIBEVDEV_SOURCE = libevdev-$(LIBEVDEV_VERSION).tar.gz
+LIBEVDEV_SITE = http://cgit.freedesktop.org/libevdev/snapshot
+
+LIBEVDEV_AUTORECONF = YES
+LIBEVDEV_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
+
--
1.8.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] evemu: New package. Also adds libevdev.
2013-12-18 14:01 [Buildroot] [PATCH] evemu: New package. Also adds libevdev Andreas Naumann
@ 2013-12-18 17:40 ` Yann E. MORIN
2013-12-19 13:46 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2013-12-18 17:40 UTC (permalink / raw)
To: buildroot
Andreas, All,
On 2013-12-18 15:01 +0100, Andreas Naumann spake thusly:
> ---
>
> evemu is also available in version v1.2.0, but crosscompile for arm didnt work.
> Using v1.0.10 which does compile and work (and is the current Ubuntu version).
Please, provide two patches: one for libevdev, and a second one for
evemu.
> package/Config.in | 2 ++
> package/evemu/Config.in | 7 +++++++
> package/evemu/evemu.mk | 15 +++++++++++++++
> package/libevdev/Config.in | 6 ++++++
> package/libevdev/libevdev.mk | 15 +++++++++++++++
> 5 files changed, 45 insertions(+)
> create mode 100644 package/evemu/Config.in
> create mode 100644 package/evemu/evemu.mk
> create mode 100644 package/libevdev/Config.in
> create mode 100644 package/libevdev/libevdev.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 3429c0e..87fda51 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -240,6 +240,7 @@ source "package/dvb-apps/Config.in"
> source "package/dvbsnoop/Config.in"
> source "package/eeprog/Config.in"
> source "package/evtest/Config.in"
> +source "package/evemu/Config.in"o
Alphabetical order, please: evemu should come before evtest.
[--SNIP--]
> diff --git a/package/evemu/evemu.mk b/package/evemu/evemu.mk
> new file mode 100644
> index 0000000..923d205
> --- /dev/null
> +++ b/package/evemu/evemu.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# evemu
> +#
> +################################################################################
> +
> +EVEMU_VERSION = 1.0.10
> +EVEMU_SOURCE = evemu-$(EVEMU_VERSION).tar.gz
This _SOURCE is not needed, that's the default.
> +EVEMU_SITE = http://cgit.freedesktop.org/evemu/snapshot
> +
> +EVEMU_AUTORECONF = YES
Can you add a comment on why _AUTORECONF is required?
> +EVEMU_INSTALL_STAGING = YES
Why do we need to install it to staging? It's does not look like a
library, so it should not be needed in staging. Otherwise, please add a
comment on why this is needed, since it is not obvious.
> +$(eval $(autotools-package))
> +
Trailing empty line.
[--SNIP--]
> diff --git a/package/libevdev/libevdev.mk b/package/libevdev/libevdev.mk
> new file mode 100644
> index 0000000..12b6b11
> --- /dev/null
> +++ b/package/libevdev/libevdev.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# libevdev
> +#
> +################################################################################
> +
> +LIBEVDEV_VERSION = 0.5
> +LIBEVDEV_SOURCE = libevdev-$(LIBEVDEV_VERSION).tar.gz
Ditto, this _SOURCE is not needed, since it's the default.
> +LIBEVDEV_SITE = http://cgit.freedesktop.org/libevdev/snapshot
> +
> +LIBEVDEV_AUTORECONF = YES
Ditto: explain why _AUTORECONF is needed.
> +LIBEVDEV_INSTALL_STAGING = YES
That one looks logicial sicne it's a library, so needs no explanations.
;-)
> +$(eval $(autotools-package))
> +
Trailing empty line.
Except for those minor nitpicks, it all Looks Good To Me (TM).
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] evemu: New package. Also adds libevdev.
2013-12-18 17:40 ` Yann E. MORIN
@ 2013-12-19 13:46 ` Thomas Petazzoni
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2013-12-19 13:46 UTC (permalink / raw)
To: buildroot
Yann, Andreas,
Yann's comments are good, I'm just going to add one more below.
On Wed, 18 Dec 2013 18:40:50 +0100, Yann E. MORIN wrote:
> Except for those minor nitpicks, it all Looks Good To Me (TM).
Both packages lack the <pkg>_LICENSE and <pkg>_LICENSE_FILES
informations. See the Buildroot manual for details about these
variables.
Also, the libevdev configure.ac script uses PKG_CHECK_MODULES, so the
package should depend on host-pkgconf. Same thing for evemu.
Finally, your packages don't have any toolchain dependency. This might
be correct, but it would be good if you could test the build of both of
those packages with the following initial configurations:
http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-basic.config
http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-full-nothread.config
If it builds fine with both of those toolchain configuration, then
you're good to go. If not, then it means that there are some missing
toolchain dependencies.
Best regards,
Thomas Petazzoni
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-19 13:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-18 14:01 [Buildroot] [PATCH] evemu: New package. Also adds libevdev Andreas Naumann
2013-12-18 17:40 ` Yann E. MORIN
2013-12-19 13:46 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox