[Buildroot] [PATCH 02/29] ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

[Buildroot] [PATCH 02/29] ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

[Noam Camus]

Hi Thomas,
Yes it was intentionality.
I send only the ones that seem to me as generic.
Noam

On Dec 22, 2013 7:41 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
Dear Noam Camus,

On Sun, 22 Dec 2013 17:31:03 +0200, Noam Camus wrote:
> fix 2 issues:
> 1) need to set .config, which normally it is at post patch hook
> 2) need to rsync *.old directories/files excluded by --cvs-exclude
>
> Signed-off-by: Noam Camus <noamc@ezchip.com>
> ---
>  package/uclibc/uclibc.mk |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)

You sent five patches to the Buildroot mailing list, but they are part
of a 29 patch series. We did not receive the entire patch series.

Was this intentional?

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 02/29] ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

[Thomas Petazzoni]

Dear Noam Camus,

On Sun, 22 Dec 2013 20:53:30 +0200, Noam Camus wrote:

> Yes it was intentionality.
> I send only the ones that seem to me as generic.

Ah, ok. Done like you did, it looked like a "mistake", as people
normally try to send complete patch series to the list. But anyway,
we'll review your patches.

Thanks!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 02/29] ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

[Noam Camus]

Hi Thomas,

Is there anything I can do to help in applying those commits?

Noam
Note: at the moment only one out of five was applied.
-----Original Message-----
From: Thomas Petazzoni [mailto:thomas.petazzoni at free-electrons.com] 
Sent: Monday, December 23, 2013 9:53 AM
To: Noam Camus
Cc: buildroot at busybox.net
Subject: Re: [Buildroot] [PATCH 02/29] ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

Dear Noam Camus,

On Sun, 22 Dec 2013 20:53:30 +0200, Noam Camus wrote:

> Yes it was intentionality.
> I send only the ones that seem to me as generic.

Ah, ok. Done like you did, it looked like a "mistake", as people normally try to send complete patch series to the list. But anyway, we'll review your patches.

Thanks!

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering http://free-electrons.com

[Buildroot] [PATCH 02/29] ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

[Thomas Petazzoni]

Dear Noam Camus,

On Mon, 17 Feb 2014 08:10:17 +0000, Noam Camus wrote:

> Is there anything I can do to help in applying those commits?
> 
> Noam
> Note: at the moment only one out of five was applied.

Yes, I believe you could resend them, rebased on top of the current
-next branch, in a patch series that only includes those patches (the
fact that you sent only 5 patches, but they were number <something>/29
was quite confusing).

Also, make sure each of your commits has a long enough commit log to
allow reviewers to understand what problem the commit is fixing, and
how the solution works.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 02/29] ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

[Thomas De Schampheleire]

Hi,

On Mon, Feb 17, 2014 at 11:32 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Noam Camus,
>
> On Mon, 17 Feb 2014 08:10:17 +0000, Noam Camus wrote:
>
>> Is there anything I can do to help in applying those commits?
>>
>> Noam
>> Note: at the moment only one out of five was applied.
>
> Yes, I believe you could resend them, rebased on top of the current
> -next branch, in a patch series that only includes those patches (the
> fact that you sent only 5 patches, but they were number <something>/29
> was quite confusing).
>
> Also, make sure each of your commits has a long enough commit log to
> allow reviewers to understand what problem the commit is fixing, and
> how the solution works.

This specific patch 02/29 (uClibc .config) is at least partially
addressed in the meantime, with commit
http://git.buildroot.org/buildroot/commit/?id=a25df76b39863e5d1a4e927696bf83055e8ce244

Best regards,
Thomas

[Buildroot] [PATCH 02/29] ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

[Thomas De Schampheleire]

Hi,

On Mon, Feb 17, 2014 at 11:36 AM, Thomas De Schampheleire
<patrickdepinguin@gmail.com> wrote:
> Hi,
>
> On Mon, Feb 17, 2014 at 11:32 AM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
>> Dear Noam Camus,
>>
>> On Mon, 17 Feb 2014 08:10:17 +0000, Noam Camus wrote:
>>
>>> Is there anything I can do to help in applying those commits?
>>>
>>> Noam
>>> Note: at the moment only one out of five was applied.
>>
>> Yes, I believe you could resend them, rebased on top of the current
>> -next branch, in a patch series that only includes those patches (the
>> fact that you sent only 5 patches, but they were number <something>/29
>> was quite confusing).
>>
>> Also, make sure each of your commits has a long enough commit log to
>> allow reviewers to understand what problem the commit is fixing, and
>> how the solution works.
>
> This specific patch 02/29 (uClibc .config) is at least partially
> addressed in the meantime, with commit
> http://git.buildroot.org/buildroot/commit/?id=a25df76b39863e5d1a4e927696bf83055e8ce244

The second part of this patch should also be fixed now: we no longer
use --cvs-exclude in the rsync step, but have an explicit list of
version-controlled directories to exclude from the rsync. The pattern
*.old is not in the exclusion list, so is copied from the overriden
dir.

I'm therefore marking this patch as Superseded in patchwork.
Do let me know if you think my analysis is not correct.

Best regards,
Thomas

[Buildroot] [PATCH 02/29] ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

[Noam Camus]

fix 2 issues:
1) need to set .config, which normally it is at post patch hook
2) need to rsync *.old directories/files excluded by --cvs-exclude

Signed-off-by: Noam Camus <noamc@ezchip.com>
---
 package/uclibc/uclibc.mk |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk index de9011f..def5388 100644
--- a/package/uclibc/uclibc.mk
+++ b/package/uclibc/uclibc.mk
@@ -457,7 +457,18 @@ define UCLIBC_SETUP_DOT_CONFIG
 		oldconfig
 endef
 
+ifeq ($(UCLIBC_OVERRIDE_SRCDIR),)
 UCLIBC_POST_PATCH_HOOKS += UCLIBC_SETUP_DOT_CONFIG
+else
+
+define UCLIBC_RSYNC_DOT_OLD_FILES
+	rsync -au --cvs-exclude --include core --include "*.old" \
+	$(UCLIBC_OVERRIDE_SRCDIR)/ $(@D)
+endef
+
+UCLIBC_PRE_CONFIGURE_HOOKS += UCLIBC_RSYNC_DOT_OLD_FILES 
+UCLIBC_PRE_CONFIGURE_HOOKS += UCLIBC_SETUP_DOT_CONFIG endif
 
 define UCLIBC_CONFIGURE_CMDS
 	$(MAKE1) -C $(UCLIBC_DIR) \
--
1.7.1

[Buildroot] [PATCH 02/29] ARC: [eznps] support OVERRIDE_SRCDIR feature for uclibc

[Thomas Petazzoni]

Dear Noam Camus,

On Sun, 22 Dec 2013 17:31:03 +0200, Noam Camus wrote:
> fix 2 issues:
> 1) need to set .config, which normally it is at post patch hook
> 2) need to rsync *.old directories/files excluded by --cvs-exclude
> 
> Signed-off-by: Noam Camus <noamc@ezchip.com>
> ---
>  package/uclibc/uclibc.mk |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)

You sent five patches to the Buildroot mailing list, but they are part
of a 29 patch series. We did not receive the entire patch series.

Was this intentional?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com