[Buildroot] [PATCH v3 1/2] qt: Disable QtScript on non-supported platforms

[Buildroot] [PATCH v3 1/2] qt: Disable QtScript on non-supported platforms

[Vicente Olivert Riera]

There is no support for certain platforms in QtScript right now, so 
buildroot upstream suggested to disable the possibility of enabling 
QtScript on those platforms as a quick fix for the 2013.11 release:

   http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html

QtScript doesn't build because it uses JavaScriptCore, so we re-use the
existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists
which platforms are supported by JavaScriptCore in Qt4.

In addition, a proposed fix to add support for MIPS64 has already been
sent to Qt:

   https://bugreports.qt-project.org/browse/QTBUG-35030

Fixes:

   http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/qt/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/package/qt/Config.in b/package/qt/Config.in
index 2651d55..dd2b6d9 100644
--- a/package/qt/Config.in
+++ b/package/qt/Config.in
@@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
 
 config BR2_PACKAGE_QT_SCRIPT
 	bool "Script Module"
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 	default y
 	help
 	  Build the Qt Script module.
-- 
1.7.1

[Buildroot] [PATCH v3 2/2] grantlee: Disable on non-supported platforms

[Vicente Olivert Riera]

This package selects BR2_PACKAGE_QT_SCRIPT which is not supported on 
certain platforms. To prevent this behaviour we use the same solution as 
we applied for BR2_PACKAGE_QT_SCRIPT

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/grantlee/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/package/grantlee/Config.in b/package/grantlee/Config.in
index 84afad2..09ec70c 100644
--- a/package/grantlee/Config.in
+++ b/package/grantlee/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_GRANTLEE
 	bool "grantlee"
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 	select BR2_PACKAGE_QT_STL
 	select BR2_PACKAGE_QT_SCRIPT
 	select BR2_PACKAGE_QT_GUI_MODULE
-- 
1.7.1

[Buildroot] [PATCH v3 2/2] grantlee: Disable on non-supported platforms

[Peter Korsgaard]

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

 > This package selects BR2_PACKAGE_QT_SCRIPT which is not supported on 
 > certain platforms. To prevent this behaviour we use the same solution as 
 > we applied for BR2_PACKAGE_QT_SCRIPT

 > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/2] qt5script: Disable on non-supported platforms

[Vicente Olivert Riera]

Is the same problem as Qt4 QtScript, it doesn't build because it uses
JavaScriptCore, so we re-use the existing
BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists which
platforms are supported by JavaScriptCore.

This is a quick fix. A proposed fix to add support for MIPS64 has
already been sent to Qt:

   https://bugreports.qt-project.org/browse/QTBUG-35191

Fixes:

   http://autobuild.buildroot.net/results/231/231c112a3fc18e6cd7d6d10873e22144525c7280/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/qt5/qt5script/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/package/qt5/qt5script/Config.in b/package/qt5/qt5script/Config.in
index 3c5d60c..8f03e75 100644
--- a/package/qt5/qt5script/Config.in
+++ b/package/qt5/qt5script/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_QT5SCRIPT
 	bool "qt5script"
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 	select BR2_PACKAGE_QT5BASE
 	help
 	  Qt is a cross-platform application and UI framework for
-- 
1.7.1

[Buildroot] [PATCH 1/2] qt5script: Disable on non-supported platforms

[Thomas Petazzoni]

Dear Vicente Olivert Riera,

On Thu, 28 Nov 2013 15:57:16 +0000, Vicente Olivert Riera wrote:
> Is the same problem as Qt4 QtScript, it doesn't build because it uses
> JavaScriptCore, so we re-use the existing
> BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists which
> platforms are supported by JavaScriptCore.
> 
> This is a quick fix. A proposed fix to add support for MIPS64 has
> already been sent to Qt:
> 
>    https://bugreports.qt-project.org/browse/QTBUG-35191
> 
> Fixes:
> 
>    http://autobuild.buildroot.net/results/231/231c112a3fc18e6cd7d6d10873e22144525c7280/
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/qt5/qt5script/Config.in |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/package/qt5/qt5script/Config.in
> b/package/qt5/qt5script/Config.in index 3c5d60c..8f03e75 100644
> --- a/package/qt5/qt5script/Config.in
> +++ b/package/qt5/qt5script/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_QT5SCRIPT
>  	bool "qt5script"
> +	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT

No. Qt5 stuff should not use a symbol that is specific to Qt4, as the
set of architectures supported by Qt4 may be different than the set of
architectures supported by Qt5.

Also, your patch series looks weird: it starts with PATCHv3 1/2 to fix
qt4, then PATCH v3 2/2 to fix grantle, and then in the same thread (so
same patch series), it continues with PATCH 1/2 and PATCH 2/2 for qt5.
Either make separate patch series, or better, just one patch series
with all patches (so PATCHv3 1/4 to PATCHv3 4/4).

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] qt5script: Disable on non-supported platforms

[Thomas Petazzoni]

Dear Vicente Olivert Riera,

On Thu, 28 Nov 2013 15:57:16 +0000, Vicente Olivert Riera wrote:
> Is the same problem as Qt4 QtScript, it doesn't build because it uses
> JavaScriptCore, so we re-use the existing
> BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists which
> platforms are supported by JavaScriptCore.
> 
> This is a quick fix. A proposed fix to add support for MIPS64 has
> already been sent to Qt:
> 
>    https://bugreports.qt-project.org/browse/QTBUG-35191
> 
> Fixes:
> 
>    http://autobuild.buildroot.net/results/231/231c112a3fc18e6cd7d6d10873e22144525c7280/

What is the status of this patch, and the "[PATCH 2/2] qt5quick1:
Disable on non-supported platforms" patch that you sent?

Are they still needed? If so, then it should use a QT5 specific Kconfig
symbol.

Let me know what to do with these patches, so that I can updated their
patchwork status.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 2/2] qt5quick1: Disable on non-supported platforms

[Vicente Olivert Riera]

This package selects BR2_PACKAGE_QT5SCRIPT which is not supported on
certain platforms. To prevent this behaviour we use the same solution as
we applied for BR2_PACKAGE_QT5SCRIPT

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/qt5/qt5quick1/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/package/qt5/qt5quick1/Config.in b/package/qt5/qt5quick1/Config.in
index 9cb97a6..735f552 100644
--- a/package/qt5/qt5quick1/Config.in
+++ b/package/qt5/qt5quick1/Config.in
@@ -12,6 +12,7 @@ config BR2_PACKAGE_QT5QUICK1
 	depends on BR2_PACKAGE_HAS_OPENGL_EGL
 	depends on BR2_PACKAGE_HAS_OPENGL_ES
 	depends on BR2_PACKAGE_QT5JSBACKEND_AVAILABLE
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 	help
 	  Qt is a cross-platform application and UI framework for
 	  developers using C++.
-- 
1.7.1

[Buildroot] [PATCH v3 1/2] qt: Disable QtScript on non-supported platforms

[Peter Korsgaard]

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

 > There is no support for certain platforms in QtScript right now, so 
 > buildroot upstream suggested to disable the possibility of enabling 
 > QtScript on those platforms as a quick fix for the 2013.11 release:

 >    http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html

 > QtScript doesn't build because it uses JavaScriptCore, so we re-use the
 > existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists
 > which platforms are supported by JavaScriptCore in Qt4.

 > In addition, a proposed fix to add support for MIPS64 has already been
 > sent to Qt:

 >    https://bugreports.qt-project.org/browse/QTBUG-35030

 > Fixes:

 >    http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/

 > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard