Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] Makefile: expose 'graph-depends' to generate a graph of the dependency tree
Date: Sat, 28 Dec 2013 12:56:34 +0100	[thread overview]
Message-ID: <20131228115634.GC3373@free.fr> (raw)
In-Reply-To: <20131228124607.193ac484@skate>

Thomas, All,

On 2013-12-28 12:46 +0100, Thomas Petazzoni spake thusly:
> Dear Yann E. MORIN,
> 
> On Sat, 28 Dec 2013 00:12:51 +0100, Yann E. MORIN wrote:
> 
> > +%-graph-depends:
> > +	@install -d $(O)/graphs
> > +	@./support/scripts/graph-depends $(@:-graph-depends=) \
> > +	|dot -Tpdf \
> > +	-o $(O)/graphs/$(@).pdf
> 
> Why isn't that one done in the package infrastructure, i.e in
> pkg-generic.mk ?

For two reasons:
  - to have both graph-depends and %-graph-depends side-by-side, so it
    is easier to update the rules,
  - to limit the number of rules in the Makefile, which is already a bit
    long to parse.

I initially added that in package/pkg-generic.mk:
    $(1)-graph-depends:
        @install -d $(O)/graphs
        @./support/scripts/graph-depends $(1) \
        |dot -Tpdf \
        -o $(O)/graphs/$$(@).pdf

But this adds yet another rule per-package to the Makefile. So for the
reasons above, I decided to move it with graph-depends.

But I don't really care, I can change it back to a per-package rule.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2013-12-28 11:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-27 23:12 [Buildroot] [pull request] Pull request for branch yem/graphs Yann E. MORIN
2013-12-27 23:12 ` [Buildroot] [PATCH 1/4] graph-build-time: generate graphs based on timing data Yann E. MORIN
2013-12-28 15:26   ` Thomas Petazzoni
2013-12-28 15:53     ` Yann E. MORIN
2013-12-27 23:12 ` [Buildroot] [PATCH 2/4] Makefile: expose target 'graph-build' to generate the build-time graphs Yann E. MORIN
2013-12-27 23:12 ` [Buildroot] [PATCH 3/4] Makefile: expose 'graph-depends' to generate a graph of the dependency tree Yann E. MORIN
2013-12-28 11:46   ` Thomas Petazzoni
2013-12-28 11:56     ` Yann E. MORIN [this message]
2013-12-28 12:06       ` Thomas Petazzoni
2013-12-28 12:27         ` Yann E. MORIN
2013-12-28 15:32   ` Thomas Petazzoni
2013-12-27 23:12 ` [Buildroot] [PATCH 4/4] graphs: support generating png graphs Yann E. MORIN
2013-12-28 15:50   ` Thomas Petazzoni
2013-12-29 21:58     ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2013-12-28 17:39 [Buildroot] [PATCH 0/4 v2] Add ability to generate some graphs Yann E. MORIN
2013-12-28 17:39 ` [Buildroot] [PATCH 3/4] Makefile: expose 'graph-depends' to generate a graph of the dependency tree Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131228115634.GC3373@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox