From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] graphs: support generating png graphs
Date: Sat, 28 Dec 2013 16:50:51 +0100 [thread overview]
Message-ID: <20131228165051.5a8ed1e2@skate> (raw)
In-Reply-To: <22105197db33dde1f1cee82511ce9c6d00d86853.1388185918.git.yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Sat, 28 Dec 2013 00:12:52 +0100, Yann E. MORIN wrote:
> @echo ' make V=0|1 - 0 => quiet build (default), 1 => verbose build'
> @echo ' make O=dir - Locate all output files in "dir", including .config'
> @echo ' make GRAPH_ALT=1 - use alternate color-scheme for build-time graphs'
> + @echo ' make GRAPH_OUT=pdf|png - generate either pdf (default) or png graphs'
I'm a little bit concerned about these variables. They are specific to
the graph-build-time thing, but still they clutter the 'make help'
output, just for some very special functionality.
Since it's quite specific, shouldn't we just document them in the
manual instead, and keep only the graph-build target in make help?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-12-28 15:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-27 23:12 [Buildroot] [pull request] Pull request for branch yem/graphs Yann E. MORIN
2013-12-27 23:12 ` [Buildroot] [PATCH 1/4] graph-build-time: generate graphs based on timing data Yann E. MORIN
2013-12-28 15:26 ` Thomas Petazzoni
2013-12-28 15:53 ` Yann E. MORIN
2013-12-27 23:12 ` [Buildroot] [PATCH 2/4] Makefile: expose target 'graph-build' to generate the build-time graphs Yann E. MORIN
2013-12-27 23:12 ` [Buildroot] [PATCH 3/4] Makefile: expose 'graph-depends' to generate a graph of the dependency tree Yann E. MORIN
2013-12-28 11:46 ` Thomas Petazzoni
2013-12-28 11:56 ` Yann E. MORIN
2013-12-28 12:06 ` Thomas Petazzoni
2013-12-28 12:27 ` Yann E. MORIN
2013-12-28 15:32 ` Thomas Petazzoni
2013-12-27 23:12 ` [Buildroot] [PATCH 4/4] graphs: support generating png graphs Yann E. MORIN
2013-12-28 15:50 ` Thomas Petazzoni [this message]
2013-12-29 21:58 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2013-12-28 17:39 [Buildroot] [PATCH 0/4 v2] Add ability to generate some graphs Yann E. MORIN
2013-12-28 17:39 ` [Buildroot] [PATCH 4/4] graphs: support generating png graphs Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131228165051.5a8ed1e2@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox