[Buildroot] [PATCH 0/3] xtensa build fixes using -mtext-section-literal

[Buildroot] [PATCH 0/3] xtensa build fixes using -mtext-section-literal

[Baruch Siach]

These fixes are all similar. As the helpful linker error message says, xtensa 
needs -mtext-section-literal when building too large 
objects/libraries/binaries. So just do as we are told to.

Baruch Siach (3):
  php: fix build for xtensa
  lmbench: fix build for xtensa
  civetweb: fix build for xtensa

 package/civetweb/civetweb.mk | 3 +++
 package/lmbench/lmbench.mk   | 4 ++++
 package/php/php.mk           | 4 ++++
 3 files changed, 11 insertions(+)

-- 
1.8.5.2

[Buildroot] [PATCH 1/3] php: fix build for xtensa

[Baruch Siach]

The php package generates a binary that is too large for the xtensa default
placement of literals in a dedicated section. Use -mtext-section-literal to
place literals in the text section.

Fixes
http://autobuild.buildroot.net/results/a9a/a9a1063104402ec28e01560ec7c8f8a5b6d43dd5/.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/php/php.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/php/php.mk b/package/php/php.mk
index 10c314f..f31217e 100644
--- a/package/php/php.mk
+++ b/package/php/php.mk
@@ -36,6 +36,10 @@ ifneq ($(BR2_INET_IPV6),y)
 endif
 endif
 
+ifeq ($(BR2_xtensa),y)
+PHP_CFLAGS += -mtext-section-literals
+endif
+
 PHP_CONF_OPT += $(if $(BR2_PACKAGE_PHP_CLI),,--disable-cli)
 PHP_CONF_OPT += $(if $(BR2_PACKAGE_PHP_CGI),,--disable-cgi)
 
-- 
1.8.5.2

[Buildroot] [PATCH 2/3] lmbench: fix build for xtensa

[Baruch Siach]

The lmbench package generates a binary that is too large for the xtensa default
placement of literals in a dedicated section. Use -mtext-section-literal to
place literals in the text section.

Fixes
http://autobuild.buildroot.net/results/afe/afe9f4550e6ac9a41e4ba338773c1d51034273f7/.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/lmbench/lmbench.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/lmbench/lmbench.mk b/package/lmbench/lmbench.mk
index c3a6c09..529026f 100644
--- a/package/lmbench/lmbench.mk
+++ b/package/lmbench/lmbench.mk
@@ -19,6 +19,10 @@ LMBENCH_CFLAGS += -I$(STAGING_DIR)/usr/include/tirpc/
 LMBENCH_LDFLAGS += -ltirpc
 endif
 
+ifeq ($(BR2_xtensa),y)
+LMBENCH_CFLAGS += -mtext-section-literals
+endif
+
 define LMBENCH_CONFIGURE_CMDS
 	$(call CONFIG_UPDATE,$(@D))
 	sed -i 's/CFLAGS=/CFLAGS+=/g' $(@D)/src/Makefile
-- 
1.8.5.2

[Buildroot] [PATCH 3/3] civetweb: fix build for xtensa

[Baruch Siach]

The civetweb package bundled sqlite3 generates an object that is too large for
the xtensa default placement of literals in a dedicated section. Use
-mtext-section-literal to place literals in the text section.

Fixes
http://autobuild.buildroot.net/results/d14/d142f3ce17ab22cc39f9117c114318c1b5cadfc5/.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/civetweb/civetweb.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/civetweb/civetweb.mk b/package/civetweb/civetweb.mk
index 4c8f4e8..b950890 100644
--- a/package/civetweb/civetweb.mk
+++ b/package/civetweb/civetweb.mk
@@ -25,6 +25,9 @@ endif
 
 ifeq ($(BR2_CIVETWEB_WITH_LUA),y)
 	CIVETWEB_CONF_OPT += WITH_LUA=1
+ifeq ($(BR2_xtensa),y)
+	CIVETWEB_COPT += -mtext-section-literals
+endif
 endif
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
-- 
1.8.5.2

[Buildroot] [PATCH 0/3] xtensa build fixes using -mtext-section-literal

[Thomas Petazzoni]

Dear Baruch Siach,

On Tue, 31 Dec 2013 11:07:28 +0200, Baruch Siach wrote:
> These fixes are all similar. As the helpful linker error message says, xtensa 
> needs -mtext-section-literal when building too large 
> objects/libraries/binaries. So just do as we are told to.
> 
> Baruch Siach (3):
>   php: fix build for xtensa
>   lmbench: fix build for xtensa
>   civetweb: fix build for xtensa
> 
>  package/civetweb/civetweb.mk | 3 +++
>  package/lmbench/lmbench.mk   | 4 ++++
>  package/php/php.mk           | 4 ++++
>  3 files changed, 11 insertions(+)

All three patches applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 0/3] xtensa build fixes using -mtext-section-literal

[Baruch Siach]

Hi Thomas,

On Tue, Dec 31, 2013 at 11:58:22AM +0100, Thomas Petazzoni wrote:
> On Tue, 31 Dec 2013 11:07:28 +0200, Baruch Siach wrote:
> > These fixes are all similar. As the helpful linker error message says, xtensa 
> > needs -mtext-section-literal when building too large 
> > objects/libraries/binaries. So just do as we are told to.
> > 
> > Baruch Siach (3):
> >   php: fix build for xtensa
> >   lmbench: fix build for xtensa
> >   civetweb: fix build for xtensa
> > 
> >  package/civetweb/civetweb.mk | 3 +++
> >  package/lmbench/lmbench.mk   | 4 ++++
> >  package/php/php.mk           | 4 ++++
> >  3 files changed, 11 insertions(+)
> 
> All three patches applied, thanks.

Thanks.

Please also apply http://patchwork.ozlabs.org/patch/305647/ (iozone: add fix 
for missing pthread_setaffinity_np()). It fixes iozone build for xtensa as 
well 
(http://autobuild.buildroot.net/results/d54/d54012d167dc7f70c796a109f7fc659690b5c548/).

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH 0/3] xtensa build fixes using -mtext-section-literal

[Thomas Petazzoni]

Dear Baruch Siach,

On Tue, 31 Dec 2013 13:11:38 +0200, Baruch Siach wrote:

> Please also apply http://patchwork.ozlabs.org/patch/305647/ (iozone: add fix 
> for missing pthread_setaffinity_np()). It fixes iozone build for xtensa as 
> well 
> (http://autobuild.buildroot.net/results/d54/d54012d167dc7f70c796a109f7fc659690b5c548/).

Thanks, applied.

Note that if you want me to apply some patches that are pending, the
best way is to give your formal Acked-by or Tested-by.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com