[Buildroot] [PATCH 2/2] mysql: disable debugging option

[Buildroot] [PATCH 2/2] mysql: disable debugging option

[kuyurix at gmail.com]

From: Marcelo Guti?rrez <kuyurix@gmail.com>

it is not necessary to use $(ENABLE_DEBUG) with "--without-server" option.

BTW, the value of "ENABLE_DEBUG" is empty.

Signed-off-by: Marcelo Guti?rrez <kuyurix@gmail.com>
---
 package/mysql/mysql.mk |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/package/mysql/mysql.mk b/package/mysql/mysql.mk
index 9b22c2d..53daa3f 100644
--- a/package/mysql/mysql.mk
+++ b/package/mysql/mysql.mk
@@ -31,8 +31,7 @@ MYSQL_CONF_OPT = \
 	--without-libedit \
 	--without-readline \
 	--with-low-memory \
-	--enable-thread-safe-client \
-	$(ENABLE_DEBUG)
+	--enable-thread-safe-client
 
 define MYSQL_REMOVE_TEST_PROGS
 	rm -rf $(TARGET_DIR)/usr/mysql-test $(TARGET_DIR)/usr/sql-bench
-- 
1.7.10.4

[Buildroot] [PATCH 2/2] mysql: disable debugging option

[Thomas Petazzoni]

Hello,

On Mon,  3 Feb 2014 17:51:19 +0000, kuyurix at gmail.com wrote:
> From: Marcelo Guti?rrez <kuyurix@gmail.com>
> 
> it is not necessary to use $(ENABLE_DEBUG) with "--without-server" option.

Can you expand on this a little bit?

> BTW, the value of "ENABLE_DEBUG" is empty.

No, not necessarily. ENABLE_DEBUG is a global variable that contains
--enable-debug if BR2_ENABLE_DEBUG is enabled, or is empty otherwise.
See: http://git.buildroot.net/buildroot/tree/package/Makefile.in#n357.

Also, I'm not sure to understand why this patch is PATCH 2/2. I don't
think I have received a PATCH 1/2 in this series. Is this expected?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 2/2] mysql: disable debugging option

[Marcelo Gutierrez]

>
> On Mon,  3 Feb 2014 17:51:19 +0000, kuyurix at gmail.com wrote:
> > From: Marcelo Guti?rrez <kuyurix@gmail.com>
> >
> > it is not necessary to use $(ENABLE_DEBUG) with "--without-server"
> option.
>
> Can you expand on this a little bit?
>

When you use --without-server option, there is no debugging log, because
will work only when MySQL server is enabled.

MySQL 5.1 Reference Manual:
http://dev.mysql.com/doc/refman/5.1/en/debugging-server.html

No, not necessarily. ENABLE_DEBUG is a global variable that contains
> --enable-debug if BR2_ENABLE_DEBUG is enabled, or is empty otherwise.
> See: http://git.buildroot.net/buildroot/tree/package/Makefile.in#n357.
>

To configure MySQL with debugging code, we need to use the
--with-debugoption. But right now we only compile MySQL client, so
that option it's not
necessary.

Also, I'm not sure to understand why this patch is PATCH 2/2. I don't
> think I have received a PATCH 1/2 in this series. Is this expected?
>

You're right, there is no PATCH 1/2 . My bad. I didn't change the subject.

Best,
Marcelo


2014-02-03 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>:

> Hello,
>
> On Mon,  3 Feb 2014 17:51:19 +0000, kuyurix at gmail.com wrote:
> > From: Marcelo Guti?rrez <kuyurix@gmail.com>
> >
> > it is not necessary to use $(ENABLE_DEBUG) with "--without-server"
> option.
>
> Can you expand on this a little bit?
>
> > BTW, the value of "ENABLE_DEBUG" is empty.
>
> No, not necessarily. ENABLE_DEBUG is a global variable that contains
> --enable-debug if BR2_ENABLE_DEBUG is enabled, or is empty otherwise.
> See: http://git.buildroot.net/buildroot/tree/package/Makefile.in#n357.
>
> Also, I'm not sure to understand why this patch is PATCH 2/2. I don't
> think I have received a PATCH 1/2 in this series. Is this expected?
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140203/725e74b1/attachment.html>

[Buildroot] [PATCH 2/2] mysql: disable debugging option

[Thomas Petazzoni]

Dear Marcelo Gutierrez,

On Mon, 3 Feb 2014 21:03:10 -0200, Marcelo Gutierrez wrote:

> When you use --without-server option, there is no debugging log, because
> will work only when MySQL server is enabled.
> 
> MySQL 5.1 Reference Manual:
> http://dev.mysql.com/doc/refman/5.1/en/debugging-server.html

Ok.

> No, not necessarily. ENABLE_DEBUG is a global variable that contains
> > --enable-debug if BR2_ENABLE_DEBUG is enabled, or is empty otherwise.
> > See: http://git.buildroot.net/buildroot/tree/package/Makefile.in#n357.
> >
> 
> To configure MySQL with debugging code, we need to use the
> --with-debugoption. But right now we only compile MySQL client, so
> that option it's not
> necessary.

Ok. Can you resend your patch with an updated commit log that explains
this?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com