[Buildroot] [git commit] opencv: cleanup depends and comments

[Buildroot] [git commit] opencv: cleanup depends and comments

[Peter Korsgaard]

commit: http://git.buildroot.net/buildroot/commit/?id=5f7cbb264ec21f75320ad8518d27f4c605c825f8
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Since the opencv package globally depends on BR2_TOOLCHAIN_HAS_THREADS
and BR2_USE_WCHAR, then cleanup these redundant (and useless)
dependencies in the opencv's sub-options.

Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/opencv/Config.in |   12 ++----------
 1 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/package/opencv/Config.in b/package/opencv/Config.in
index ccde5cb..dfdd93a 100644
--- a/package/opencv/Config.in
+++ b/package/opencv/Config.in
@@ -140,20 +140,13 @@ comment "ffmpeg support needs a toolchain w/ largefile, IPv6"
 
 config BR2_PACKAGE_OPENCV_WITH_GSTREAMER
 	bool "gstreamer support"
-	depends on BR2_USE_WCHAR # gstreamer -> libglib2
-	depends on BR2_TOOLCHAIN_HAS_THREADS # gstreamer -> libglib2
 	select BR2_PACKAGE_GSTREAMER
 	select BR2_PACKAGE_GST_PLUGINS_BASE
 	select BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_APP
 
-comment "gstreamer support needs a toolchain w/ wchar, threads"
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
-
 config BR2_PACKAGE_OPENCV_WITH_GTK
 	bool "gtk support"
 	depends on BR2_PACKAGE_XORG7
-	depends on BR2_USE_WCHAR # libgtk2 -> libglib2
-	depends on BR2_TOOLCHAIN_HAS_THREADS # libgtk2 -> libglib2
 	depends on BR2_INSTALL_LIBSTDCPP
 	select BR2_PACKAGE_LIBGTK2
 
@@ -188,13 +181,12 @@ config BR2_PACKAGE_OPENCV_WITH_TIFF
 config BR2_PACKAGE_OPENCV_WITH_V4L
 	bool "v4l support"
 	depends on BR2_LARGEFILE
-	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_LIBV4L
 	help
 	  Enable Video 4 Linux support.
 
-comment "v4l support needs a toolchain w/ largefile, threads"
-	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
+comment "v4l support needs a toolchain w/ largefile"
+	depends on !BR2_LARGEFILE
 
 comment "Install options"
 

[Buildroot] [git commit] opencv: cleanup depends and comments

[Thomas Petazzoni]

Dear Peter Korsgaard,

On Wed, 5 Feb 2014 23:33:41 +0100, Peter Korsgaard wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=5f7cbb264ec21f75320ad8518d27f4c605c825f8
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> 
> Since the opencv package globally depends on BR2_TOOLCHAIN_HAS_THREADS
> and BR2_USE_WCHAR, then cleanup these redundant (and useless)
> dependencies in the opencv's sub-options.
> 
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/opencv/Config.in |   12 ++----------
>  1 files changed, 2 insertions(+), 10 deletions(-)

Is this really our policy? It was mentioned several times that we
should probably keep those, so that if the OpenCV package option itself
no longer needs wchar or threads in the future, we already have those
dependencies needed for the packages selected by OpenCV.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [git commit] opencv: cleanup depends and comments

[Thomas De Schampheleire]

On Thu, Feb 6, 2014 at 9:59 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Peter Korsgaard,
>
> On Wed, 5 Feb 2014 23:33:41 +0100, Peter Korsgaard wrote:
>> commit: http://git.buildroot.net/buildroot/commit/?id=5f7cbb264ec21f75320ad8518d27f4c605c825f8
>> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>>
>> Since the opencv package globally depends on BR2_TOOLCHAIN_HAS_THREADS
>> and BR2_USE_WCHAR, then cleanup these redundant (and useless)
>> dependencies in the opencv's sub-options.
>>
>> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>> ---
>>  package/opencv/Config.in |   12 ++----------
>>  1 files changed, 2 insertions(+), 10 deletions(-)
>
> Is this really our policy? It was mentioned several times that we
> should probably keep those, so that if the OpenCV package option itself
> no longer needs wchar or threads in the future, we already have those
> dependencies needed for the packages selected by OpenCV.
>

Yes, I thought so too...

[Buildroot] [git commit] opencv: cleanup depends and comments

[Peter Korsgaard]

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:

 >> Is this really our policy? It was mentioned several times that we
 >> should probably keep those, so that if the OpenCV package option itself
 >> no longer needs wchar or threads in the future, we already have those
 >> dependencies needed for the packages selected by OpenCV.
 >> 

 > Yes, I thought so too...

Ok, I'll revert it.

-- 
Bye, Peter Korsgaard