[Buildroot] [PATCH] package/rt-tests: fix Kconfig syntax

[Buildroot] [PATCH] package/rt-tests: fix Kconfig syntax

[Yann E. MORIN]

From: "Yann E. MORIN" <yann.morin.1998@free.fr>

Fixes:
    $ make menuconfig
    [...]
    package/rt-tests/Config.in:10: syntax error
    package/rt-tests/Config.in:9: invalid option
    package/rt-tests/Config.in:36: syntax error
    package/rt-tests/Config.in:35: invalid option
    make[1]: *** [oldconfig] Error 1
    make: *** [_all] Error 2

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Ryan Barnett <rjbarnet@rockwellcollins.com>
---
 package/rt-tests/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/rt-tests/Config.in b/package/rt-tests/Config.in
index ff4284e..605635c 100644
--- a/package/rt-tests/Config.in
+++ b/package/rt-tests/Config.in
@@ -6,8 +6,8 @@ config BR2_PACKAGE_RT_TESTS
 	# no NPTL for these archs
 	depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc && !BR2_bfin
 	# no _tid field in 'struct sigevent'
-	depends on !BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
-		BR2_mips64 || BR2_mips64el)
+	depends on ! ( BR2_TOOLCHAIN_USES_UCLIBC && (BR2_mips || BR2_mipsel || \
+		BR2_mips64 || BR2_mips64el) )
 	help
 	  Set of utilities for testing the real-time behaviour of a
 	  Linux system.
@@ -32,5 +32,5 @@ comment "rt-tests needs a toolchain w/ threads"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
 
 comment "rt-tests needs an (e)glibc toolchain"
-	depends on BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
+	depends on BR2_TOOLCHAIN_USES_UCLIBC && (BR2_mips || BR2_mipsel || \
 		BR2_mips64 || BR2_mips64el)
-- 
1.8.3.2

[Buildroot] [PATCH] package/rt-tests: fix Kconfig syntax

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Sun, 23 Feb 2014 18:29:47 +0100, Yann E. MORIN wrote:

> diff --git a/package/rt-tests/Config.in b/package/rt-tests/Config.in
> index ff4284e..605635c 100644
> --- a/package/rt-tests/Config.in
> +++ b/package/rt-tests/Config.in
> @@ -6,8 +6,8 @@ config BR2_PACKAGE_RT_TESTS
>  	# no NPTL for these archs
>  	depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc && !BR2_bfin
>  	# no _tid field in 'struct sigevent'
> -	depends on !BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
> -		BR2_mips64 || BR2_mips64el)
> +	depends on ! ( BR2_TOOLCHAIN_USES_UCLIBC && (BR2_mips || BR2_mipsel || \
> +		BR2_mips64 || BR2_mips64el) )

I know it's nitpicking, but I must say I personally dislike these
spaces between !, parenthesis and the rest. I very much prefer:

	depends on !(BR2_TOOLCHAIN_USES_UCLIBC && (BR2_mips || BR2_mipsel || \
		BR2_mips64 || BR2_mips64el))

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] package/rt-tests: fix Kconfig syntax

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Fixes:
 >     $ make menuconfig
 >     [...]
 >     package/rt-tests/Config.in:10: syntax error
 >     package/rt-tests/Config.in:9: invalid option
 >     package/rt-tests/Config.in:36: syntax error
 >     package/rt-tests/Config.in:35: invalid option
 >     make[1]: *** [oldconfig] Error 1
 >     make: *** [_all] Error 2

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Ryan Barnett <rjbarnet@rockwellcollins.com>

Sorry, I already fixed it myself (in the same way) before I saw your
patch.

-- 
Bye, Peter Korsgaard