From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] luajit: refactor without dont-strip.patch
Date: Thu, 27 Feb 2014 23:59:52 +0100 [thread overview]
Message-ID: <20140227235952.4bde8034@skate> (raw)
In-Reply-To: <1390465713-12600-1-git-send-email-francois.perrad@gadz.org>
Dear Francois Perrad,
On Thu, 23 Jan 2014 09:28:30 +0100, Francois Perrad wrote:
> the variable TARGET_STRIP does the job
>
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/luajit/luajit-03-dont-strip.patch | 23 -----------------------
> package/luajit/luajit.mk | 2 +-
> 2 files changed, 1 insertion(+), 24 deletions(-)
> delete mode 100644 package/luajit/luajit-03-dont-strip.patch
Looks good to me. Just a question below.
> + TARGET_STRIP=@: \
Any reason to use @: instead of just : ?
Also, personally, I would probably prefer TARGET_STRIP=true. I know
it's the same, but I find the usage of ':' a bit hard to read.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-27 22:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 8:28 [Buildroot] [PATCH 1/4] luajit: refactor without dont-strip.patch Francois Perrad
2014-01-23 8:28 ` [Buildroot] [PATCH 2/4] luajit: refactor without shared-lib.patch Francois Perrad
2014-01-23 8:28 ` [Buildroot] [PATCH 3/4] luajit: add host-luajit Francois Perrad
2014-01-23 8:28 ` [Buildroot] [PATCH 4/4] luarocks: allow to work with host-luajit Francois Perrad
2014-02-27 22:59 ` Thomas Petazzoni [this message]
2014-02-28 0:40 ` [Buildroot] [PATCH 1/4] luajit: refactor without dont-strip.patch François Perrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227235952.4bde8034@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox