[Buildroot] [lua V3 0/8] lua

[Buildroot] [lua V3 0/8] lua

[Francois Perrad]

delta V3 vs V1 (remaining)
  - luajit: refactor without dont-strip.patch
    now with 'true' instead of '@:'
  - luajit: handles BR2_PREFER_STATIC_LIB
    new patch
  - luainterpreter: add host variant
    new patch, previously included in the luarocks one
  - ljlinenoise
    split dependencies for comment statement in Config.in
  - lua-iconv
    add missing dependencies in .mk

delta V2 vs V1
  - only a subset for 2014.02
  - add fix for Blackfin FLAT

Francois Perrad (8):
  luajit: refactor without dont-strip.patch
  luajit: refactor without shared-lib.patch
  luajit: handles BR2_PREFER_STATIC_LIB
  luajit: add host variant
  luainterpreter: add host variant
  luarocks: allow to work with host-luainterpreter
  ljlinenoise: new package
  lua-iconv: new package

 package/Config.in                         |    2 ++
 package/ljlinenoise/Config.in             |   16 ++++++++++++++++
 package/ljlinenoise/ljlinenoise.mk        |   13 +++++++++++++
 package/lua-iconv/Config.in               |    8 ++++++++
 package/lua-iconv/lua-iconv.mk            |   14 ++++++++++++++
 package/luainterpreter/luainterpreter.mk  |    4 ++++
 package/luajit/luajit-02-shared-lib.patch |   17 -----------------
 package/luajit/luajit-03-dont-strip.patch |   23 -----------------------
 package/luajit/luajit.mk                  |   18 +++++++++++++++++-
 package/luarocks/luarocks.mk              |   18 ++++++++++++------
 10 files changed, 86 insertions(+), 47 deletions(-)
 create mode 100644 package/ljlinenoise/Config.in
 create mode 100644 package/ljlinenoise/ljlinenoise.mk
 create mode 100644 package/lua-iconv/Config.in
 create mode 100644 package/lua-iconv/lua-iconv.mk
 delete mode 100644 package/luajit/luajit-02-shared-lib.patch
 delete mode 100644 package/luajit/luajit-03-dont-strip.patch

-- 
1.7.9.5

[Buildroot] [lua V3 1/8] luajit: refactor without dont-strip.patch

[Francois Perrad]

the variable TARGET_STRIP does the job

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/luajit/luajit-03-dont-strip.patch |   23 -----------------------
 package/luajit/luajit.mk                  |    2 +-
 2 files changed, 1 insertion(+), 24 deletions(-)
 delete mode 100644 package/luajit/luajit-03-dont-strip.patch

diff --git a/package/luajit/luajit-03-dont-strip.patch b/package/luajit/luajit-03-dont-strip.patch
deleted file mode 100644
index 66bdadf..0000000
--- a/package/luajit/luajit-03-dont-strip.patch
+++ /dev/null
@@ -1,23 +0,0 @@
-Don't strip the library and binary
-
-This allows Buildroot to do it if needed, but only if needed.
-
-Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-
-Index: b/src/Makefile
-===================================================================
---- a/src/Makefile
-+++ b/src/Makefile
-@@ -665,12 +665,10 @@
- $(LUAJIT_SO): $(LJVMCORE_O)
- 	$(E) "DYNLINK   $@"
- 	$(Q)$(TARGET_LD) $(TARGET_ASHLDFLAGS) -o $@ $(LJVMCORE_DYNO) $(TARGET_ALIBS)
--	$(Q)$(TARGET_STRIP) $@
- 
- $(LUAJIT_T): $(TARGET_O) $(LUAJIT_O) $(TARGET_DEP)
- 	$(E) "LINK      $@"
- 	$(Q)$(TARGET_LD) $(TARGET_ALDFLAGS) -o $@ $(LUAJIT_O) -lluajit -L. $(TARGET_ALIBS)
--	$(Q)$(TARGET_STRIP) $@
- 	$(E) "OK        Successfully built LuaJIT"
- 
- ##############################################################################
diff --git a/package/luajit/luajit.mk b/package/luajit/luajit.mk
index 4122d0a..72720d8 100644
--- a/package/luajit/luajit.mk
+++ b/package/luajit/luajit.mk
@@ -37,7 +37,7 @@ define LUAJIT_BUILD_CMDS
 		DYNAMIC_CC="$(TARGET_CC) -fPIC" \
 		TARGET_LD="$(TARGET_CC)" \
 		TARGET_AR="$(TARGET_AR) rcus" \
-		TARGET_STRIP="$(TARGET_STRIP)" \
+		TARGET_STRIP=true \
 		TARGET_CFLAGS="$(TARGET_CFLAGS)" \
 		TARGET_LDFLAGS="$(TARGET_LDFLAGS)" \
 		HOST_CC="$(LUAJIT_HOST_CC)" \
-- 
1.7.9.5

[Buildroot] [lua V3 2/8] luajit: refactor without shared-lib.patch

[Francois Perrad]

the variable BUILDMODE does the job

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/luajit/luajit-02-shared-lib.patch |   17 -----------------
 package/luajit/luajit.mk                  |    1 +
 2 files changed, 1 insertion(+), 17 deletions(-)
 delete mode 100644 package/luajit/luajit-02-shared-lib.patch

diff --git a/package/luajit/luajit-02-shared-lib.patch b/package/luajit/luajit-02-shared-lib.patch
deleted file mode 100644
index 361e5c2..0000000
--- a/package/luajit/luajit-02-shared-lib.patch
+++ /dev/null
@@ -1,17 +0,0 @@
-Compile the luajit binary dynamically against the luajit library
-
-Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-
-Index: b/src/Makefile
-===================================================================
---- a/src/Makefile
-+++ b/src/Makefile
-@@ -669,7 +669,7 @@
- 
- $(LUAJIT_T): $(TARGET_O) $(LUAJIT_O) $(TARGET_DEP)
- 	$(E) "LINK      $@"
--	$(Q)$(TARGET_LD) $(TARGET_ALDFLAGS) -o $@ $(LUAJIT_O) $(TARGET_O) $(TARGET_ALIBS)
-+	$(Q)$(TARGET_LD) $(TARGET_ALDFLAGS) -o $@ $(LUAJIT_O) -lluajit -L. $(TARGET_ALIBS)
- 	$(Q)$(TARGET_STRIP) $@
- 	$(E) "OK        Successfully built LuaJIT"
- 
diff --git a/package/luajit/luajit.mk b/package/luajit/luajit.mk
index 72720d8..32596a1 100644
--- a/package/luajit/luajit.mk
+++ b/package/luajit/luajit.mk
@@ -44,6 +44,7 @@ define LUAJIT_BUILD_CMDS
 		HOST_CFLAGS="$(HOST_CFLAGS)" \
 		HOST_LDFLAGS="$(HOST_LDFLAGS)" \
 		$(LUAJIT_NO_LARGEFILE) \
+		BUILDMODE=dynamic \
 		-C $(@D) amalg
 endef
 
-- 
1.7.9.5

[Buildroot] [lua V3 3/8] luajit: handles BR2_PREFER_STATIC_LIB

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/luajit/luajit.mk |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/package/luajit/luajit.mk b/package/luajit/luajit.mk
index 32596a1..859425a 100644
--- a/package/luajit/luajit.mk
+++ b/package/luajit/luajit.mk
@@ -16,6 +16,12 @@ ifneq ($(BR2_LARGEFILE),y)
 LUAJIT_NO_LARGEFILE = TARGET_LFSFLAGS=
 endif
 
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+LUAJIT_BUILDMODE = static
+else
+LUAJIT_BUILDMODE = dynamic
+endif
+
 # The luajit build procedure requires the host compiler to have the
 # same bitness as the target compiler. Therefore, on a x86 build
 # machine, we can't build luajit for x86_64, which is checked in
@@ -44,7 +50,7 @@ define LUAJIT_BUILD_CMDS
 		HOST_CFLAGS="$(HOST_CFLAGS)" \
 		HOST_LDFLAGS="$(HOST_LDFLAGS)" \
 		$(LUAJIT_NO_LARGEFILE) \
-		BUILDMODE=dynamic \
+		BUILDMODE=$(LUAJIT_BUILDMODE) \
 		-C $(@D) amalg
 endef
 
-- 
1.7.9.5

[Buildroot] [lua V3 4/8] luajit: add host variant

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/luajit/luajit.mk |    9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/package/luajit/luajit.mk b/package/luajit/luajit.mk
index 859425a..cb1d94e 100644
--- a/package/luajit/luajit.mk
+++ b/package/luajit/luajit.mk
@@ -62,4 +62,13 @@ define LUAJIT_INSTALL_TARGET_CMDS
 	$(MAKE) PREFIX="/usr" DESTDIR="$(TARGET_DIR)" LDCONFIG=true -C $(@D) install
 endef
 
+define HOST_LUAJIT_BUILD_CMDS
+	$(MAKE) PREFIX="/usr" BUILDMODE=static -C $(@D) amalg
+endef
+
+define HOST_LUAJIT_INSTALL_CMDS
+	$(MAKE) PREFIX="/usr" DESTDIR="$(HOST_DIR)" -C $(@D) install
+endef
+
 $(eval $(generic-package))
+$(eval $(host-generic-package))
-- 
1.7.9.5

[Buildroot] [lua V3 5/8] luainterpreter: add host variant

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/luainterpreter/luainterpreter.mk |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/luainterpreter/luainterpreter.mk b/package/luainterpreter/luainterpreter.mk
index c37d621..976fec8 100644
--- a/package/luainterpreter/luainterpreter.mk
+++ b/package/luainterpreter/luainterpreter.mk
@@ -5,8 +5,10 @@
 #############################################################
 
 LUAINTERPRETER_SOURCE =
+HOST_LUAINTERPRETER_SOURCE =
 LUAINTERPRETER_DEPENDENCIES = $(call qstrip,$(BR2_PACKAGE_PROVIDES_LUA_INTERPRETER))
 
 LUAINTERPRETER_ABIVER = $(call qstrip,$(BR2_PACKAGE_LUAINTERPRETER_ABI_VERSION))
 
 $(eval $(generic-package))
+$(eval $(host-generic-package))
-- 
1.7.9.5

[Buildroot] [lua V3 6/8] luarocks: allow to work with host-luainterpreter

[Francois Perrad]

when we embed luajit on target, we use luarocks with host-luajit (instead of host-lua)

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/luainterpreter/luainterpreter.mk |    2 ++
 package/luarocks/luarocks.mk             |   18 ++++++++++++------
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/package/luainterpreter/luainterpreter.mk b/package/luainterpreter/luainterpreter.mk
index 976fec8..d5b95db 100644
--- a/package/luainterpreter/luainterpreter.mk
+++ b/package/luainterpreter/luainterpreter.mk
@@ -12,3 +12,5 @@ LUAINTERPRETER_ABIVER = $(call qstrip,$(BR2_PACKAGE_LUAINTERPRETER_ABI_VERSION))
 
 $(eval $(generic-package))
 $(eval $(host-generic-package))
+
+LUA_RUN = $(HOST_DIR)/usr/bin/$(call qstrip,$(BR2_PACKAGE_PROVIDES_LUA_INTERPRETER))
diff --git a/package/luarocks/luarocks.mk b/package/luarocks/luarocks.mk
index 86e57d2..0b99de6 100644
--- a/package/luarocks/luarocks.mk
+++ b/package/luarocks/luarocks.mk
@@ -9,16 +9,22 @@ LUAROCKS_SITE = http://luarocks.org/releases/
 LUAROCKS_LICENSE = MIT
 LUAROCKS_LICENSE_FILES = COPYING
 
-HOST_LUAROCKS_DEPENDENCIES = host-lua luainterpreter
+HOST_LUAROCKS_DEPENDENCIES = host-luainterpreter luainterpreter
 
 LUAROCKS_CONFIG_DIR  = $(HOST_DIR)/usr/etc/luarocks
 LUAROCKS_CONFIG_FILE = $(LUAROCKS_CONFIG_DIR)/config-$(LUAINTERPRETER_ABIVER).lua
 
+HOST_LUAROCKS_CONF_OPT = \
+	--prefix=$(HOST_DIR)/usr \
+	--sysconfdir=$(LUAROCKS_CONFIG_DIR) \
+	--with-lua=$(HOST_DIR)/usr
+
+ifeq ($(BR2_PACKAGE_LUAJIT),y)
+HOST_LUAROCKS_CONF_OPT += --lua-suffix=jit
+endif
+
 define HOST_LUAROCKS_CONFIGURE_CMDS
-	cd $(@D) && ./configure \
-		--prefix=$(HOST_DIR)/usr \
-		--sysconfdir=$(LUAROCKS_CONFIG_DIR) \
-		--with-lua=$(HOST_DIR)/usr
+	cd $(@D) && ./configure $(HOST_LUAROCKS_CONF_OPT)
 endef
 
 define HOST_LUAROCKS_INSTALL_CMDS
@@ -43,4 +49,4 @@ endef
 $(eval $(host-generic-package))
 
 LUAROCKS_RUN = LUA_PATH="$(HOST_DIR)/usr/share/lua/$(LUAINTERPRETER_ABIVER)/?.lua" \
-	$(HOST_DIR)/usr/bin/lua $(HOST_DIR)/usr/bin/luarocks
+	$(LUA_RUN) $(HOST_DIR)/usr/bin/luarocks
-- 
1.7.9.5

[Buildroot] [lua V3 7/8] ljlinenoise: new package

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/Config.in                  |    1 +
 package/ljlinenoise/Config.in      |   16 ++++++++++++++++
 package/ljlinenoise/ljlinenoise.mk |   13 +++++++++++++
 3 files changed, 30 insertions(+)
 create mode 100644 package/ljlinenoise/Config.in
 create mode 100644 package/ljlinenoise/ljlinenoise.mk

diff --git a/package/Config.in b/package/Config.in
index 46c4ba4..4a91f48 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -369,6 +369,7 @@ source "package/cgilua/Config.in"
 source "package/copas/Config.in"
 source "package/coxpcall/Config.in"
 source "package/lbase64/Config.in"
+source "package/ljlinenoise/Config.in"
 source "package/ljsyscall/Config.in"
 source "package/lua-cjson/Config.in"
 source "package/lua-ev/Config.in"
diff --git a/package/ljlinenoise/Config.in b/package/ljlinenoise/Config.in
new file mode 100644
index 0000000..4e0116e
--- /dev/null
+++ b/package/ljlinenoise/Config.in
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_LJLINENOISE
+	bool "ljlinenoise"
+	select BR2_PACKAGE_LJSYSCALL
+	# ljsyscall is specifically for LuaJIT, not Lua.
+	depends on BR2_PACKAGE_LUAJIT
+	# ljsyscall is only available for some target architectures
+	depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb
+	help
+	  ljlinenoise is a pure LuaJIT port of linenoise,
+	  a small alternative to readline and libedit.
+
+	  http://fperrad.github.io/ljlinenoise/
+
+comment "ljlinenoise needs LuaJIT"
+	depends on !BR2_PACKAGE_LUAJIT
+	depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb
diff --git a/package/ljlinenoise/ljlinenoise.mk b/package/ljlinenoise/ljlinenoise.mk
new file mode 100644
index 0000000..69f6130
--- /dev/null
+++ b/package/ljlinenoise/ljlinenoise.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# ljlinenoise
+#
+################################################################################
+
+LJLINENOISE_VERSION_UPSTREAM = 0.1.1
+LJLINENOISE_VERSION = $(LJLINENOISE_VERSION_UPSTREAM)-1
+LJLINENOISE_SUBDIR  = ljlinenoise-$(LJLINENOISE_VERSION_UPSTREAM)
+LJLINENOISE_LICENSE = MIT
+LJLINENOISE_LICENSE_FILES = $(LJLINENOISE_SUBDIR)/COPYRIGHT
+
+$(eval $(luarocks-package))
-- 
1.7.9.5

[Buildroot] [lua V3 8/8] lua-iconv: new package

[Francois Perrad]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/Config.in              |    1 +
 package/lua-iconv/Config.in    |    8 ++++++++
 package/lua-iconv/lua-iconv.mk |   14 ++++++++++++++
 3 files changed, 23 insertions(+)
 create mode 100644 package/lua-iconv/Config.in
 create mode 100644 package/lua-iconv/lua-iconv.mk

diff --git a/package/Config.in b/package/Config.in
index 4a91f48..3558106 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -373,6 +373,7 @@ source "package/ljlinenoise/Config.in"
 source "package/ljsyscall/Config.in"
 source "package/lua-cjson/Config.in"
 source "package/lua-ev/Config.in"
+source "package/lua-iconv/Config.in"
 source "package/lua-msgpack-native/Config.in"
 source "package/luasql-sqlite3/Config.in"
 source "package/luabitop/Config.in"
diff --git a/package/lua-iconv/Config.in b/package/lua-iconv/Config.in
new file mode 100644
index 0000000..cad7c7c
--- /dev/null
+++ b/package/lua-iconv/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LUA_ICONV
+	bool "lua-iconv"
+	select BR2_PACKAGE_LIBICONV
+	depends on !BR2_ENABLE_LOCALE
+	help
+	  Lua binding to the POSIX 'iconv' library
+
+	  http://ittner.github.io/lua-iconv/
diff --git a/package/lua-iconv/lua-iconv.mk b/package/lua-iconv/lua-iconv.mk
new file mode 100644
index 0000000..22f66de
--- /dev/null
+++ b/package/lua-iconv/lua-iconv.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# lua-iconv
+#
+################################################################################
+
+LUA_ICONV_VERSION_UPSTREAM = 7
+LUA_ICONV_VERSION = $(LUA_ICONV_VERSION_UPSTREAM)-1
+LUA_ICONV_SUBDIR  = lua-iconv-$(LUA_ICONV_VERSION_UPSTREAM)
+LUA_ICONV_DEPENDENCIES = luainterpreter libiconv
+LUA_ICONV_LICENSE = MIT
+LUA_ICONV_LICENSE_FILES = $(LUA_ICONV_SUBDIR)/COPYING
+
+$(eval $(luarocks-package))
-- 
1.7.9.5

[Buildroot] [lua V3 4/8] luajit: add host variant

[Yann E. MORIN]

Fran?ois, All,

On 2014-03-01 18:23 +0100, Francois Perrad spake thusly:
> 
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  package/luajit/luajit.mk |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/package/luajit/luajit.mk b/package/luajit/luajit.mk
> index 859425a..cb1d94e 100644
> --- a/package/luajit/luajit.mk
> +++ b/package/luajit/luajit.mk
> @@ -62,4 +62,13 @@ define LUAJIT_INSTALL_TARGET_CMDS
>  	$(MAKE) PREFIX="/usr" DESTDIR="$(TARGET_DIR)" LDCONFIG=true -C $(@D) install
>  endef
>  
> +define HOST_LUAJIT_BUILD_CMDS
> +	$(MAKE) PREFIX="/usr" BUILDMODE=static -C $(@D) amalg
> +endef
> +
> +define HOST_LUAJIT_INSTALL_CMDS
> +	$(MAKE) PREFIX="/usr" DESTDIR="$(HOST_DIR)" -C $(@D) install
> +endef
> +
>  $(eval $(generic-package))
> +$(eval $(host-generic-package))

I'm really worried about how this is gonna play with the virtual-package
insfrastructure curently pending.

On one hand, I'd like the virtual-package infra to go in first (hey! I
wrote it! ;-) ), since I'm not very versed in this lua stuff (but you
are), and we currently have no host virtual packages. But that would
put the burden onto you to rebase your series.

On the other hand, sicne you're introducing host virtual packages, we
may want to have them in before the virtual-package infra, so we get a
pretty good idea of what is actually required.

So, whatever... Let's see what Thomas (deputy-maintainer while Peter's
on vacation) will say about this. Thomas? ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [lua V3 4/8] luajit: add host variant

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Sat, 1 Mar 2014 18:47:21 +0100, Yann E. MORIN wrote:

> I'm really worried about how this is gonna play with the virtual-package
> insfrastructure curently pending.
> 
> On one hand, I'd like the virtual-package infra to go in first (hey! I
> wrote it! ;-) ), since I'm not very versed in this lua stuff (but you
> are), and we currently have no host virtual packages. But that would
> put the burden onto you to rebase your series.
> 
> On the other hand, sicne you're introducing host virtual packages, we
> may want to have them in before the virtual-package infra, so we get a
> pretty good idea of what is actually required.
> 
> So, whatever... Let's see what Thomas (deputy-maintainer while Peter's
> on vacation) will say about this. Thomas? ;-)

While in general I prefer to merge things as soon as possible, and then
improve on top of it later on, in this case, I believe it would be nice
if the virtual package infra could from the beginning support the host
package case since we know we will need it for the Lua stuff.

Yann, you could just test it with some simple dummy host packages to
ensure that your virtual infra works for host packages, and leave it to
Fran?ois to rebase his series on top of the infra once it has been
merged.

How does it sounds?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [lua V3 4/8] luajit: add host variant

[Yann E. MORIN]

Thomas, All,

On 2014-03-01 19:39 +0100, Thomas Petazzoni spake thusly:
> On Sat, 1 Mar 2014 18:47:21 +0100, Yann E. MORIN wrote:
> > I'm really worried about how this is gonna play with the virtual-package
> > insfrastructure curently pending.
[--SNIP--]
> While in general I prefer to merge things as soon as possible, and then
> improve on top of it later on, in this case, I believe it would be nice
> if the virtual package infra could from the beginning support the host
> package case since we know we will need it for the Lua stuff.
> 
> Yann, you could just test it with some simple dummy host packages to
> ensure that your virtual infra works for host packages, and leave it to
> Fran?ois to rebase his series on top of the infra once it has been
> merged.
> 
> How does it sounds?

I already thought about this. But writing a host virtual package that
actually makes sense is not so easy. But I can try to do so...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [lua V3 0/8] lua

[Thomas Petazzoni]

Dear Francois Perrad,

On Sat,  1 Mar 2014 18:23:01 +0100, Francois Perrad wrote:

> Francois Perrad (8):
>   luajit: refactor without dont-strip.patch
>   luajit: refactor without shared-lib.patch
>   luajit: handles BR2_PREFER_STATIC_LIB
>   luajit: add host variant
>   luainterpreter: add host variant
>   luarocks: allow to work with host-luainterpreter

For all these patches, and especially the last three ones, I want
commit logs. I really do appreciate _a lot_ all the work you're doing
on Lua and Perl, it's really awesome. And I really mean it. But you
need to work on improving your commit logs. For now, we have no idea
*why* you're doing these changes.

All the other core developers are doing efforts to write long,
descriptive commit logs, and experience has shown that they are
immensely useful 6 or 12 months later when we got back in the Git
history to understand why things were done. Look at what they do, and
follow the basic rule of thumb that any non-trivial patch should have
at least 2 or 3 paragraphs in its commit log explaining *why* the
change is being made.

At this point, I have no idea what you are doing. I presume patches 4
and 5 are preparations for patch 6, but I don't understand what patch 6
is doing, and nowhere it is mentioned why patches 4 and 5 are needed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [lua V3 7/8] ljlinenoise: new package

[Thomas Petazzoni]

Dear Francois Perrad,

On Sat,  1 Mar 2014 18:23:08 +0100, Francois Perrad wrote:
> 
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  package/Config.in                  |    1 +
>  package/ljlinenoise/Config.in      |   16 ++++++++++++++++
>  package/ljlinenoise/ljlinenoise.mk |   13 +++++++++++++
>  3 files changed, 30 insertions(+)
>  create mode 100644 package/ljlinenoise/Config.in
>  create mode 100644 package/ljlinenoise/ljlinenoise.mk

Applied, after adjusting the Config.in file to indicate that ljsyscall
is a runtime dependency only.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [lua V3 0/8] lua

[Thomas Petazzoni]

Fran?ois,

On Sun, 2 Mar 2014 00:02:32 +0100, Thomas Petazzoni wrote:

> > Francois Perrad (8):
> >   luajit: refactor without dont-strip.patch
> >   luajit: refactor without shared-lib.patch
> >   luajit: handles BR2_PREFER_STATIC_LIB
> >   luajit: add host variant
> >   luainterpreter: add host variant
> >   luarocks: allow to work with host-luainterpreter
> 
> For all these patches, and especially the last three ones, I want
> commit logs. I really do appreciate _a lot_ all the work you're doing
> on Lua and Perl, it's really awesome. And I really mean it. But you
> need to work on improving your commit logs. For now, we have no idea
> *why* you're doing these changes.
> 
> All the other core developers are doing efforts to write long,
> descriptive commit logs, and experience has shown that they are
> immensely useful 6 or 12 months later when we got back in the Git
> history to understand why things were done. Look at what they do, and
> follow the basic rule of thumb that any non-trivial patch should have
> at least 2 or 3 paragraphs in its commit log explaining *why* the
> change is being made.
> 
> At this point, I have no idea what you are doing. I presume patches 4
> and 5 are preparations for patch 6, but I don't understand what patch 6
> is doing, and nowhere it is mentioned why patches 4 and 5 are needed.

Any news about these patches? From this series, we still have patches
4, 5, 6 and 8 pending in patchwork. Could you take into account the
comments that have been made (mainly the strong need for more detailed
commit logs), and resend updated versions on top of master?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [UNSURE]Re: [lua V3 0/8] lua

[François Perrad]

2014-04-19 23:58 GMT+02:00 Thomas Petazzoni
<thomas.petazzoni@free-electrons.com>:
> Fran?ois,
>
> On Sun, 2 Mar 2014 00:02:32 +0100, Thomas Petazzoni wrote:
>
>> > Francois Perrad (8):
>> >   luajit: refactor without dont-strip.patch
>> >   luajit: refactor without shared-lib.patch
>> >   luajit: handles BR2_PREFER_STATIC_LIB
>> >   luajit: add host variant
>> >   luainterpreter: add host variant
>> >   luarocks: allow to work with host-luainterpreter
>>
>> For all these patches, and especially the last three ones, I want
>> commit logs. I really do appreciate _a lot_ all the work you're doing
>> on Lua and Perl, it's really awesome. And I really mean it. But you
>> need to work on improving your commit logs. For now, we have no idea
>> *why* you're doing these changes.
>>
>> All the other core developers are doing efforts to write long,
>> descriptive commit logs, and experience has shown that they are
>> immensely useful 6 or 12 months later when we got back in the Git
>> history to understand why things were done. Look at what they do, and
>> follow the basic rule of thumb that any non-trivial patch should have
>> at least 2 or 3 paragraphs in its commit log explaining *why* the
>> change is being made.
>>
>> At this point, I have no idea what you are doing. I presume patches 4
>> and 5 are preparations for patch 6, but I don't understand what patch 6
>> is doing, and nowhere it is mentioned why patches 4 and 5 are needed.
>
> Any news about these patches? From this series, we still have patches
> 4, 5, 6 and 8 pending in patchwork. Could you take into account the
> comments that have been made (mainly the strong need for more detailed
> commit logs), and resend updated versions on top of master?

I'll work on them after 2014.05 release.

Fran?ois

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [UNSURE]Re: [lua V3 0/8] lua

[Thomas Petazzoni]

Dear Fran?ois Perrad,

On Sun, 20 Apr 2014 09:38:40 +0200, Fran?ois Perrad wrote:

> > Any news about these patches? From this series, we still have patches
> > 4, 5, 6 and 8 pending in patchwork. Could you take into account the
> > comments that have been made (mainly the strong need for more detailed
> > commit logs), and resend updated versions on top of master?
> 
> I'll work on them after 2014.05 release.

Well, there is still some time before the 2014.05 release, so you can
submit them earlier if you want.

In the mean time, what can I do with your patches in patchwork? Can I
mark them as "Changes requested", making the assumption you will
remember to send updated versions in the future?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [UNSURE]Re: [lua V3 0/8] lua

[François Perrad]

2014-04-20 10:13 GMT+02:00 Thomas Petazzoni
<thomas.petazzoni@free-electrons.com>:
> Dear Fran?ois Perrad,
>
> On Sun, 20 Apr 2014 09:38:40 +0200, Fran?ois Perrad wrote:
>
>> > Any news about these patches? From this series, we still have patches
>> > 4, 5, 6 and 8 pending in patchwork. Could you take into account the
>> > comments that have been made (mainly the strong need for more detailed
>> > commit logs), and resend updated versions on top of master?
>>
>> I'll work on them after 2014.05 release.
>
> Well, there is still some time before the 2014.05 release, so you can
> submit them earlier if you want.
>
> In the mean time, what can I do with your patches in patchwork? Can I
> mark them as "Changes requested", making the assumption you will
> remember to send updated versions in the future?

Ok.

Fran?ois

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

[Buildroot] [lua V3 0/8] lua

[Thomas Petazzoni]

Dear Francois Perrad,

On Sat,  1 Mar 2014 18:23:01 +0100, Francois Perrad wrote:

> Francois Perrad (8):
>   luajit: refactor without dont-strip.patch
>   luajit: refactor without shared-lib.patch
>   luajit: handles BR2_PREFER_STATIC_LIB
>   luajit: add host variant
>   luainterpreter: add host variant
>   luarocks: allow to work with host-luainterpreter
>   ljlinenoise: new package
>   lua-iconv: new package

From this series, there are still some patches pending in patchwork:

  [lua,V3,4/8] luajit: add host variant
  [lua,V3,5/8] luainterpreter: add host variant
  [lua,V3,6/8] luarocks: allow to work with host-luainterpreter
  [lua,V3,8/8] lua-iconv: new package

Could you respin them by using the host-virtual-package infrastructure
and resend an updated version?

In the mean time, I'll mark those patches as "Changes Requested" in
patchwork.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com